Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1b00ebf-fb06-6eb3-2fa2-7e7155594626@isovalent.com>
Date:   Wed, 13 Jul 2022 14:57:13 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [RFC PATCH v2 1/1] bpftool: Align dumped file headers with
 skeletons.
Content-Language: en-GB
To:     Francis Laniel <flaniel@linux.microsoft.com>, bpf@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220713134046.15020-1-flaniel@linux.microsoft.com>
 <20220713134046.15020-2-flaniel@linux.microsoft.com>
From:   Quentin Monnet <quentin@isovalent.com>
In-Reply-To: <20220713134046.15020-2-flaniel@linux.microsoft.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 13/07/2022 14:40, Francis Laniel wrote:
> This commit adds the following lines to file generated by dump:
> /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
> Hence, the dumped file headers follows that of skeletons.
> 
> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> ---
>  tools/bpf/bpftool/btf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> index 7e6accb9d9f7..066a0acd0ecd 100644
> --- a/tools/bpf/bpftool/btf.c
> +++ b/tools/bpf/bpftool/btf.c
> @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf,
>  	if (err)
>  		return err;
>  
> +	printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */\n");
> +	printf("/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */\n");
>  	printf("#ifndef __VMLINUX_H__\n");
>  	printf("#define __VMLINUX_H__\n");
>  	printf("\n");

Looks good, simpler than v1, thank you!

Reviewed-by: Quentin Monnet <quentin@isovalent.com>