Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     David Hildenbrand <david@redhat.com>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] maple_tree: Fix sparse reported issues
Thread-Topic: [PATCH] maple_tree: Fix sparse reported issues
Thread-Index: AQHYlfsoLhkzbf9CQkS2b2OLBBRjJa17+qSAgABSigA=
Date:   Wed, 13 Jul 2022 13:29:39 +0000
Message-ID: <20220713132926.3sl7gs67dyjj7kit@revolver>
References: <20220712142441.4184969-1-Liam.Howlett@oracle.com>
 <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com>
In-Reply-To: <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fzHmJ0XDu/xHaQmzne1yj87Y8vaiFUd7QhNRJvcfdCm4kgBgUzRfa1torx/W?=
 =?us-ascii?Q?595Y2xqVsqe1KAvccRxiEfAIxDX5dcrOxCNdqfD5dNqPl0a9PXaEUsek00hN?=
 =?us-ascii?Q?tpn0RUe3bMNa90svEUt2Vn/HlY0XoS+AlEIRfblOL2RPhMDe5MA/8bAvYTET?=
 =?us-ascii?Q?PYLAsQ95ifbaddJF9bRlDXbaKR4i7x2jFaprmWURkEwRS1qCF2DAHNjSPibB?=
 =?us-ascii?Q?IdtNO5F23Vk+88LdlDS5q0p58euKY771ddjwjnEu+YNZRMFH12THoEHXOu7L?=
 =?us-ascii?Q?rR9X1k0ScjYiyb1bv7vv6sSBaMK1R63ibibMEm9fImeyyjaVvZ8DLekYsjjH?=
 =?us-ascii?Q?roD5i8ILPMyLeyXKg8L7CSFHgGAW1gXXn/FyH9sbGxAYvVdPfQDu/rphn/1g?=
 =?us-ascii?Q?Xds6YTC4B5b+E9h8UhK1U7sKq5Whe8vRMVtz/5MnVVOLF0MLvtYqg7vJ0+BY?=
 =?us-ascii?Q?AnRiemG3ocrByPlKQBwpEVsfkwauIsvwFhaXI/TD0kRQ4lmQPnEcVgBuQuYa?=
 =?us-ascii?Q?5dGKVwBtbwG2FFp6I1ygDv3UqKtb7bJ0acZp3I0yhjdcYQ7akTS99gJ3qIoI?=
 =?us-ascii?Q?jQ0Y/qvor2UoxoGOJRhvsWXqOpek9o4LX3PGgMjtVkNMg9+l+rZCHC4bGSKc?=
 =?us-ascii?Q?+OTKm9lrmss1/hxJRzF4sbOTkV48KsIaRGMEzQwPU2g1G1bYbf7TIET69UGZ?=
 =?us-ascii?Q?EF6pTmDOzlfBx44x2S5XV6otnlu4g1KqV2Y628kysheyzWsyIgP3xwsKIEg/?=
 =?us-ascii?Q?us/hBUQugBcf/0WomZOdRyhCYaWFvDWbQDT9FOQaMpnxyBFt/49lS+tqtDqR?=
 =?us-ascii?Q?koz4burMFovfqxxQqphwH481WmrIJp1/N27HN1l9B4w68+EmaanD5/RN6pwr?=
 =?us-ascii?Q?7UIcpVKIozwv2jDQ4/MdgZx30lt9FHnunOrrkcrLX9nR4P36f+OZz/SBBusz?=
 =?us-ascii?Q?+UVvM373my6uJ22ix+73NquxpcRkQAVRkSR/YlWNdomBAqSFSemzwvFhPPDf?=
 =?us-ascii?Q?5paQDc/GnjXpTCh0d+4HFjeVKnFex3KnZpMCp1hKZhYd8wnLuwIZInADoJgw?=
 =?us-ascii?Q?i8qZQ1qLUTcImi9mwcqPSI28KEbWkXdAOu0j/PW8/g2LnXEqu0/4EY0bxUJ3?=
 =?us-ascii?Q?Os6JOyodf2RLrxGqPHQKs5fMf1ELpf/2M6AZbeX08/7/hmKa1uY139XxFqBD?=
 =?us-ascii?Q?3WSZRiBIvgQX+P/9XOkk8mAHz4lQy3d1/WWv4koNY8pSwwpZULvtjQrwgaCE?=
 =?us-ascii?Q?NzjBmZNd1chkx23/6D6twHeLob1O6u4ScGyKiYCMYGKSIInkqQsRarbTGD5x?=
 =?us-ascii?Q?qwlAJncopw2CTbZwtAyejGEZMZL+KJ8qv2FTlbX7Phcfpu41ZiBERfnDIIVg?=
 =?us-ascii?Q?/MjQKfCJBqqLKEGty+1c3Y5NAAz5m7rltUGbdOQ5TgNP5so4fizoXteJF/Ea?=
 =?us-ascii?Q?ZM+xMIe6b5bTkFOQORDs5epkH6fTVCYNXoMKy6Ki1O+a28U2QUH1Rmapd/Fo?=
 =?us-ascii?Q?9fd+AbYmaNb4ik+qpcVsSuRJZsFZjgdBKEqPlWo9Ybjt3hQyWZMFpaNjz71j?=
 =?us-ascii?Q?bnTvpXrHYRN8gUE+C+GYSf2b72JObWpQqVxXZCshIevgsXE30CbN519TK9wb?=
 =?us-ascii?Q?Eg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <65AD77BFFB314D46934873B540953430@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adcbd810-2c00-4f6a-76fe-08da64d3bcc4
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 13:29:39.3903
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mya3dJPatw3vy3MGD07RgBzYrmdX8DCowv5vxgqAE8+lVrr0C3C/z6z8luK9KbgmnFv6n6eCX6iY+PZYv+QEEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6188
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-13_02:2022-07-13,2022-07-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207130054
X-Proofpoint-ORIG-GUID: _k6KrifjAqDY_S3dwQhs9MRuhBFcSAcI
X-Proofpoint-GUID: _k6KrifjAqDY_S3dwQhs9MRuhBFcSAcI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* David Hildenbrand <david@redhat.com> [220713 04:34]:
> On 12.07.22 16:24, Liam Howlett wrote:
> > When building with C=3D1, the maple tree had some rcu type mismatch &
> > locking mismatches in the destroy functions.  There were cosmetic only
> > since this happens after the nodes are removed from the tree.
> >=20
> > Fixes: f8acc5e9581e (Maple Tree: add new data structure)
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
>=20
> Sorry to say, but the fixes become hard to follow (what/where/why). :)
>=20
> I guess it's time for a new series soon. Eventually it makes sense to
> send the fixes as reply to the individual problematic patches. (instead
> of fixes to commit ids that are not upstream)
>=20
> [yes, I'll do more review soon :) ]

I appreciate the feedback, it's much better than yelling into the void.
I have one more fix in the works - for __vma_adjust() of all functions
so that'll be impossible to follow anyways :)  I'll work on a v11 to
include that last one.

Thanks,
Liam=