Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 15:52:30 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Ben Dooks <ben.dooks@sifive.com>
Cc:     Rob Herring <robh@kernel.org>, linux-pwm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Lee Jones <lee.jones@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Greentime Hu <greentime.hu@sifive.com>,
        Jude Onyenegecha <jude.onyenegecha@sifive.com>,
        Sudip Mukherjee <sudip.mukherjee@sifive.com>,
        William Salmon <william.salmon@sifive.com>,
        Adnan Chowdhury <adnan.chowdhury@sifive.com>
Subject: Re: [PATCH 3/7] pwm: dwc: add of/platform support
Message-ID: <20220713135230.gjbd3v6iih2uicpu@pengutronix.de>
References: <20220712100113.569042-1-ben.dooks@sifive.com>
 <20220712100113.569042-4-ben.dooks@sifive.com>
 <20220712221715.GT1823936-robh@kernel.org>
 <feaacf44-f9a8-b892-d8ba-8a396b49d56b@sifive.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3hofxsieqbcumnqk"
Content-Disposition: inline
In-Reply-To: <feaacf44-f9a8-b892-d8ba-8a396b49d56b@sifive.com>
Precedence: bulk


--3hofxsieqbcumnqk
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 13, 2022 at 12:56:55PM +0100, Ben Dooks wrote:
> On 12/07/2022 23:17, Rob Herring wrote:
> > On Tue, Jul 12, 2022 at 11:01:09AM +0100, Ben Dooks wrote:
> > > The dwc pwm controller can be used in non-PCI systems, so allow
> > > either platform or OF based probing.
> > >=20
> > > Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
> > > ---
> > >   .../devicetree/bindings/pwm/pwm-synposys.yaml | 40 ++++++++++++++
> >=20
> > Use compatible string for filename.
>=20
> ok, will fix.
>=20
> > >   drivers/pwm/Kconfig                           |  5 +-
> > >   drivers/pwm/pwm-dwc.c                         | 53 ++++++++++++++++=
+++
> > >   3 files changed, 96 insertions(+), 2 deletions(-)
> > >   create mode 100644 Documentation/devicetree/bindings/pwm/pwm-synpos=
ys.yaml
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-synposys.yaml =
b/Documentation/devicetree/bindings/pwm/pwm-synposys.yaml
> > > new file mode 100644
> > > index 000000000000..38ac0da75272
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/pwm/pwm-synposys.yaml
> > > @@ -0,0 +1,40 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +# Copyright (C) 2022 SiFive, Inc.
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/pwm/pwm-synposys.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Synopsys PWM controller
> > > +
> > > +maintainers:
> > > +   - Ben Dooks <ben.dooks@sifive.com>
> > > +
> > > +properties:
> > > +  "#pwm-cells":
> > > +    description: |
> > > +      See pwm.yaml in this directory for a description of the cells =
format.
> >=20
> > pwm.yaml doesn't define how many cells. You need to. And you don't need
> > generic descriptions.
>=20
>  "#pwm-cells":
>     const: 1
>=20
> should be sufficient then?

I would expect a value of (at least) 2 or (better) 3.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--3hofxsieqbcumnqk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLOzhsACgkQwfwUeK3K
7Am62Qf+L9AW+vafE1WIr4bBIe4Lm7ps4yWWhhUuZ+QOa9k+eiwk377vUZ0JOty4
aobS23SPOM4gC+g5GERQZFShXLEHJDnEMlVj3+dXMfTlmQsxatoLc51Of9My4XS7
1+SeH73rG2LrtTRr5AvmFM7dVxUsTZO5clWP3ROueytPiWSVyqs2ioFgCq6e1rlF
xBLzOYCdXwi5CllVnC1znliuv5CcuO7eewSWX09ifeBFrp1EvYr5IxoPe4ZIg6Yz
GFuZXIbPhAJZS/LFhrQNTAYLjzwz2xpBAA5BID9jeON9Uf0hqhtVnhtdsv3OFN7z
TM+PdAFvbek87NuBqneOjFzZaDBVKA==
=U4yZ
-----END PGP SIGNATURE-----

--3hofxsieqbcumnqk--