Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 16:03:08 +0200
From:   Jan Kara <jack@suse.cz>
To:     Xiu Jianfeng <xiujianfeng@huawei.com>
Cc:     akpm@linux-foundation.org, axboe@kernel.dk, neilb@suse.de,
        johannes.thumshirn@wdc.com, jack@suse.cz, willy@infradead.org,
        mgorman@techsingularity.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] writeback: Cleanup bdi_sched_wait()
Message-ID: <20220713140308.5je2p3zz4vm4fvjb@quack3>
References: <20220713125314.171345-1-xiujianfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220713125314.171345-1-xiujianfeng@huawei.com>
Precedence: bulk

On Wed 13-07-22 20:53:14, Xiu Jianfeng wrote:
> bdi_sched_wait() is no longer used since commit 839a8e8660b6 ("writeback:
> replace custom worker pool implementation with unbound workqueue"),
> so remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Nice. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..e84b745a6811 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -140,12 +140,6 @@ static inline bool mapping_can_writeback(struct address_space *mapping)
>  	return inode_to_bdi(mapping->host)->capabilities & BDI_CAP_WRITEBACK;
>  }
>  
> -static inline int bdi_sched_wait(void *word)
> -{
> -	schedule();
> -	return 0;
> -}
> -
>  #ifdef CONFIG_CGROUP_WRITEBACK
>  
>  struct bdi_writeback *wb_get_lookup(struct backing_dev_info *bdi,
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR