Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp778498imw; Wed, 13 Jul 2022 07:52:54 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t9zCWcUqNLYXLTIhJZ4LgJWVobXhOeK9uXp9lmRMV9YOKV3J8hE0lfN3zEWTP+J8U6n02E X-Received: by 2002:aa7:c683:0:b0:43a:13fe:9c69 with SMTP id n3-20020aa7c683000000b0043a13fe9c69mr5424818edq.353.1657723974244; Wed, 13 Jul 2022 07:52:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657723974; cv=none; d=google.com; s=arc-20160816; b=z5U88ochtETjpXxEkEBi7VDucCVYIuctQvbRS/gj7FgPyINpfhCjdn+IBuGG50gGTV TERF8jI1WYTmbWDlai4GmDgRsCSdzRoeScbdcp4Un4cuzFMEfG+lFqX8imapkOj3YHIk IZK7XC5j5L97F78qisPmdkxJUyCaGADdGx8zeP0OoysalA466rNqpLvphOWdAEk2B4QU un+RgNNRolyAEhGcdmjQCvBTCH+3thbbWZTLIUSwT6qzOUPh4PECfZtIuQV9Az+Bvese CZx1VBnhLtOPUUhRV5inS0tgV/SLJZ7yZaySYeHE9KH3ZsBpDDAM2zKWBWC1GqdVgXYc TgGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=duF3Y9Z02+1a67NZ+Hlfg5VSoW3ZmuWvDf5dQcHYzN8=; b=HfwWszTP17cQsLpQ7xeCjBMLnksLhxFZ/MXeQcERHkyahzttG7MuZU/jI+/fZpe/oT fxolmrnJnvpWPaNX0B5iU0Rqk+QOU64NobQxwJ3hNZflha0xYjwSTdD/18tWEJ3DIP/B XsH+KObaaLyeDu7ChNyUbFSVlsRZIULRws3NUYde4b3jPnozCmSEB4f8RsHbmPZx8Yra MAJ/uyMoTHXvgYonj6+oqm3F5Z8ey/dOQig0+PDiAPz0N6lnJeLXxmRh8pVEZXIWpoem 76qoUTfY3qNgybzlb/FOgYLckGid6NUo0EGdMPLm5bkAWsCW5V3XIlg4VTP2igFajTSR VUKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=FO+wQKwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr2-20020a170907720200b0072af95f96dbsi19318739ejc.70.2022.07.13.07.52.29; Wed, 13 Jul 2022 07:52:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=FO+wQKwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236558AbiGMOcq (ORCPT + 99 others); Wed, 13 Jul 2022 10:32:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbiGMOcn (ORCPT ); Wed, 13 Jul 2022 10:32:43 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8883537FAA for ; Wed, 13 Jul 2022 07:32:41 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 857AF221D4; Wed, 13 Jul 2022 16:32:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1657722759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=duF3Y9Z02+1a67NZ+Hlfg5VSoW3ZmuWvDf5dQcHYzN8=; b=FO+wQKwZIzWjF3oOb7rj19/1KM4CKVAWVtrpt2+C0ESOkyPvH8W/PhlpgDHFGCM4kM1yMH 5T8yBKYBC3J4iQzC+dUOLVh8KRWy+UHsC+a8zRU7iSpx8RXUk6oaEFsQVjFTqOO2SGyDps Si5SbtFEho3nmREwOiMjvfDqKatBqj0= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 13 Jul 2022 16:32:38 +0200 From: Michael Walle To: Jae Hyun Yoo Cc: clg@kaod.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, p.yadav@ti.com, quic_ggregory@quicinc.com, quic_jiles@quicinc.com, tudor.ambarus@microchip.com Subject: Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN In-Reply-To: References: <20220710145721.1207157-1-quic_jaehyoo@quicinc.com> <20220711095042.2095360-1-michael@walle.cc> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <4972a85d04e39ebb7b4a5872f6632c45@walle.cc> X-Sender: michael@walle.cc X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 2022-07-13 16:26, schrieb Jae Hyun Yoo: >>> + { "w25q512nwq", INFO(0xef6020, 0, 64 * 1024, 1024) >> >> Please use INFO(0xef6020, 0, 0, 0) and test wether it will still >> work correctly. We will then be able to convert it to SNOR_ID3() >> later. > > Tested it but it doesn't work with INFO(0xef6020, 0, 0, 0). I'll keep > it as is. Can you please look into this? I'd expect this to work if the SFDP tables are correct because all this should come from the tables. You can look at /sys/kernel/debug/spi-nor/spi0.0/params and see what is changing there. Thanks, -michael