Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Francis Laniel <flaniel@linux.microsoft.com>
To:     bpf@vger.kernel.org, Quentin Monnet <quentin@isovalent.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2 1/1] bpftool: Align dumped file headers with skeletons.
Date:   Wed, 13 Jul 2022 16:44:10 +0200
Message-ID: <5839621.lOV4Wx5bFT@pwmachine>
Organization: Microsoft
In-Reply-To: <e1b00ebf-fb06-6eb3-2fa2-7e7155594626@isovalent.com>
References: <20220713134046.15020-1-flaniel@linux.microsoft.com> <20220713134046.15020-2-flaniel@linux.microsoft.com> <e1b00ebf-fb06-6eb3-2fa2-7e7155594626@isovalent.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Le mercredi 13 juillet 2022, 15:57:13 CEST Quentin Monnet a =E9crit :
> On 13/07/2022 14:40, Francis Laniel wrote:
> > This commit adds the following lines to file generated by dump:
> > /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> > /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
> > Hence, the dumped file headers follows that of skeletons.
> >=20
> > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> > ---
> >=20
> >  tools/bpf/bpftool/btf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> > index 7e6accb9d9f7..066a0acd0ecd 100644
> > --- a/tools/bpf/bpftool/btf.c
> > +++ b/tools/bpf/bpftool/btf.c
> > @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf,
> >=20
> >  	if (err)
> >  =09
> >  		return err;
> >=20
> > +	printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */\n");
> > +	printf("/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */\n");
> >=20
> >  	printf("#ifndef __VMLINUX_H__\n");
> >  	printf("#define __VMLINUX_H__\n");
> >  	printf("\n");
>=20
> Looks good, simpler than v1, thank you!
>=20
> Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thank you for the review!