Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Francis Laniel <flaniel@linux.microsoft.com>
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     bpf <bpf@vger.kernel.org>, Quentin Monnet <quentin@isovalent.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/1] bpftool: Align dumped file generated header with skeletons.
Date:   Wed, 13 Jul 2022 16:53:18 +0200
Message-ID: <4411407.LvFx2qVVIh@pwmachine>
Organization: Microsoft
In-Reply-To: <CAADnVQLVSoetPd5d1_tf=KkGou9iUWkt3ovgi8eeCWtbJtRUiw@mail.gmail.com>
References: <20220713144439.19738-1-flaniel@linux.microsoft.com> <20220713144439.19738-2-flaniel@linux.microsoft.com> <CAADnVQLVSoetPd5d1_tf=KkGou9iUWkt3ovgi8eeCWtbJtRUiw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Le mercredi 13 juillet 2022, 16:47:17 CEST Alexei Starovoitov a =E9crit :
> On Wed, Jul 13, 2022 at 7:45 AM Francis Laniel
>=20
> <flaniel@linux.microsoft.com> wrote:
> > This commit adds the following lines to file generated by dump:
> > /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
> > /* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
> > Hence, the dumped file headers follows that of skeletons.
> >=20
> > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> > ---
> >=20
> >  tools/bpf/bpftool/btf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/tools/bpf/bpftool/btf.c b/tools/bpf/bpftool/btf.c
> > index 7e6accb9d9f7..066a0acd0ecd 100644
> > --- a/tools/bpf/bpftool/btf.c
> > +++ b/tools/bpf/bpftool/btf.c
> > @@ -425,6 +425,8 @@ static int dump_btf_c(const struct btf *btf,
> >=20
> >         if (err)
> >        =20
> >                 return err;
> >=20
> > +       printf("/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
> > */\n");
> This was discussed earlier. It's incorrect and we cannot add just header
> to vmlinux.h

Oops sorry, I will send a v4 dropping it.
Nonetheless can you please send me a link for a discussion about this?

>=20
> > +       printf("/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */\n");
> >=20
> >         printf("#ifndef __VMLINUX_H__\n");
> >         printf("#define __VMLINUX_H__\n");
> >         printf("\n");
> >=20
> > --
> > 2.25.1