Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c8b65567-6a4d-2e61-b2a0-3a757ae9b36c@paragon-software.com>
Date:   Wed, 13 Jul 2022 19:41:58 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 0/2] fs/ntfs3: Refactoring and improving logic in run_pack
Content-Language: en-US
To:     Christoph Hellwig <hch@infradead.org>
CC:     <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
References: <d578fcbe-e1f7-ffc7-2535-52eecb271a01@paragon-software.com>
 <YsZkQAsKC6qxY8gi@infradead.org>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <YsZkQAsKC6qxY8gi@infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/7/22 07:42, Christoph Hellwig wrote:
> Hi Konstantin,
> 
> now that you have time to actively work on the ntfs3 driver again, can
> you consider looking into converting the I/O path to iomap, as already
> request during the merge?  Getting drivers off the old buffer head based
> I/O helpers is something we need to address in the coming years, so
> any relatively simple and actually maintained file system would be a
> good start.
> 
> On Wed, Jul 06, 2022 at 08:31:25PM +0300, Konstantin Komarov wrote:
>> 2 patches:
>> - some comments and making function static;
>> - improving speed of run_pack by checking runs in advance
>>
>> Konstantin Komarov (2):
>>    fs/ntfs3: Added comments to frecord functions
>>    fs/ntfs3: Check possible errors in run_pack in advance
>>
>>   fs/ntfs3/bitmap.c  |  3 +--
>>   fs/ntfs3/frecord.c |  8 ++++----
>>   fs/ntfs3/ntfs_fs.h |  1 -
>>   fs/ntfs3/run.c     | 41 +++++++++++++++++++++++------------------
>>   4 files changed, 28 insertions(+), 25 deletions(-)
>>
>> -- 
>> 2.37.0
>>
> ---end quoted text---

Hi Christoph

I will look into converting the I/O path to iomap.
Thank you for reminding about it.