Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Hugh Dickins <hughd@google.com>
CC:     David Hildenbrand <david@redhat.com>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] maple_tree: Fix sparse reported issues
Thread-Topic: [PATCH] maple_tree: Fix sparse reported issues
Thread-Index: AQHYlfsoLhkzbf9CQkS2b2OLBBRjJa17+qSAgABSigCAACjrgIAAH/GA
Date:   Wed, 13 Jul 2022 17:50:20 +0000
Message-ID: <20220713175013.aoemaelds45aavc4@revolver>
References: <20220712142441.4184969-1-Liam.Howlett@oracle.com>
 <653cc1da-e45a-9a93-7158-cee3e710ba35@redhat.com>
 <20220713132926.3sl7gs67dyjj7kit@revolver>
 <44a478e8-2ccc-e82-bd5a-172778c01529@google.com>
In-Reply-To: <44a478e8-2ccc-e82-bd5a-172778c01529@google.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W/pxoJjCOAVAxW3tiS8Heyoxn6aR0p9WYF0Ckq81drjHNmb2T6A4PisQqTNS?=
 =?us-ascii?Q?TYgBz4YUrEmsWXQOfN5N1QgTVWEixj7/mTbKUmycBJWwxD9NJLndVZaCbxWp?=
 =?us-ascii?Q?ip4jrCMFLRfWH5dP618+88tQlX0IGt0nYb1RHcTyTz9pXJya4u6ZXNSB0pmI?=
 =?us-ascii?Q?ENYZazKVOiC4MtfJWoaML4ZHDIdFGK9IuGXB0+W6GWPWBIFkTVsr0IEoM9BR?=
 =?us-ascii?Q?DsaNxP8/opai3u70L2QBS4fyaLvbbxAG+Rm1oVadbeM1aM6r0GFObwpV8lf0?=
 =?us-ascii?Q?SSeXIz59VVl16yiMUh73cZcF9xuVLotj5R6ptleyBADaPkGWnOxzoDa91XHg?=
 =?us-ascii?Q?yp7vLuk6O0dVniL44SI33ewE0xdjnQAgrvFC2I+SiologSGeJyhdkyb2XK9q?=
 =?us-ascii?Q?nVraGvQ7qiWNo+5/xgMb8oY/4ytuoABogULSMrlTFuDgOm1ngOZA6n3gkpux?=
 =?us-ascii?Q?0xKCAegiYNhMfFJ7Q0n+mwvWyaVWc+CiZyiegnpA+ENvl/8Zm1B9wkV8jaFG?=
 =?us-ascii?Q?95epsejwF0XjiDzW1VG6VzU4Lt1/wyi2hNlemSMEf4aHEjY06LwROqvRY60v?=
 =?us-ascii?Q?uiKbfHnvnBcrXbE+OmDUj8iqeC21iJj83MKbbk2p5a6fWv2PV6eal15/lOoa?=
 =?us-ascii?Q?GIBe417u1EZLajP/T5xgkcsBPmok+qU+KLZlqGFnDKItSQdfpp+dqhxbR8IA?=
 =?us-ascii?Q?XrZqZh6/FHLUntkiy43U3OCC5xxjplNC7NpJpAqyeFQcoLDePLyK846ksG3c?=
 =?us-ascii?Q?Zc/qVa/J9sLwLvnZHF7OoiSseslKhmcsFcOm6XKTg5NsyT94olcUFnBMRwDx?=
 =?us-ascii?Q?6PUcB+g4c1qT2WpHQ30YayCPTDijItH7ZWRuqu8N0sU5kTh8GmE71Up90DMP?=
 =?us-ascii?Q?PyL/Dp+qevrJbDLh+HFYDzbtv0JjE+LHKXkVXkFDMrpX3rtjASFwKmYsvgVm?=
 =?us-ascii?Q?xWt4Sns5f+n84Gr/BEe72SDgRM0PDEePflPitr5z6lHnxSqWGQU9NBwAvnyS?=
 =?us-ascii?Q?xJy5hzeIKhVzlkUaKW6KygjY/1rP5Z3gG09oBvjq7W0SvTAR/txw5uVsH9hI?=
 =?us-ascii?Q?/eq5NyIb9ORdzgG3iE30VjZ6ZSmYiWYLTjwNgJ8mrlCdrK2OLJ8RYc4k/9kD?=
 =?us-ascii?Q?etelkf8YRzHvrfK0Vmh1tyWTJKKnCMefKu3MzCRaOnQFS/qdjqiG4QG/mRcD?=
 =?us-ascii?Q?rzi4IEnmbbphq/8KV7TMIGs16F0z8mabJkGHp/pORoLYHFHmaexhmVUeMtW8?=
 =?us-ascii?Q?OL//vBanwvOllkTrtgCiQD0PZDnKKGCiE9Evdji0K5klDQfWPACxy12Ujb1x?=
 =?us-ascii?Q?Eb9uQYJBl5sgA/vEOc+A2nup/YLUTUi/B5DP59+Urii2/qihgLYVEdtzFFKx?=
 =?us-ascii?Q?ZaOfalB/WiWN5vlqJfcXi9UW6yQWXgehaIkFffBwlu/zwn9B0mavNzbTAtpz?=
 =?us-ascii?Q?AiPlONU8d93YFGdUPeQF1O5d2dtAZTCdwbZ/Ee/Xzes4ARWH0A5Hp1ihn9P/?=
 =?us-ascii?Q?/ZrpgCUDNmJmpOU/ya7L3rpeUzRjv8CCkJlNf7O01DanjmD6qJGCOq+lnIpo?=
 =?us-ascii?Q?Z00NNc+rw4XD0CIJ2XjiLtDy1Qnp0vmPN2jFSuIgw3ktj1zuTmWNYDCR/XQv?=
 =?us-ascii?Q?6w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EC422E973405A543B8E54A391FD207DC@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ebc731e-e7ac-4d25-31c7-08da64f827b8
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 17:50:20.7083
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JbjXXkWiM5QobLDlAtYDLQgACe8jh7zFKTEvlTvw4we8QOnvVgyzqUVlHsTBx3bpvJaVNxXyJRVmL70UMZAx5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4314
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-13_07:2022-07-13,2022-07-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207130073
X-Proofpoint-GUID: RbdkW9MMAE_pUrsMDdupc1aa5Fzva_v-
X-Proofpoint-ORIG-GUID: RbdkW9MMAE_pUrsMDdupc1aa5Fzva_v-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Hugh Dickins <hughd@google.com> [220713 11:56]:
> On Wed, 13 Jul 2022, Liam Howlett wrote:
> > * David Hildenbrand <david@redhat.com> [220713 04:34]:
> > > On 12.07.22 16:24, Liam Howlett wrote:
> > > > When building with C=3D1, the maple tree had some rcu type mismatch=
 &
> > > > locking mismatches in the destroy functions.  There were cosmetic o=
nly
> > > > since this happens after the nodes are removed from the tree.
> > > >=20
> > > > Fixes: f8acc5e9581e (Maple Tree: add new data structure)
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> > >=20
> > > Sorry to say, but the fixes become hard to follow (what/where/why). :=
)
> > >=20
> > > I guess it's time for a new series soon. Eventually it makes sense to
> > > send the fixes as reply to the individual problematic patches. (inste=
ad
> > > of fixes to commit ids that are not upstream)
> > >=20
> > > [yes, I'll do more review soon :) ]
> >=20
> > I appreciate the feedback, it's much better than yelling into the void.
> > I have one more fix in the works - for __vma_adjust() of all functions
> > so that'll be impossible to follow anyways :)  I'll work on a v11 to
> > include that last one.
>=20
> Please do also post the incremental for that "one more fix" once it's
> ready: I have been keeping up with what you've been posting so far,
> folding them into my debugging here, and believe we have made some but
> still not enough progress on the bugs I hit.  Folding in one more fix
> will be easy for me, advancing to v11 of a 69-part patchset will be...
> dispiriting.


Okay, thanks.  I don't think it will fix your outstanding issues but it
is necessary to fix case 6 of vma_merge() on memory allocation failure
as reported by syzbot.