Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756257AbXFAFYO (ORCPT ); Fri, 1 Jun 2007 01:24:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754096AbXFAFYA (ORCPT ); Fri, 1 Jun 2007 01:24:00 -0400 Received: from 85.8.24.16.se.wasadata.net ([85.8.24.16]:43992 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306AbXFAFYA (ORCPT ); Fri, 1 Jun 2007 01:24:00 -0400 Message-ID: <465FAD94.4020200@drzeus.cx> Date: Fri, 01 Jun 2007 07:24:36 +0200 From: Pierre Ossman User-Agent: Thunderbird 2.0.0.0 (X11/20070419) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_hera.drzeus.cx-11149-1180675438-0001-2" To: Andrew Morton CC: LKML Subject: Re: [PATCH] Make prepare_namespace() wait for devices References: <4655834F.3050301@drzeus.cx> <20070524170654.5d674474.akpm@linux-foundation.org> <4656602A.3010000@drzeus.cx> <20070524211737.daa3c99c.akpm@linux-foundation.org> <465666AE.5020600@drzeus.cx> <465EAF90.3030803@drzeus.cx> <20070531085114.420b9cbe.akpm@linux-foundation.org> In-Reply-To: <20070531085114.420b9cbe.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3409 Lines: 111 This is a MIME-formatted message. If you see this text it means that your E-mail software does not support MIME-formatted messages. --=_hera.drzeus.cx-11149-1180675438-0001-2 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Andrew Morton wrote: > On Thu, 31 May 2007 13:20:48 +0200 Pierre Ossman wrote: > >> What was the verdict here? Were you satisfied with this or do you need a change? >> > > > I was kinda hoing to see version #2 with that funny loop cleaned up a bit? > > New patch with the layout you suggested. It may be fewer lines, but I still say my version was more readable. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org --=_hera.drzeus.cx-11149-1180675438-0001-2 Content-Type: text/x-patch; name="initwait.patch"; charset=iso-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="initwait.patch" commit 6354cb955ce1602b7b259f525edac7c8f585574b Author: Pierre Ossman Date: Mon May 14 14:15:46 2007 +0200 init: wait for asynchronously scanned block devices Some buses (e.g. USB and MMC) do their scanning of devices in the background, causing a race between them and prepare_namespace(). In order to be able to use these buses without an initrd, we now wait for the device specified in root= to actually show up. If the device never shows up than we will hang in an infinite loop. In order to not mess with setups that reboot on panic, the feature must be turned on via the command line option "rootwait". Signed-off-by: Pierre Ossman diff --git a/init/do_mounts.c b/init/do_mounts.c index 46fe407..4e5ef6a 100644 --- a/init/do_mounts.c +++ b/init/do_mounts.c @@ -25,6 +25,7 @@ int __initdata rd_doload; /* 1 = load RAM disk, 0 = don't load */ int root_mountflags = MS_RDONLY | MS_SILENT; char * __initdata root_device_name; static char __initdata saved_root_name[64]; +int __initdata root_wait; dev_t ROOT_DEV; @@ -216,6 +217,14 @@ static int __init root_dev_setup(char *line) __setup("root=", root_dev_setup); +static int __init rootwait_setup(char *line) +{ + root_wait = simple_strtol(line,NULL,0); + return 1; +} + +__setup("rootwait=", rootwait_setup); + static char * __initdata root_mount_data; static int __init root_data_setup(char *str) { @@ -438,11 +447,20 @@ void __init prepare_namespace(void) root_device_name += 5; } - is_floppy = MAJOR(ROOT_DEV) == FLOPPY_MAJOR; - if (initrd_load()) goto out; + /* wait for any asynchronous scanning to complete */ + if ((ROOT_DEV == 0) && root_wait) { + printk(KERN_INFO "Waiting for root device %s...\n", + saved_root_name); + while (driver_probe_done() != 0 || + (ROOT_DEV = name_to_dev_t(saved_root_name)) == 0) + msleep(100); + } + + is_floppy = MAJOR(ROOT_DEV) == FLOPPY_MAJOR; + if (is_floppy && rd_doload && rd_load_disk(0)) ROOT_DEV = Root_RAM0; --=_hera.drzeus.cx-11149-1180675438-0001-2-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/