Return-Path: <linux-kernel-owner+w=401wt.eu-S1757133AbXFAF07@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757133AbXFAF07 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 Jun 2007 01:26:59 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753306AbXFAF0w
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 1 Jun 2007 01:26:52 -0400
Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:38897 "EHLO
	fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750925AbXFAF0v (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 Jun 2007 01:26:51 -0400
Date: Fri, 01 Jun 2007 14:26:17 +0900
From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Paul Mundt <lethal@linux-sh.org>,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sparsemem: Shut up unused symbol compiler warnings.
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
In-Reply-To: <20070601042515.GA8628@linux-sh.org>
References: <20070601042515.GA8628@linux-sh.org>
X-Mailer-Plugin: BkASPil for Becky!2 Ver.2.068
Message-Id: <20070601142124.91F8.Y-GOTO@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Mailer: Becky! ver. 2.27 [ja]
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2736
Lines: 98


I think this issue is fixed by
move-three-functions-that-are-only-needed-for.patch in current -mm tree.
Is it not enough?

Thanks.

> __kmalloc_section_memmap()/__kfree_section_memmap() and friends are only
> used by the memory hotplug code. Move these in to the existing
> CONFIG_MEMORY_HOTPLUG block.
> 
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> 
> --
> 
>  mm/sparse.c |   42 +++++++++++++++++++++---------------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/mm/sparse.c b/mm/sparse.c
> index 1302f83..35f739a 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -229,6 +229,7 @@ static struct page __init *sparse_early_mem_map_alloc(unsigned long pnum)
>  	return NULL;
>  }
>  
> +#ifdef CONFIG_MEMORY_HOTPLUG
>  static struct page *__kmalloc_section_memmap(unsigned long nr_pages)
>  {
>  	struct page *page, *ret;
> @@ -269,27 +270,6 @@ static void __kfree_section_memmap(struct page *memmap, unsigned long nr_pages)
>  }
>  
>  /*
> - * Allocate the accumulated non-linear sections, allocate a mem_map
> - * for each and record the physical to section mapping.
> - */
> -void __init sparse_init(void)
> -{
> -	unsigned long pnum;
> -	struct page *map;
> -
> -	for (pnum = 0; pnum < NR_MEM_SECTIONS; pnum++) {
> -		if (!valid_section_nr(pnum))
> -			continue;
> -
> -		map = sparse_early_mem_map_alloc(pnum);
> -		if (!map)
> -			continue;
> -		sparse_init_one_section(__nr_to_section(pnum), pnum, map);
> -	}
> -}
> -
> -#ifdef CONFIG_MEMORY_HOTPLUG
> -/*
>   * returns the number of sections whose mem_maps were properly
>   * set.  If this is <=0, then that means that the passed-in
>   * map was not consumed and must be freed.
> @@ -329,3 +309,23 @@ out:
>  	return ret;
>  }
>  #endif
> +
> +/*
> + * Allocate the accumulated non-linear sections, allocate a mem_map
> + * for each and record the physical to section mapping.
> + */
> +void __init sparse_init(void)
> +{
> +	unsigned long pnum;
> +	struct page *map;
> +
> +	for (pnum = 0; pnum < NR_MEM_SECTIONS; pnum++) {
> +		if (!valid_section_nr(pnum))
> +			continue;
> +
> +		map = sparse_early_mem_map_alloc(pnum);
> +		if (!map)
> +			continue;
> +		sparse_init_one_section(__nr_to_section(pnum), pnum, map);
> +	}
> +}
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

-- 
Yasunori Goto 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/