Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3295df49-1ef0-7726-5cfa-462bac1ccf12@redhat.com>
Date:   Wed, 13 Jul 2022 23:24:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] pinctrl: Don't allow PINCTRL_AMD to be a module
Content-Language: en-US
To:     Mario Limonciello <mario.limonciello@amd.com>,
        Linus Walleij <linus.walleij@linaro.org>
Cc:     Basavaraj.Natikar@amd.com, madcatx@atlas.cz,
        jwrdegoede@fedoraproject.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220713175950.964-1-mario.limonciello@amd.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20220713175950.964-1-mario.limonciello@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 7/13/22 19:59, Mario Limonciello wrote:
> It was observed that by allowing pinctrl_amd to be loaded
> later in the boot process that interrupts sent to the GPIO
> controller early in the boot are not serviced.  The kernel treats
> these as a spurious IRQ and disables the IRQ.
> 
> This problem was exacerbated because it happened on a system with
> an encrypted partition so the kernel object was not accesssible for
> an extended period of time while waiting for a passphrase.
> 
> To avoid this situation from occurring, stop allowing pinctrl-amd
> from being built as a module and instead require it to be built-in
> or disabled.
> 
> Reported-by: madcatx@atlas.cz
> Suggested-by: jwrdegoede@fedoraproject.org

Note I generally use: "Hans de Goede <hdegoede@redhat.com>" for all
things kernel related.

This looks good to me. Fedora is already building in amd-pinctrl
which AFAIK is done because of similar issues to the reason given
in the commit message:

Acked-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216230
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>  drivers/pinctrl/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f52960d2dfbe..bff144c97e66 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -32,7 +32,7 @@ config DEBUG_PINCTRL
>  	  Say Y here to add some extra checks and diagnostics to PINCTRL calls.
>  
>  config PINCTRL_AMD
> -	tristate "AMD GPIO pin control"
> +	bool "AMD GPIO pin control"
>  	depends on HAS_IOMEM
>  	depends on ACPI || COMPILE_TEST
>  	select GPIOLIB