Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1168626imw; Wed, 13 Jul 2022 15:05:56 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uRV6KG8S0ts13ueeafVajPECd7ddkPnz29GzWs63nNB32RsLSUmsF2pU09s44lNuby4yIp X-Received: by 2002:a05:6a00:2401:b0:528:57cf:5720 with SMTP id z1-20020a056a00240100b0052857cf5720mr5302055pfh.60.1657749956567; Wed, 13 Jul 2022 15:05:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657749956; cv=none; d=google.com; s=arc-20160816; b=JLV2V8/jKUdfIf4WIyTqP4X17zVg7tQ2/IG/77/fWmZfw9Xb/8ra9nbhlH1UYf+LG5 fgXruyHn6qTTDL0PIJOr0FlMU1o3uMUvFt/NtLH3GBw22DNAsM47yRMjV4r+HQezoyNf FirQpBm4WSKry+i6cosQqu6Azgwa6OeuIN1hmD69kyAlfgS8T3RqxKCQnya/r2GGruwy FACHTS1Moflns0HxG62iXG3wrWW7WGGcVm9Y68XxLmPWhpGyZL5NczOBS92Rp2STypr9 PVYiu/LFbGkxBxt6zfMS+lPqShmjwdkbspu9p2YFijLw6tLPtyqBjY4g/VcuU2G2bwy+ LZ5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yrJpFup50i9PqFbfHOE9Fq01fjk/P2jVrSt8zfocwH0=; b=Gv6zIKW8I97ieXyAtyVQRDw5Khp71udeTxH+rSi5d6nQ8UcqaMIWCHlV9fgIBoQvnl FBDqmZzWG2J8PUOtbvtJI+XcTb78ZMOWUxggJue4jwdApcjh4wWRLGzuhUjux3DAWzna 51pYVThZqOIQ1HJLXTv7ihc0DPq4N/DEptBeOVwu+7IckisCmx0gu7Iynm5zvc7Fy7pj YYC0AZnGEVtRQ8qvmYBUteqGgoD9+DiASjgR0nhkJWsyb0pp1C7moI4hOpRm5dhyTBjh UWH2Osi+apuZzaRncpYvbfO0URgridXyukqIY1Z3HFMTwv3GNvU0Afk4wtbZxPjMFJqj 9hmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ge1+TmrP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r184-20020a632bc1000000b00414ec29c59esi18505661pgr.426.2022.07.13.15.05.44; Wed, 13 Jul 2022 15:05:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ge1+TmrP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237472AbiGMVYj (ORCPT + 99 others); Wed, 13 Jul 2022 17:24:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237449AbiGMVYh (ORCPT ); Wed, 13 Jul 2022 17:24:37 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4437C1F61F; Wed, 13 Jul 2022 14:24:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EB51BB8215D; Wed, 13 Jul 2022 21:24:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52E08C34114; Wed, 13 Jul 2022 21:24:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657747474; bh=Ash71LMIDavsJFdmUEcbu+7cEaTspXzRK+dGswfzeIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ge1+TmrP5VVPysTG6lyvt/etpY0RWg96jNg7PkyhWqm4uj67R+ub92GC1aSzkx1nE GyWHa/hdauSk7+g8Xg+WSpdXC+78x89Be4a674ls56XKAqE2onO70ffaltn/I2O1OY h6+LSuQeV6y+nctS/8+ULoII67/PkWtZ2QyMHPwEKe6uHFNKAuN0Kpx21CpsZAF3zB 3JlgP2OMhNfe3XOn7J0DEQ59WlBljpu2lMO1ZTvnAMxl9e9uuPGgIJToWbGuGP7JCw GoSiqm3WuYCVX/hllgpjc0BiCPd06tGHRfKuKOw/1Umif/KgSbUFEO9lPTrMZB+J2B 8ms4Iyu64Z5lw== Date: Wed, 13 Jul 2022 14:24:33 -0700 From: Jakub Kicinski To: Aleksander Bajkowski Cc: Eric Dumazet , hauke@hauke-m.de, David Miller , Paolo Abeni , netdev , LKML Subject: Re: [PATCH net-next] net: lantiq_xrx200: use skb cache Message-ID: <20220713142433.131e5a26@kernel.org> In-Reply-To: <72d3a578-f321-41aa-858c-9f3a6978a277@wp.pl> References: <20220712181456.3398-1-olek2@wp.pl> <72d3a578-f321-41aa-858c-9f3a6978a277@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jul 2022 22:38:37 +0200 Aleksander Bajkowski wrote: > > If you are changing this code path, what about adding proper error recovery ? > > > > skb can be NULL at this point :/ > > Good catch. I will try to test the fix on the device tomorrow and send the patch. Let's defer this patch until we merge the fix, otherwise we'll get a conflict. Not a big deal but easily avoidable here.