Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 18:02:13 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 04/39] drm/i915: fix kernel-doc trivial warnings on
 i915/*.[ch] files
Message-ID: <Ys9A5fWUF4cwOI+9@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <edf15495f1da28766fe9baadd4ec71fd7bbe8b75.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <edf15495f1da28766fe9baadd4ec71fd7bbe8b75.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?soxrnbCqk+a0RT+PRG/iTTD5Z5YZsyfUdc9fEiSpO1z0raqDK2+pG6IQyg1G?=
 =?us-ascii?Q?JPD6B++qBA7/TEqmaXw5OgpUEa9HNs9WCplVYc6BIcX2LELzlollC/L5owIM?=
 =?us-ascii?Q?TqD0cysvo6sidBWJBqYcjkjb5lYYrjqiYPPNN/uWS2+QBSohbE/nrM2uxKDE?=
 =?us-ascii?Q?0wilEhM0GhMxQO5TDicoRU/3pK+sx1tDxEB9nWlQ5POJsl5dMA/hlENqSgE+?=
 =?us-ascii?Q?EFzh18l4GMfyLXKtLMAOkXsTDbAvTxhtziGFwYkqO0xFIVPRKQZBCn+jXlG9?=
 =?us-ascii?Q?IBY+vRDcz8yaYhTKXG3GV6wAt/tLSFcXSl71oVtpMWchKjg2tT7uc3a/PvFp?=
 =?us-ascii?Q?rD95uiNSCqTcLdHL8EkhyBzPGy0DyrhkF5yOr5i+zoQ6zFZZidXrzjliNzpL?=
 =?us-ascii?Q?SqUMDjjrCS+uIJ6QGEdGsIGfX9tmBZjsWb7HTsEJpfwBzVPYAPoDhmLBkZ+Y?=
 =?us-ascii?Q?zN5vjHg9I259Bxq8rRtW4tU96GyhtyEsjU0O9vBmBg5DLFc5C5pvN9ZL0Xo9?=
 =?us-ascii?Q?UG7SFYj5NOfMyzJQNQDbSTZbkrx/jNU+KkS7aeS0y/VOd1lUWdzaXiKGuKRL?=
 =?us-ascii?Q?cTCGNFjdAYtztcKr4tqFKJR1PN5m8ETzIpGRIDwCpSdYVOZ61QCgCpDK0BkL?=
 =?us-ascii?Q?lPMmmY5FEKEAu7qhc061yYNHPqiAcU6yYkpqaAf4mHeE/YyBbtiH2CniQiB6?=
 =?us-ascii?Q?uLMrZc31mBq2c3145A3Ty7lbShCAuUuNpabavO/eMudWEV1by1L3mYOA1bWs?=
 =?us-ascii?Q?D0ZXbtgZ7ulpXztf2geUDZ93t7dpDNREqgL6E5BRpWU4/feq/rqKtjsR0bSx?=
 =?us-ascii?Q?dvTtJIln5lODEkgRrZlEDLGfHGOer5bOtAAfKSX2VJqRZNAntlrGf+QuJYdl?=
 =?us-ascii?Q?gVtm6NTlIY3pLA6h1DMoQdP3Oighks+Kd7g9nea18N2HJ8SA5dl+4zCzYVOW?=
 =?us-ascii?Q?f04e9j1eC5Lf5I8DS9aBEEVtWSmzLnJ5KBs2PW3FVma4FECSVODeOPr6/rNy?=
 =?us-ascii?Q?IyeEsS3Y207Vej2HAm8Qk/9Wwhvl2MYdt/PdVUKLkWVrOcGEacB6wfw5wp/E?=
 =?us-ascii?Q?M5G8QZcDLSADy+zkBMmegji0DavaGTSXAbKwlzTvc+ri5/nx/1X1BITZMaq9?=
 =?us-ascii?Q?jH8JqxkulcH7L20eJqTgQB5Faz+DDx5SgEzywGjJ52SdGN4nvFgItwlxO+sm?=
 =?us-ascii?Q?RvGIij+skVMHFsTeDBzK7342RL3a233BMIziZi4jS4MAfAPGgDIVdRRd6rz2?=
 =?us-ascii?Q?ugwHYaXJO4XQpEBHM1AFZsD1KP8Y4K8vDNvm6owAOSRBgJPY9YvtyQEbcmDU?=
 =?us-ascii?Q?W1/093C9G0WkMg9QkvtQlkTnWlF6ywyQqc35o7FtNNmvzvzl/C+hpmLAKQ/c?=
 =?us-ascii?Q?GKJE2TcUL4g4h7dhWuS1hvoRJMxwEnigHMUCS5bJu+ORS53N+C815PIgx3jW?=
 =?us-ascii?Q?S0TxcLjliYFWmcAfmFZ6HiRKBVjsyaRNZtFhplVKRwfB7YWafsmb/OYge0pZ?=
 =?us-ascii?Q?Yfpx1xdXVUkRwcvSyl8esMXNW9oz5jV6t7RiSoKvBzosvWwHJbpHE5OJxFZr?=
 =?us-ascii?Q?KAnTRDhh/MW49iQm1zh3btBUlC/TMS7ph7M+3Uqh43YJYvyNLa3bOeVZ2IrF?=
 =?us-ascii?Q?HQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 547e8d66-077d-4768-f039-08da651b5a03
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 22:02:18.9774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L3R2NuOc3ha+EfbRbxvfMzxtGR5ZTRyNYKHIYW6ZG49MjXRJngnKK+FT/e9BKUUNTgAKAHWV7vxRpVXwV/RPCQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1495
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:11:52AM +0100, Mauro Carvalho Chehab wrote:
> There are several trivial warnings there, due to trivial things:
> 	- lack of function name at the kerneldoc markup;
> 	- renamed functions;
> 	- wrong parameter syntax.
> 
> Fix such warnings:
> 	drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member 'active' not described in '__i915_active_fence_init'
> 	drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member 'fence' not described in '__i915_active_fence_init'
> 	drivers/gpu/drm/i915/i915_active.h:66: warning: Function parameter or member 'fn' not described in '__i915_active_fence_init'
> 	drivers/gpu/drm/i915/i915_active.h:89: warning: Function parameter or member 'active' not described in 'i915_active_fence_set'
> 	drivers/gpu/drm/i915/i915_active.h:89: warning: Function parameter or member 'rq' not described in 'i915_active_fence_set'
> 	drivers/gpu/drm/i915/i915_active.h:102: warning: Function parameter or member 'active' not described in 'i915_active_fence_get'
> 	drivers/gpu/drm/i915/i915_active.h:122: warning: Function parameter or member 'active' not described in 'i915_active_fence_isset'
> 	drivers/gpu/drm/i915/i915_gem.c:443: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * Reads data from the object referenced by handle.
> 	drivers/gpu/drm/i915/i915_gem.c:532: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * This is the fast pwrite path, where we copy the data directly from the
> 	drivers/gpu/drm/i915/i915_gem.c:717: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * Writes data to the object referenced by handle.
> 	drivers/gpu/drm/i915/i915_gem.c:802: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * Called when user space has done writes to this buffer
> 	drivers/gpu/drm/i915/i915_pmu.h:22: warning: cannot understand function prototype: 'enum i915_pmu_tracked_events '
> 	drivers/gpu/drm/i915/i915_pmu.h:33: warning: cannot understand function prototype: 'enum '
> 	drivers/gpu/drm/i915/i915_pmu.h:42: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * How many different events we track in the global PMU mask.
> 	drivers/gpu/drm/i915/i915_request.h:177: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * Request queue structure.
> 	drivers/gpu/drm/i915/i915_request.h:473: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 	 * Returns true if seq1 is later than seq2.
> 	drivers/gpu/drm/i915/i915_scatterlist.c:63: warning: Function parameter or member 'size' not described in 'i915_refct_sgt_init'
> 	drivers/gpu/drm/i915/i915_scatterlist.h:153: warning: Incorrect use of kernel-doc format:          * release() - Free the memory of the struct i915_refct_sgt
> 	drivers/gpu/drm/i915/i915_scatterlist.h:157: warning: Function parameter or member 'release' not described in 'i915_refct_sgt_ops'
> 	drivers/gpu/drm/i915/i915_scatterlist.h:180: warning: Function parameter or member 'rsgt' not described in 'i915_refct_sgt_put'
> 	drivers/gpu/drm/i915/i915_scatterlist.h:191: warning: Function parameter or member 'rsgt' not described in 'i915_refct_sgt_get'
> 	drivers/gpu/drm/i915/i915_scatterlist.h:207: warning: Function parameter or member 'rsgt' not described in '__i915_refct_sgt_init'
> 	drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'OP' not described in '__wait_for'
> 	drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'COND' not described in '__wait_for'
> 	drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'US' not described in '__wait_for'
> 	drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'Wmin' not described in '__wait_for'
> 	drivers/gpu/drm/i915/i915_utils.h:291: warning: Function parameter or member 'Wmax' not described in '__wait_for'
> 	drivers/gpu/drm/i915/i915_vma_resource.h:88: warning: Incorrect use of kernel-doc format:          * struct i915_vma_bindinfo - Information needed for async bind
> 	drivers/gpu/drm/i915/i915_vma_resource.h:123: warning: Function parameter or member 'bi' not described in 'i915_vma_resource'
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

functions should change to have "()" or not?
whatever you decide, keep it consistent and feel free to use

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/i915_active.h       | 14 +++++++-------
>  drivers/gpu/drm/i915/i915_gem.c          | 10 ++++++----
>  drivers/gpu/drm/i915/i915_pmu.h          |  6 +++---
>  drivers/gpu/drm/i915/i915_request.h      |  4 ++--
>  drivers/gpu/drm/i915/i915_scatterlist.c  |  2 +-
>  drivers/gpu/drm/i915/i915_scatterlist.h  | 10 +++++-----
>  drivers/gpu/drm/i915/i915_utils.h        |  2 +-
>  drivers/gpu/drm/i915/i915_vma_resource.h |  2 +-
>  8 files changed, 26 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_active.h b/drivers/gpu/drm/i915/i915_active.h
> index 7eb44132183a..77c676ecc263 100644
> --- a/drivers/gpu/drm/i915/i915_active.h
> +++ b/drivers/gpu/drm/i915/i915_active.h
> @@ -49,9 +49,9 @@ void i915_active_noop(struct dma_fence *fence, struct dma_fence_cb *cb);
>  
>  /**
>   * __i915_active_fence_init - prepares the activity tracker for use
> - * @active - the active tracker
> - * @fence - initial fence to track, can be NULL
> - * @func - a callback when then the tracker is retired (becomes idle),
> + * @active: the active tracker
> + * @fence: initial fence to track, can be NULL
> + * @fn: a callback when then the tracker is retired (becomes idle),
>   *         can be NULL
>   *
>   * i915_active_fence_init() prepares the embedded @active struct for use as
> @@ -77,8 +77,8 @@ __i915_active_fence_set(struct i915_active_fence *active,
>  
>  /**
>   * i915_active_fence_set - updates the tracker to watch the current fence
> - * @active - the active tracker
> - * @rq - the request to watch
> + * @active: the active tracker
> + * @rq: the request to watch
>   *
>   * i915_active_fence_set() watches the given @rq for completion. While
>   * that @rq is busy, the @active reports busy. When that @rq is signaled
> @@ -89,7 +89,7 @@ i915_active_fence_set(struct i915_active_fence *active,
>  		      struct i915_request *rq);
>  /**
>   * i915_active_fence_get - return a reference to the active fence
> - * @active - the active tracker
> + * @active: the active tracker
>   *
>   * i915_active_fence_get() returns a reference to the active fence,
>   * or NULL if the active tracker is idle. The reference is obtained under RCU,
> @@ -111,7 +111,7 @@ i915_active_fence_get(struct i915_active_fence *active)
>  
>  /**
>   * i915_active_fence_isset - report whether the active tracker is assigned
> - * @active - the active tracker
> + * @active: the active tracker
>   *
>   * i915_active_fence_isset() returns true if the active tracker is currently
>   * assigned to a fence. Due to the lazy retiring, that fence may be idle
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 702e5b89be22..41e83d078a70 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -439,7 +439,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj,
>  }
>  
>  /**
> - * Reads data from the object referenced by handle.
> + * i915_gem_pread_ioctl - Reads data from the object referenced by handle.
>   * @dev: drm device pointer
>   * @data: ioctl data blob
>   * @file: drm file pointer
> @@ -528,7 +528,8 @@ ggtt_write(struct io_mapping *mapping,
>  }
>  
>  /**
> - * This is the fast pwrite path, where we copy the data directly from the
> + * i915_gem_gtt_pwrite_fast - This is the fast pwrite path, where we copy
> + *	the data directly from the
>   * user into the GTT, uncached.
>   * @obj: i915 GEM object
>   * @args: pwrite arguments structure
> @@ -713,7 +714,7 @@ i915_gem_shmem_pwrite(struct drm_i915_gem_object *obj,
>  }
>  
>  /**
> - * Writes data to the object referenced by handle.
> + * i915_gem_pwrite_ioctl - Writes data to the object referenced by handle.
>   * @dev: drm device
>   * @data: ioctl data blob
>   * @file: drm file
> @@ -798,7 +799,8 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
>  }
>  
>  /**
> - * Called when user space has done writes to this buffer
> + * i915_gem_sw_finish_ioctl - Called when user space has done writes to
> + *	this buffer
>   * @dev: drm device
>   * @data: ioctl data blob
>   * @file: drm file
> diff --git a/drivers/gpu/drm/i915/i915_pmu.h b/drivers/gpu/drm/i915/i915_pmu.h
> index 449057648f39..c30f43319a78 100644
> --- a/drivers/gpu/drm/i915/i915_pmu.h
> +++ b/drivers/gpu/drm/i915/i915_pmu.h
> @@ -14,7 +14,7 @@
>  
>  struct drm_i915_private;
>  
> -/**
> +/*
>   * Non-engine events that we need to track enabled-disabled transition and
>   * current state.
>   */
> @@ -25,7 +25,7 @@ enum i915_pmu_tracked_events {
>  	__I915_PMU_TRACKED_EVENT_COUNT, /* count marker */
>  };
>  
> -/**
> +/*
>   * Slots used from the sampling timer (non-engine events) with some extras for
>   * convenience.
>   */
> @@ -37,7 +37,7 @@ enum {
>  	__I915_NUM_PMU_SAMPLERS
>  };
>  
> -/**
> +/*
>   * How many different events we track in the global PMU mask.
>   *
>   * It is also used to know to needed number of event reference counters.
> diff --git a/drivers/gpu/drm/i915/i915_request.h b/drivers/gpu/drm/i915/i915_request.h
> index 47041ec68df8..66d6dee98525 100644
> --- a/drivers/gpu/drm/i915/i915_request.h
> +++ b/drivers/gpu/drm/i915/i915_request.h
> @@ -172,7 +172,7 @@ enum {
>  	I915_FENCE_FLAG_COMPOSITE,
>  };
>  
> -/**
> +/*
>   * Request queue structure.
>   *
>   * The request queue allows us to note sequence numbers that have been emitted
> @@ -468,7 +468,7 @@ i915_request_has_initial_breadcrumb(const struct i915_request *rq)
>  	return test_bit(I915_FENCE_FLAG_INITIAL_BREADCRUMB, &rq->fence.flags);
>  }
>  
> -/**
> +/*
>   * Returns true if seq1 is later than seq2.
>   */
>  static inline bool i915_seqno_passed(u32 seq1, u32 seq2)
> diff --git a/drivers/gpu/drm/i915/i915_scatterlist.c b/drivers/gpu/drm/i915/i915_scatterlist.c
> index f63b50b71e10..128fab326bb0 100644
> --- a/drivers/gpu/drm/i915/i915_scatterlist.c
> +++ b/drivers/gpu/drm/i915/i915_scatterlist.c
> @@ -56,7 +56,7 @@ static const struct i915_refct_sgt_ops rsgt_ops = {
>  /**
>   * i915_refct_sgt_init - Initialize a struct i915_refct_sgt with default ops
>   * @rsgt: The struct i915_refct_sgt to initialize.
> - * size: The size of the underlying memory buffer.
> + * @size: The size of the underlying memory buffer.
>   */
>  void i915_refct_sgt_init(struct i915_refct_sgt *rsgt, size_t size)
>  {
> diff --git a/drivers/gpu/drm/i915/i915_scatterlist.h b/drivers/gpu/drm/i915/i915_scatterlist.h
> index b13e4cdea923..0b8bf4be4330 100644
> --- a/drivers/gpu/drm/i915/i915_scatterlist.h
> +++ b/drivers/gpu/drm/i915/i915_scatterlist.h
> @@ -149,7 +149,7 @@ bool i915_sg_trim(struct sg_table *orig_st);
>   */
>  struct i915_refct_sgt_ops {
>  	/**
> -	 * release() - Free the memory of the struct i915_refct_sgt
> +	 * @release: Free the memory of the struct i915_refct_sgt
>  	 * @ref: struct kref that is embedded in the struct i915_refct_sgt
>  	 */
>  	void (*release)(struct kref *ref);
> @@ -159,7 +159,7 @@ struct i915_refct_sgt_ops {
>   * struct i915_refct_sgt - A refcounted scatter-gather table
>   * @kref: struct kref for refcounting
>   * @table: struct sg_table holding the scatter-gather table itself. Note that
> - * @table->sgl = NULL can be used to determine whether a scatter-gather table
> + * @table->sgl == NULL can be used to determine whether a scatter-gather table
>   * is present or not.
>   * @size: The size in bytes of the underlying memory buffer
>   * @ops: The operations structure.
> @@ -173,7 +173,7 @@ struct i915_refct_sgt {
>  
>  /**
>   * i915_refct_sgt_put - Put a refcounted sg-table
> - * @rsgt the struct i915_refct_sgt to put.
> + * @rsgt: the struct i915_refct_sgt to put.
>   */
>  static inline void i915_refct_sgt_put(struct i915_refct_sgt *rsgt)
>  {
> @@ -183,7 +183,7 @@ static inline void i915_refct_sgt_put(struct i915_refct_sgt *rsgt)
>  
>  /**
>   * i915_refct_sgt_get - Get a refcounted sg-table
> - * @rsgt the struct i915_refct_sgt to get.
> + * @rsgt: the struct i915_refct_sgt to get.
>   */
>  static inline struct i915_refct_sgt *
>  i915_refct_sgt_get(struct i915_refct_sgt *rsgt)
> @@ -195,7 +195,7 @@ i915_refct_sgt_get(struct i915_refct_sgt *rsgt)
>  /**
>   * __i915_refct_sgt_init - Initialize a refcounted sg-list with a custom
>   * operations structure
> - * @rsgt The struct i915_refct_sgt to initialize.
> + * @rsgt: The struct i915_refct_sgt to initialize.
>   * @size: Size in bytes of the underlying memory buffer.
>   * @ops: A customized operations structure in case the refcounted sg-list
>   * is embedded into another structure.
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index c10d68cdc3ca..cae684c40d4f 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -256,7 +256,7 @@ wait_remaining_ms_from_jiffies(unsigned long timestamp_jiffies, int to_wait_ms)
>  	}
>  }
>  
> -/**
> +/*
>   * __wait_for - magic wait macro
>   *
>   * Macro to help avoid open coding check/wait/timeout patterns. Note that it's
> diff --git a/drivers/gpu/drm/i915/i915_vma_resource.h b/drivers/gpu/drm/i915/i915_vma_resource.h
> index 5d8427caa2ba..14a0327b2080 100644
> --- a/drivers/gpu/drm/i915/i915_vma_resource.h
> +++ b/drivers/gpu/drm/i915/i915_vma_resource.h
> @@ -84,7 +84,7 @@ struct i915_vma_resource {
>  	intel_wakeref_t wakeref;
>  
>  	/**
> -	 * struct i915_vma_bindinfo - Information needed for async bind
> +	 * @bi: Information needed for async bind
>  	 * only but that can be dropped after the bind has taken place.
>  	 * Consider making this a separate argument to the bind_vma
>  	 * op, coalescing with other arguments like vm, stash, cache_level
> -- 
> 2.36.1
>