Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 18:00:59 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        <intel-gfx@lists.freedesktop.org>,
        Abaci Robot <abaci@linux.alibaba.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH v2 01/39] drm/i915/gvt: Fix kernel-doc for
 intel_gvt_switch_mmio()
Message-ID: <Ys9Am6jkPiVnA+uW@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <72db6b58c1f223e326f84978267ba064eaf67ff0.1657699522.git.mchehab@kernel.org>
 <Ys8/JP3ITMKF1aHp@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Ys8/JP3ITMKF1aHp@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eyr78Tke/wez8tWDJD5psapR7vJm6B94/VePxODJaX6qY+hZoxGTiYFeNkZD?=
 =?us-ascii?Q?ubBzQ96I7jBVshSSLUpb2+QxKNsFfVJSN/Xb0ozcfAYCM/2plS7mo7tVLwTJ?=
 =?us-ascii?Q?9B+LWM2Ys7coHVROOncyHTs9mFjwCEArmULX5wdUr4akerhf7nXBoY5m+Tbr?=
 =?us-ascii?Q?4HPYQkllLspHKMvDzMFb91A158o41LHw3kGweBpzy8GSquO3OfMbupqiwgKL?=
 =?us-ascii?Q?5uBW8rz7DbvLX50K/ONh0YRueQ9AhwUma3opdgn7/k6F7IqW0jTcS4ApGRez?=
 =?us-ascii?Q?b9bE3VmmY0ds1Kqd/8b35fhv4ER3S89YV8SzKVGffsm5Q2wN3sDiXj13r819?=
 =?us-ascii?Q?YmfZbW1yoR+9dPOJjUzO20B+mPxo4RLlxafhXsJOu2FoVGqeEGjDaTFa6Sqy?=
 =?us-ascii?Q?MMn13lq0sJL8u5BKmWaPLAgUA/crz+PJG8EGj+vf+Pgu10fZrLzjqTXukiFn?=
 =?us-ascii?Q?dxpiMP/vLERo8fv9QpxcN5SfJb8s0T3SKCKO0c0joMjlwjMkzu6riOxwKYoy?=
 =?us-ascii?Q?DNhpy82pglN0oQtrjMfo9VwepgiaLdAK0bVRvR3/r1joiGkFcV8LMNn1ZOYB?=
 =?us-ascii?Q?PXzzXaeOdhOwCDiwfTg5m2pl5OAYyjp5EUc9L2dzfKzDmXkFG3Daejk/rFbL?=
 =?us-ascii?Q?hGKU03EAJPVreCat3i8IELQ+ntB8OwfX1udqXXI5+DyvJ7Uc61Rn9kA4jR8U?=
 =?us-ascii?Q?Zc4IsLpoxtYs6w6r/OERHsHeN28EOvNvqKDZlBDjJHhIiTv3R5BrY57diGZi?=
 =?us-ascii?Q?ff70DNuItDGY+L0F0Tz1DFYU/N1imo2yHGcm+8eGiGAhZKlt2V3DF0fuu0Ls?=
 =?us-ascii?Q?oYgtbQ+qqciPb9vGslhhuEmVGU3t+KgnrWlfKXIMWm4RgVY47xTrRXyhpuyX?=
 =?us-ascii?Q?yrFW5TC1xIqzYyAwf5DwBpHzyjab/Y3hxKEAKusxgBhL1V9xLIZUE6HM73nQ?=
 =?us-ascii?Q?hTGJPVP0g6f87iMp/YkDWGOBxRH7883ChPxUBvMgyPlIsMN2Rrc6OsbzJowk?=
 =?us-ascii?Q?DxII+gW3L28+XLPX/cP7fpRCFx0TsMv9ZIfYYWjShzaeedFBNuDU7PxXlMUt?=
 =?us-ascii?Q?tnUvXO263/UECIiIdNjSfG1eo/wZbjEwJ57G4cbmzxbl/1ndZ87OToRZkWoV?=
 =?us-ascii?Q?wW/vL/ABEZ7SD1EFG7BHFhr9ql/13uUnlxhaU0UiEb6f4N6bL3nFNxOMdzF4?=
 =?us-ascii?Q?hnk9fXV5cRo233STaNQnWd02aC8AvQ+zE7BSzZsagecq7rD/cIBnkkfeeeMG?=
 =?us-ascii?Q?b8waya46qMGraxZAWIVoaTejwlkaXWHV+fy+veokodiUvdNYeGhH88CGs70X?=
 =?us-ascii?Q?qUgr8MFJwkI/bk/AM0tPCrmCbcLVNTjpEwGgD/K4zW1uIgPstKtfTBJWZOG5?=
 =?us-ascii?Q?1o6k6ijftgU7mI/++3qG59dmkdHhiAX2WBkX+eZKxrenjcXkkOeHspDyD2CO?=
 =?us-ascii?Q?JqF4a73WrApD09ATEYQlwvrwBhyvoOjJ+CR3T+vdgumazlOqDWyVl2TZHO0y?=
 =?us-ascii?Q?tEY0r9KSN2vrMr34d/765wXIj6cP2ZBDOiC+jOCRjGWXY81G/g4Q8rhvCk3L?=
 =?us-ascii?Q?crThaRZBhNUWfKrtj+B9S7IBiREq7Z45lj7qSuKT6IvF6mCpADyI1vka8d3U?=
 =?us-ascii?Q?1A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 76e0583b-0d23-4f23-a64d-08da651b2ed4
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 22:01:05.3993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DgMPEpZi3qdI37MmglLOH+Lrisvd1cY3EGZvONf+blzMo2SHeN6zQr06OSnjYGuiW9pVuptuAdYW1S5XpKUZKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 05:54:44PM -0400, Rodrigo Vivi wrote:
> On Wed, Jul 13, 2022 at 09:11:49AM +0100, Mauro Carvalho Chehab wrote:
> > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > 
> > Fix the following W=1 kernel warnings:
> > 
> > drivers/gpu/drm/i915/gvt/mmio_context.c:560: warning: expecting
> > prototype for intel_gvt_switch_render_mmio(). Prototype was for
> > intel_gvt_switch_mmio() instead.
> > 
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

I actually changed my mind after seeing that in most cases you use "()"
for the functions and you didn't use for this case...

which one should we pick for consistency?

> 
> > ---
> > 
> > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> > See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> > 
> >  drivers/gpu/drm/i915/gvt/mmio_context.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/gvt/mmio_context.c b/drivers/gpu/drm/i915/gvt/mmio_context.c
> > index c85bafe7539e..1c6e941c9666 100644
> > --- a/drivers/gpu/drm/i915/gvt/mmio_context.c
> > +++ b/drivers/gpu/drm/i915/gvt/mmio_context.c
> > @@ -546,7 +546,7 @@ static void switch_mmio(struct intel_vgpu *pre,
> >  }
> >  
> >  /**
> > - * intel_gvt_switch_render_mmio - switch mmio context of specific engine
> > + * intel_gvt_switch_mmio - switch mmio context of specific engine
> >   * @pre: the last vGPU that own the engine
> >   * @next: the vGPU to switch to
> >   * @engine: the engine
> > -- 
> > 2.36.1
> >