Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 18:09:12 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     David Airlie <airlied@linux.ie>, <intel-gfx@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v2 09/39] drm/i915: intel_wakeref.h: fix some
 kernel-doc markups
Message-ID: <Ys9CiKZg6FZJtoGl@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <781e207ffe403a21f67a3f8c3bd39725d229cf0e.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <781e207ffe403a21f67a3f8c3bd39725d229cf0e.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L/W5nHK1RNqZRQuSrCKFMPECuIbTFXhqDJjNtB0SAaFDrrrAoA2zPdEO5pP8?=
 =?us-ascii?Q?NMYO8z+tGCLT2je9MSrvE3rhlML1WZxT9+ytoTg485paJKfRNQNbwinw4nV6?=
 =?us-ascii?Q?835sM22WXoKlfZ8RTB+gmd+AL9HJyEWl95BiMQVcMZJsxqPMkwQUHqcMJ+UE?=
 =?us-ascii?Q?4WVvLzEoEQyjyNYjyWfY67B/IQNT15iecn9v1MkCTuO1H3nQmwlR0Z3fgJoJ?=
 =?us-ascii?Q?otIY3NyKu3bvtKFuPx2x/dofVG7c6KCy8VyIjcXAX2ITqmId809j/KEZkwnA?=
 =?us-ascii?Q?daVa2f7pQPgSk3zNJ077z8VzEUa7b8QXEjkLc2QBx1yX2BrJr9SorI4q/kjU?=
 =?us-ascii?Q?/nZO6vyKTmUjN5A/7e+Xpb/1gWDNeZFgwGXxqSC+jehaLp+5OL9Vf9SRFYXF?=
 =?us-ascii?Q?gS2mbKbPdPiS8TeuBcZehdlVbrI/3vhxb/dTDt1Usm6LsSnpPbZGdlpxaTyt?=
 =?us-ascii?Q?GUYQLpz+YLXr7P13mxHZAhm/1bfu8BPb2UkuNQwHk0UgfdxygUAnq1P/ebfa?=
 =?us-ascii?Q?GjEIRfIl5bjs+yILwgN0UYRXSf+PDAUs+Ylwjw3nAiHRruFy5s61jnNnvmXJ?=
 =?us-ascii?Q?YFO8cjAjkvB0jS+KSQUBiDUY8V5Kp21g1a0Bari6UYmqZ0VHHXJw0ppYO9cP?=
 =?us-ascii?Q?i+IczU4ORXF50naUIojCz81PZNsCB/R9JnXnzhDBWBebXQODObD9p8YFRtXM?=
 =?us-ascii?Q?zueVL2neRBE8gnh/7HODuHAATJwb7Neq5lzNNhnIf++LnxRkAg16WloPDbnX?=
 =?us-ascii?Q?E90w4XGpZEyMDy36jhlVZ0hpHM5+O11X9mUX+jqrc6Gu1XLI3OkIBbHISUHv?=
 =?us-ascii?Q?egqPK7h1z3+e5mV47sNi7vs7YGvPX8lIztzVPp4+Hc/PB4gEyjso8VZRKPM6?=
 =?us-ascii?Q?06EQjedM0ucSGnfP7Hfal+/beoOGMa8NiI1Pt3KwU3fp0xKxNFqY/LJ/cP6B?=
 =?us-ascii?Q?BtOUEo8AWW+G/W7P8qyu/FjBaV3RDpLxvnXQzIG6XKe1T7fE72bcZVriVohG?=
 =?us-ascii?Q?5oABRv4pojd18yn09403KCixrpmREnDSiA3WH4mLejdEoXRIlMGGRXdJO3Im?=
 =?us-ascii?Q?26mDWUrdCPXB2fQZdjEiwonliV4xxrbpViTPOQENcspYIs1nkmmC92DA0v70?=
 =?us-ascii?Q?ee6Z4V2DNErWY25SuA98kO8g40fPYkxkQiInIBpr+aKtP/P+r+v7GYjWlR7i?=
 =?us-ascii?Q?kZ38bM43VTL7CCat8WcpdmeYAKKGE2zB/Mx7c5AZ27CsftxvNLN2tnvylwgA?=
 =?us-ascii?Q?3auSi3y5YIlwHOhxXe5QAsx874ja0LRAJO2+tqIJXJItLy+iPYd6n+oEHkBp?=
 =?us-ascii?Q?0PkAOUg5kH+ZUfNjtqhoFdDBUKOMuIjQd5XFf6i0sTwtKxgmRCWwvl1O+L/z?=
 =?us-ascii?Q?b+FbCHDODPOK17rIQP0F9KR9vEQqyP1l8wAdHRJBaRxui0JgMXgBaiO2QoWB?=
 =?us-ascii?Q?IqckK6rZ2BtSgJEda0OufAs/s5A+eHQFWJEEDGaYrdZY+ap3CRsJietFip4d?=
 =?us-ascii?Q?LVABlV5dMJO44t2e3TPVlokrAq4Gu926e6rWRtmxUoB7EBi6ZfUyV1vYsfUF?=
 =?us-ascii?Q?Czzp/0pJtLU+gAD9lfJ9bGIRZDsUbjcHUJhJmoB/num9R/R8kDfIS9N6hS10?=
 =?us-ascii?Q?hQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8474b5da-6afd-49e9-9940-08da651c537f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 22:09:16.9143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: siUTGSBmAkXl/cauZfkXfhN4HFf0Y79kUEv/ZkPqOHBvI+9eOSwmlEASAQWJrpZRwkYjDXKogXcZPDQJBtgKwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6211
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:11:57AM +0100, Mauro Carvalho Chehab wrote:
> Two documented functions don't match the kernel-doc comments,
> as reported by kernel-doc:
> 
> 	drivers/gpu/drm/i915/intel_wakeref.h:117: warning: expecting prototype for intel_wakeref_get_if_in_use(). Prototype was for intel_wakeref_get_if_active() instead
> 	drivers/gpu/drm/i915/intel_wakeref.h:149: warning: expecting prototype for intel_wakeref_put_flags(). Prototype was for __intel_wakeref_put() instead
> 
> Fix them.
> 
> Additionally, improve title for intel_wakeref_get_if_active().
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/intel_wakeref.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h
> index 4f4c2e15e736..63e539c9b1f3 100644
> --- a/drivers/gpu/drm/i915/intel_wakeref.h
> +++ b/drivers/gpu/drm/i915/intel_wakeref.h
> @@ -104,7 +104,7 @@ __intel_wakeref_get(struct intel_wakeref *wf)
>  }
>  
>  /**
> - * intel_wakeref_get_if_in_use: Acquire the wakeref
> + * intel_wakeref_get_if_active: Acquire the wakeref if active
>   * @wf: the wakeref
>   *
>   * Acquire a hold on the wakeref, but only if the wakeref is already
> @@ -130,7 +130,7 @@ intel_wakeref_might_get(struct intel_wakeref *wf)
>  }
>  
>  /**
> - * intel_wakeref_put_flags: Release the wakeref
> + * __intel_wakeref_put: Release the wakeref
>   * @wf: the wakeref
>   * @flags: control flags
>   *
> -- 
> 2.36.1
>