Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 23:52:41 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Oleksandr Mazur <oleksandr.mazur@plvision.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, yevhen.orlov@plvision.eu,
        taras.chornyi@plvision.eu
Subject: Re: [PATCH V2 net-next] net: marvell: prestera: add phylink support
Message-ID: <Ys8+qT6ED4dty+3i@lunn.ch>
References: <20220713172013.29531-1-oleksandr.mazur@plvision.eu>
 <Ys8lgQGBsvWAtXDZ@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Ys8lgQGBsvWAtXDZ@shell.armlinux.org.uk>
Precedence: bulk

On Wed, Jul 13, 2022 at 09:05:21PM +0100, Russell King (Oracle) wrote:
> On Wed, Jul 13, 2022 at 08:20:13PM +0300, Oleksandr Mazur wrote:
> > For SFP port prestera driver will use kernel
> > phylink infrastucture to configure port mode based on
> > the module that has beed inserted
> > 
> > Co-developed-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
> > Signed-off-by: Yevhen Orlov <yevhen.orlov@plvision.eu>
> > Co-developed-by: Taras Chornyi <taras.chornyi@plvision.eu>
> > Signed-off-by: Taras Chornyi <taras.chornyi@plvision.eu>
> > Signed-off-by: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
> > 
> > PATCH V2:
> >   - fix mistreat of bitfield values as if they were bools.
> >   - remove phylink_config ifdefs.
> >   - remove obsolete phylink pcs / mac callbacks;
> >   - rework mac (/pcs) config to not look for speed / duplex
> >     parameters while link is not yet set up.
> >   - remove unused functions.
> >   - add phylink select cfg to prestera Kconfig.
> 
> I would appreciate answers to my questions, rather than just another
> patch submission. So I'll repeat my question in the hope of an answer:
> 
> First question which applies to everything in this patch is - why make
> phylink conditional for this driver?

Hi Oleksandr

I agree with Russell here. This driver should depend on PHYLINK and
remove all the #ifdefs. We try to avoid this sort of code, it hides
bugs and does not get compile tested very well etc.

You need to give us a good reason if you want to keep the code like this.

    Andrew