Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1196828imw; Wed, 13 Jul 2022 15:38:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tULuktCW4gqBuereRVEzIJ9aADwudtBEBjfnSY03RAIXlwXBLLx62MSilQCty7Wa7cj3+d X-Received: by 2002:a17:903:1104:b0:16c:2f71:7803 with SMTP id n4-20020a170903110400b0016c2f717803mr5367288plh.101.1657751898466; Wed, 13 Jul 2022 15:38:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657751898; cv=none; d=google.com; s=arc-20160816; b=OLKXaPmSUPg/wA51HohKI4dykr4JMIdOsQ/8K1gRAuPENowajOJCYbhZ+JWDLZDXSm 3V9xlfxQd2CQJIgU/9IuJzS71j0LNQ1YF0gCYmUquvnKvdTgNpY2JphG7wV8KCO0DOD9 +dwOEJgV69TXQK+3gb3NaaRfOXJuJEan/u4XTa+XJGvoiiFtHLI/yPygt4gqa28SKic/ epBUxOCYO5XaMvc1sxyfQNEXM9vmMZxurThhyrNJh2XM06c8Gb0+/USAbryTu5LazX2h ImzH4utu8bPuVVO//cj3h22SerJ1a2Y+PNuwYv893q7J1NoGAB6TffQV7ZC31Zk3KA2f ljwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MNNSohJKOzjeKAMJfCPtmJjjR5KPf4n5+S8FRnHc6d4=; b=Hx7897AOdP3mqEMIS6eV5myF7bu1cw9EyHkCX2WDnTyXLJmRlE7w9Vxvp/qCGbmKdF nG1pBo+vwBpZtHM/psa2wnOPZpM+Zk0f2NTkx2CByJhAG4pbWn00ZMR7s7prPs0o57rw 1BjZeiKrISljEIyuz9WaJZXLylyL6pW/QZipDY2oDgChzF4eTcgx2i8F/U5kRsRdWfL1 0qhmP0SsMyEYK5D77SN/PpMhO6I90u2oMuBJXyqRCkUJj0Ci1UWt9/ed2GZbTdLjQSnI FvhzYh4tMQRy1YbLZSBPlIgyUToV8vB1UUj+bRtuCZBxk+bvZ5n9GdqPw9LyJRM1ZbGO S0dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gnT3Lemt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n5-20020a170902f60500b0016c60e0b6besi6778131plg.80.2022.07.13.15.38.01; Wed, 13 Jul 2022 15:38:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gnT3Lemt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236756AbiGMW0p (ORCPT + 99 others); Wed, 13 Jul 2022 18:26:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbiGMW0n (ORCPT ); Wed, 13 Jul 2022 18:26:43 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 209294D16E; Wed, 13 Jul 2022 15:26:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 83F3BCE240C; Wed, 13 Jul 2022 22:26:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7B82C3411E; Wed, 13 Jul 2022 22:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657751198; bh=MNNSohJKOzjeKAMJfCPtmJjjR5KPf4n5+S8FRnHc6d4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gnT3Lemt2fw4JP9Fgiq4qHrHJvU/J/eh05TSTgMv8uPaqFn0qyLYED2iS8GryLnRs lkfGGU50eKmr/GTqSbGK5C49rNU8Q41KvLxSqTQOt80BYUs8TxJoIva3ua7/fQ6Ck7 o8crxVNw7PBjjTgPxodV1CerrfKtMzb6avmlJ0X2gnp5GGy989GhQj9kQCspf255CA XWzoP2J4Zqn1uUG1KggmNnoiFJewyzFk/s+mJZQxIxuXB12Twr0BgNg/xtZrdOnbPp hCAWprylPN7cwQYM537j1fC1uAUxxvrZn+9pZHbAW5iU/y3gerdm+PM9yNI8L4Y0In tkBRmGgWef31Q== Date: Wed, 13 Jul 2022 15:26:38 -0700 From: Saeed Mahameed To: Rustam Subkhankulov Cc: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maor Gottlieb , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov Subject: Re: [PATCH] net/mlx5e: Removed useless code in function Message-ID: <20220713222638.nej53m5owfkr6dzz@sx1> References: <20220711093303.14511-1-subkhankulov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220711093303.14511-1-subkhankulov@ispras.ru> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 Jul 12:33, Rustam Subkhankulov wrote: >Comparison of eth_ft->ft with NULL is useless, because >get_flow_table() returns either pointer 'eth_ft' >such that eth_ft->ft != NULL, or an erroneous value that is >handled on return, causing mlx5e_ethtool_flow_replace() >to terminate before checking whether eth_ft->ft equals NULL. > >Found by Linux Verification Center (linuxtesting.org) with SVACE. > >Signed-off-by: Rustam Subkhankulov >Fixes: 6dc6071cfcde ("net/mlx5e: Add ethtool flow steering support") Applied to net-next-mlx5 and removed the fixes tag. Since there is no bug here. Thanks, Saeed.