Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 18:08:24 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <intel-gvt-dev@lists.freedesktop.org>,
        <intel-gfx@lists.freedesktop.org>, Zhi Wang <zhi.a.wang@intel.com>
Subject: Re: [PATCH v2 07/39] drm/i915: gvt: fix kernel-doc trivial warnings
Message-ID: <Ys9CWElnKJknLVDb@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <375c0c0ca2ef414f25e14f274457f77373a9268d.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <375c0c0ca2ef414f25e14f274457f77373a9268d.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5oCKSlKu0SJWQmKKVP/gH423yZZopOV6NRUhlbcqyIhzjmGgRXLcFejFSa51?=
 =?us-ascii?Q?982+usLWcqxQx0E2a+0OMQ+aO61R4TLLROycWIMdtk13D+UsqoOX7lP1UHsY?=
 =?us-ascii?Q?gPbt01GjaXwXWw033+UorRhsNKTCrlFXlLCCa6Uz/F9qPdFCE4JZjDRUMmt1?=
 =?us-ascii?Q?NEbGX98/X+VKtw9dGef8c/OzDYNIToohVOXS9fBbkNEq2gVLrODamy6EiOxt?=
 =?us-ascii?Q?6feU90i7YR0hV8wWrfn74/Go1FvcBD8GCGDkFp0iRF7THCMCxC/loTW/Z3UI?=
 =?us-ascii?Q?YEDXIWJq8yaw2yj1XC5sObgfgdEUHxGTcY8PX0F92YLtUN5q/q55jAgDDshA?=
 =?us-ascii?Q?3zttx0J/gQeXRDZ0CtCDSgQuxvTlOqD0d8JonXtrytBennaomLMC0KDv1KLP?=
 =?us-ascii?Q?vKxLdCbkHJ2mGq0cYc910bKFlBAOHnOWwBtEfTzxqU0hqgqEUa18A7cWqy6q?=
 =?us-ascii?Q?ZHBa04kDgDlJtTjOmQxQHP8NP37zoOCd1kAWzftfFbA7yMTjbbAnhKTtGQ+s?=
 =?us-ascii?Q?ILZHzK5uMGjTItsEwGdrY79KlJ6DlGnddW76FeRlTGUFG4k6rzXjoxGx+YuW?=
 =?us-ascii?Q?CYHCVO44/v22tIvpsG1s4Ym9oR9KM/L7IOywH29U6fL1wfNVkNZeW6IcN7BY?=
 =?us-ascii?Q?+q1+xVD0N17VyhzuO2YXpIFhaeHuRGuWlnE+I54F0U+9XJpwabrA+xw9nxYm?=
 =?us-ascii?Q?kC10YiP5k4Qn0yU/mte5VOKSBVrgoPXT+Hs6zFylr8LU+T9+3EhPTroTN7m8?=
 =?us-ascii?Q?MAIf+/4adpj/Dp5kUtvtkDVgXdlwRDpS4IzIeghWCM00dIiQTGERAVQhVq3h?=
 =?us-ascii?Q?5tK/Fxc3+n5TGdZOkzasfLJIa4iaE2Naihw5XFvd+ERlEOu87XG8keHpDpTf?=
 =?us-ascii?Q?wS8/HGgGKEdRKWdhc0Hnj5l2O1fbJym6KPF++6YEqTJ9gtlvw3I8n7muXyl8?=
 =?us-ascii?Q?em4To77ZdH/pBfKOl7lfwN5KLpcNgkwJFzrly4tqxRf5I1Tru74LlbifUuiY?=
 =?us-ascii?Q?YBIYajoCZ1sKCdMzGdvQGOahUJNoBnNdSPUCk4gAjP8SqSPM/JYgjOgafvNr?=
 =?us-ascii?Q?E+9IinGRirDrlW4DrBGwEwYQTmPkWXNGgRXApu9QT/nIvPE43V/7HuWA2aOE?=
 =?us-ascii?Q?ugDSntGco+gFs4Pr1H+kZcgzvxTwsKj7AIgRfg8yIhAtSJ7733jhjEa0PLhX?=
 =?us-ascii?Q?RBnjIcQetiOTMCTKxRnroYD+HY/IlcIUY9EyiNYpOpvIR1TzSMgVqn6NejBr?=
 =?us-ascii?Q?D1lHY3u1pVhy3L+6c3KHb7PpN5QwHBBv7Lvo1bcddBuPnzG2eQqqSh0ttV8q?=
 =?us-ascii?Q?TcCNVC9sbvbWe8sOjFaKovtU8XY/Y6jZ/IU6BE0c0V4oFTb8Oj9g3PXlDOpG?=
 =?us-ascii?Q?yhJ/2r6yTrQ3OTuTFWXscNFWkko/qTok8mx0E+mXtUNlX3quRqCxkMncSxzu?=
 =?us-ascii?Q?GDD5DvUAu0tUdgi7lKb9pAImcPczl4eEsPMfSCg7soE8q6JwjUyPAg3fkTkv?=
 =?us-ascii?Q?xbL/xCbdTXaGGAdrUrkbnlJHD7VIuXhIRjCKRGk+jHSioIW5fTDr0Ecr6d6Y?=
 =?us-ascii?Q?gESN1Wf7YINDU78ulKsJw8P6CDsxv3lLAuLW27XNufya7gjjhmXuz/OkUK6/?=
 =?us-ascii?Q?Pg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e712852b-cd9b-411d-fdc9-08da651c36fe
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 22:08:28.5485
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zGSA6LR+Wf1k4A0p4xKjtFKVcDS1ksXp5umCfpxMCkEUIv06xOW+MJJYiR9Lj2zVJJSsFooaA3SRKeVZByAD9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6211
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:11:55AM +0100, Mauro Carvalho Chehab wrote:
> Some functions seem to have been renamed without updating the kernel-doc
> markup causing warnings. Also, struct intel_vgpu_dmabuf_obj is not
> properly documented, but has a kerneld-doc markup.
> 
> Fix those warnings:
> 	drivers/gpu/drm/i915/gvt/aperture_gm.c:308: warning: expecting prototype for inte_gvt_free_vgpu_resource(). Prototype was for intel_vgpu_free_resource() instead
> 	drivers/gpu/drm/i915/gvt/aperture_gm.c:344: warning: expecting prototype for intel_alloc_vgpu_resource(). Prototype was for intel_vgpu_alloc_resource() instead
> 	drivers/gpu/drm/i915/gvt/cfg_space.c:257: warning: expecting prototype for intel_vgpu_emulate_cfg_read(). Prototype was for intel_vgpu_emulate_cfg_write() instead
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'vgpu' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'info' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'dmabuf_id' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'kref' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'initref' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/dmabuf.h:61: warning: Function parameter or member 'list' not described in 'intel_vgpu_dmabuf_obj'
> 	drivers/gpu/drm/i915/gvt/handlers.c:3066: warning: expecting prototype for intel_t_default_mmio_write(). Prototype was for intel_vgpu_default_mmio_write() instead
> 	drivers/gpu/drm/i915/gvt/mmio_context.c:560: warning: expecting prototype for intel_gvt_switch_render_mmio(). Prototype was for intel_gvt_switch_mmio() instead
> 	drivers/gpu/drm/i915/gvt/page_track.c:131: warning: expecting prototype for intel_vgpu_enable_page_track(). Prototype was for intel_vgpu_disable_page_track() instead
> 	drivers/gpu/drm/i915/gvt/vgpu.c:215: warning: expecting prototype for intel_gvt_active_vgpu(). Prototype was for intel_gvt_activate_vgpu() instead
> 	drivers/gpu/drm/i915/gvt/vgpu.c:230: warning: expecting prototype for intel_gvt_deactive_vgpu(). Prototype was for intel_gvt_deactivate_vgpu() instead
> 	drivers/gpu/drm/i915/gvt/vgpu.c:358: warning: expecting prototype for intel_gvt_destroy_vgpu(). Prototype was for intel_gvt_destroy_idle_vgpu() instead
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/gvt/cfg_space.c  | 2 +-
>  drivers/gpu/drm/i915/gvt/dmabuf.h     | 2 +-
>  drivers/gpu/drm/i915/gvt/page_track.c | 2 +-
>  drivers/gpu/drm/i915/gvt/vgpu.c       | 6 +++---
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/cfg_space.c b/drivers/gpu/drm/i915/gvt/cfg_space.c
> index dad3a6054335..a0fc6d356588 100644
> --- a/drivers/gpu/drm/i915/gvt/cfg_space.c
> +++ b/drivers/gpu/drm/i915/gvt/cfg_space.c
> @@ -243,7 +243,7 @@ static void emulate_pci_bar_write(struct intel_vgpu *vgpu, unsigned int offset,
>  }
>  
>  /**
> - * intel_vgpu_emulate_cfg_read - emulate vGPU configuration space write
> + * intel_vgpu_emulate_cfg_write - emulate vGPU configuration space write
>   * @vgpu: target vgpu
>   * @offset: offset
>   * @p_data: write data ptr
> diff --git a/drivers/gpu/drm/i915/gvt/dmabuf.h b/drivers/gpu/drm/i915/gvt/dmabuf.h
> index 5f8f03fb1d1b..3dcdb6570eda 100644
> --- a/drivers/gpu/drm/i915/gvt/dmabuf.h
> +++ b/drivers/gpu/drm/i915/gvt/dmabuf.h
> @@ -48,7 +48,7 @@ struct intel_vgpu_fb_info {
>  	struct intel_vgpu_dmabuf_obj *obj;
>  };
>  
> -/**
> +/*
>   * struct intel_vgpu_dmabuf_obj- Intel vGPU device buffer object
>   */
>  struct intel_vgpu_dmabuf_obj {
> diff --git a/drivers/gpu/drm/i915/gvt/page_track.c b/drivers/gpu/drm/i915/gvt/page_track.c
> index 3375b51c75f1..df34e73cba41 100644
> --- a/drivers/gpu/drm/i915/gvt/page_track.c
> +++ b/drivers/gpu/drm/i915/gvt/page_track.c
> @@ -120,7 +120,7 @@ int intel_vgpu_enable_page_track(struct intel_vgpu *vgpu, unsigned long gfn)
>  }
>  
>  /**
> - * intel_vgpu_enable_page_track - cancel write-protection on guest page
> + * intel_vgpu_disable_page_track - cancel write-protection on guest page
>   * @vgpu: a vGPU
>   * @gfn: the gfn of guest page
>   *
> diff --git a/drivers/gpu/drm/i915/gvt/vgpu.c b/drivers/gpu/drm/i915/gvt/vgpu.c
> index 46da19b3225d..8e71cda19995 100644
> --- a/drivers/gpu/drm/i915/gvt/vgpu.c
> +++ b/drivers/gpu/drm/i915/gvt/vgpu.c
> @@ -205,7 +205,7 @@ static void intel_gvt_update_vgpu_types(struct intel_gvt *gvt)
>  }
>  
>  /**
> - * intel_gvt_active_vgpu - activate a virtual GPU
> + * intel_gvt_activate_vgpu - activate a virtual GPU
>   * @vgpu: virtual GPU
>   *
>   * This function is called when user wants to activate a virtual GPU.
> @@ -219,7 +219,7 @@ void intel_gvt_activate_vgpu(struct intel_vgpu *vgpu)
>  }
>  
>  /**
> - * intel_gvt_deactive_vgpu - deactivate a virtual GPU
> + * intel_gvt_deactivate_vgpu - deactivate a virtual GPU
>   * @vgpu: virtual GPU
>   *
>   * This function is called when user wants to deactivate a virtual GPU.
> @@ -348,7 +348,7 @@ struct intel_vgpu *intel_gvt_create_idle_vgpu(struct intel_gvt *gvt)
>  }
>  
>  /**
> - * intel_gvt_destroy_vgpu - destroy an idle virtual GPU
> + * intel_gvt_destroy_idle_vgpu - destroy an idle virtual GPU
>   * @vgpu: virtual GPU
>   *
>   * This function is called when user wants to destroy an idle virtual GPU.
> -- 
> 2.36.1
>