Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 18:05:06 -0400
From:   Rodrigo Vivi <rodrigo.vivi@intel.com>
To:     Mauro Carvalho Chehab <mchehab@kernel.org>
CC:     Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        <dri-devel@lists.freedesktop.org>, David Airlie <airlied@linux.ie>,
        "Anshuman Gupta" <anshuman.gupta@intel.com>,
        Lucas De Marchi <lucas.demarchi@intel.com>,
        <linux-kernel@vger.kernel.org>,
        =?iso-8859-1?Q?Jos=E9?= Roberto de Souza 
        <jose.souza@intel.com>,
        Patnana Venkata Sai <venkata.sai.patnana@intel.com>,
        Sean Paul <seanpaul@chromium.org>,
        Fernando Ramos <greenfoo@u92.eu>,
        Jouni =?iso-8859-1?Q?H=F6gander?= <jouni.hogander@intel.com>,
        <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2 05/39] drm/i915: display: fix kernel-doc markup
 warnings
Message-ID: <Ys9BksNo/iylds2g@intel.com>
References: <cover.1657699522.git.mchehab@kernel.org>
 <e860a7d8e5f9c41c462ef354b9ca6f36ae142e1b.1657699522.git.mchehab@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <e860a7d8e5f9c41c462ef354b9ca6f36ae142e1b.1657699522.git.mchehab@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OTQ2hP80aWoR9AZ2uFXv7Nny/QoBfyP9N3Vlg8DL1k3W0Kz47NoOEYSgkpJR?=
 =?us-ascii?Q?UtSAKOegNRuic5gj6HMDZ/eBW0zdGxahd2r6nVB+yFJI3FjMZPLTFF8Db3z8?=
 =?us-ascii?Q?/i3DD8zo7se5FcHhF9xAhDbS6DoU2GSVEpOwAt/PiaeffcpbOY3Cn2a6uSgH?=
 =?us-ascii?Q?ntTgjLBfcG7h1ieP0gKDy2ewJ2t8fO0iibDX5UcxwFtW1nG7OcF4j9nA2kcV?=
 =?us-ascii?Q?hLVzZxbFEpFoE3jqrgIiSdKqSCHjBz4kq1UGs3x2IPURNnzYF+lj2gtyAaiP?=
 =?us-ascii?Q?AJfM5RxbnlB5yil9HNiXi1Eo1pFbix60zkrFUyufv82fT0yIYgZ6X8lXb7EG?=
 =?us-ascii?Q?HAGSFTcsD1eanfyVzdMx2Xk+YlHum3lm/eDlpPe2Qg+IuEaSl4TInbrxPXLV?=
 =?us-ascii?Q?1+j5kU4XVsKT05tOggn0XOPxcN5WM2Hfs6K0sUh1qAuhNPGt6PiMzglWXytv?=
 =?us-ascii?Q?I4AZzaoR3jmk5zAp3b4UcFu31azdfsO29rUMrL7pi+J6EJH63Yfx5ZYcuToA?=
 =?us-ascii?Q?CXH2CoLyuPSFO1Vw0b2pNU2XesTMBXXMXTfJ1uu8djJ98P4Fy2Ud0FSEqy/n?=
 =?us-ascii?Q?HbMt7h3LOwDcTgNQliAguRINjEd5e2WfgOzoyRSujLFkE8InGYX8KFIbglFQ?=
 =?us-ascii?Q?C8l8LXK8RljYsa/pXFMhl8J4rsr2Rp7L0ZzxuSKhpnDakEkMlDOYDkmjY4uw?=
 =?us-ascii?Q?tAjvUEnkG9TSCFJnEOI60yvZvCv4JCcW655zf+ON5NXm/Tq/G7w1xcPqq9M+?=
 =?us-ascii?Q?d784GYkUNQ+i5gXNUXCxJi54faJYepqSGK1M6R4QkcL+4Zo1wqGSw32ckBS1?=
 =?us-ascii?Q?FrhtMkpU8qosD8QYhN8OZTc3oqtxc86L6MxD5qbUthjWsmZuJ8DKWL7TK3fd?=
 =?us-ascii?Q?MkXBQ/aqet6XXWLNInWsPz1R0muR/2j95/6b8yssGOyp9KVd0mxcPdUXYog7?=
 =?us-ascii?Q?rDl4K5XugQL0m54nKUTVKLlXi93rM58BBUQNZqaBaqMwpe93V6kcI8o3hN+Y?=
 =?us-ascii?Q?GMhczj0kXBt18DtwWA0I881s/D//PXVNRRe0d3CWgpI6EvK3c3bpCLlbWqD0?=
 =?us-ascii?Q?otbvOuBA2ofE5zPt+cSv6ZNZd+LgtkeedrvI+cCV8OAraGfbidtbYuNdd5kl?=
 =?us-ascii?Q?Khg1YJZU9YGRiP5ldmMxK0mBVqIABewKdTq45G0VPjRlUfEddsdjSCrbdLb6?=
 =?us-ascii?Q?G38Bnn4Ey2ayZcovPDZRxvQRGiSu32OTzqJ+uFQbgkNHzkK+WjA9WbciSpjJ?=
 =?us-ascii?Q?K5ixORFFYshi39Se0H2KGTm4O2q9/bU+FKC9k6paY8t3Zxn316ehFZey2kXl?=
 =?us-ascii?Q?jtI5+lkO1ujTetTa2x1ST8iM1oB7RV16ZKWt/GOstjbDpIv9seBMeIhn1ebh?=
 =?us-ascii?Q?+wzjOXHiqtGtK0uQY2Ztks4uLeE0fJnXIzR1jlqwuKDqUQVRcH2qzEwhfn2N?=
 =?us-ascii?Q?uLxN7wpdRKqNCKoZKuIq6yj7gR4Mqbb8mD7qrx2eHn9P5hbTamDZZVMv8MXk?=
 =?us-ascii?Q?2SQSyWvAom1qc1XwwC3hCHlWN+hicxQS7ZGOsM2bx1G4W6xIb/IPT2G3eY1f?=
 =?us-ascii?Q?tM7GuKboGtSfTQsMjVBMC6/mxU8Jvh8UFmRX9zEYhK8neOrEj0I00GVFNEpl?=
 =?us-ascii?Q?/Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e8edfb5-e83c-4ecb-8c34-08da651bc1e8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 22:05:12.6235
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wd4oVwS+8k0e2376bdMtwsLeKtEhklnr7FuyG4OZqUctgedeyPGNoT8LL7UN/o3gu2pZoaWV1HYJSyjG/S1ryA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2031
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 09:11:53AM +0100, Mauro Carvalho Chehab wrote:
> There are a couple of issues at i915 display kernel-doc markups:
> 
> 	drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Function parameter or member 'intel_connector' not described in 'intel_connector_debugfs_add'
> 	drivers/gpu/drm/i915/display/intel_display_debugfs.c:2238: warning: Excess function parameter 'connector' description in 'intel_connector_debugfs_add'
> 	drivers/gpu/drm/i915/display/intel_display_power.c:700: warning: expecting prototype for intel_display_power_put_async(). Prototype was for __intel_display_power_put_async() instead
> 	drivers/gpu/drm/i915/display/intel_tc.c:807: warning: Function parameter or member 'work' not described in 'intel_tc_port_disconnect_phy_work'
> 	drivers/gpu/drm/i915/display/intel_tc.c:807: warning: Excess function parameter 'dig_port' description in 'intel_tc_port_disconnect_phy_work'
> 
> Those are due to wrong parameter of function name. Address them.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH v2 00/39] at: https://lore.kernel.org/all/cover.1657699522.git.mchehab@kernel.org/
> 
>  drivers/gpu/drm/i915/display/intel_display_debugfs.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_display_power.c   | 2 +-
>  drivers/gpu/drm/i915/display/intel_tc.c              | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index 6c3954479047..1e35eb01742b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2229,7 +2229,7 @@ DEFINE_SHOW_ATTRIBUTE(i915_current_bpc);
>  
>  /**
>   * intel_connector_debugfs_add - add i915 specific connector debugfs files
> - * @connector: pointer to a registered drm_connector
> + * @intel_connector: pointer to a registered drm_connector
>   *
>   * Cleanup will be done by drm_connector_unregister() through a call to
>   * drm_debugfs_connector_remove().
> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
> index 589af257edeb..fd6b71160a06 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.c
> @@ -685,7 +685,7 @@ intel_display_power_put_async_work(struct work_struct *work)
>  }
>  
>  /**
> - * intel_display_power_put_async - release a power domain reference asynchronously
> + * __intel_display_power_put_async - release a power domain reference asynchronously

oh, we are really using __ prefix for non-static functions?! o.O

anyway, with that ditto "()" consistency,

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>


>   * @i915: i915 device instance
>   * @domain: power domain to reference
>   * @wakeref: wakeref acquired for the reference that is being released
> diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> index 6773840f6cc7..7ce0cbe0de05 100644
> --- a/drivers/gpu/drm/i915/display/intel_tc.c
> +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> @@ -797,7 +797,7 @@ void intel_tc_port_lock(struct intel_digital_port *dig_port)
>  
>  /**
>   * intel_tc_port_disconnect_phy_work: disconnect TypeC PHY from display port
> - * @dig_port: digital port
> + * @work: workqueue struct
>   *
>   * Disconnect the given digital port from its TypeC PHY (handing back the
>   * control of the PHY to the TypeC subsystem). This will happen in a delayed
> -- 
> 2.36.1
>