Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp163143imw; Wed, 13 Jul 2022 22:00:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vsqCewqdz4blsC7UI+wZiGD7JD3kvJgEIcehfZRV/VMW4x93eRBzplNHKsMXBSfTMQA/UG X-Received: by 2002:a63:4e09:0:b0:412:1ba3:672a with SMTP id c9-20020a634e09000000b004121ba3672amr6114981pgb.597.1657774811581; Wed, 13 Jul 2022 22:00:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657774811; cv=none; d=google.com; s=arc-20160816; b=wkuGV3vnOctGXT6KbRDrvuVFK7gk7EYKVqYZIjOwPGwERmLBF+466H5wlurJS2b5Ho arrBz2gjG7intqNLtjGEowmk/EiFyfz4FBF0j1EbfYxR9AO5MXaXyslMlchMl6/QvlDl NTA85la7Ocvp/K2xzqe8Oo/0dd+b1S/XDuNMVyPhYiOUpCs2HWKTUsrPlxAR+QyMediG HOpYUAYdYFkmQZKr3dqfXVqHLnXU5HZsmpd3I65/e+2iOfy8nmzSTJQi84M9F1O0fTWH UzpA4OSG0s7pIRfE1qov3FacRcxKWq1ZQxzxaIYg9VpWkv8RJvS+Pt7kqFQUpQmMaWkJ 07Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wvxNVC7v6IRfhPDvi+vlda/Ydr6xcl7uzGy3JRiwJsk=; b=aflLMkZCyDCK2lzKDglPNXmDYj8ypSxFmd7hl+Qh7vkOptHiXnSCev2fYJBKTaGizZ n/OazxdsUwo1flv3EW6HxVryg/xbGBk605hG0oiS8gnUxG4ikmdR1v51vAOXRDt1KE4J MAYa/36mARLFIygoSS3CTgGShnS+HgTVW8JuZNDquLs4Rm/E2rZpPJhesJ88G1rEFN/O To+6+953jQon15qFZJ+y0nOuyoQR3t81J4NfkkyH75w+/29fGbuaq92GuxHDpLu7SCql uuOR0Eak9o+bCCeNGoUKp8kHzknVSdmsl/x4DIO9pQyoc6m2DJ5oOzlZrhx/c5Wr+NbG /d6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="h6zx/qtQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h18-20020a056a00219200b0052ae60ddfcbsi553170pfi.374.2022.07.13.21.59.59; Wed, 13 Jul 2022 22:00:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="h6zx/qtQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234312AbiGNE1m (ORCPT + 99 others); Thu, 14 Jul 2022 00:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233878AbiGNE06 (ORCPT ); Thu, 14 Jul 2022 00:26:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF74B2B1AF; Wed, 13 Jul 2022 21:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wvxNVC7v6IRfhPDvi+vlda/Ydr6xcl7uzGy3JRiwJsk=; b=h6zx/qtQBkYoU+/liavyngGoGQ qsOPbojToSP07GYfoD4L1Rj/BdqAn48dD0TbbkCv6s0frYjwB2NxyHfS8sg/zexGgCpRPzE/TYQFN Li5G/evrqQyw+eHnbHDEYkA4UPfWAFvroO4nVkNVpo0j73IBWKbiJAUxbwqIo60Snl76iyVaNU4i/ PwqGuaMEcrYNxkwnJJxhEXZau/ZDirtLGlKAl9iQ27dKm5Nb57sDSzijqu4zBp3yAGRrB/+7UcQNB Eqroje4xhcnqhz99amuRSNTyDZf+KIL39W8xd/Abw/myVnEL3l8woK+0k4FNHzi/b7nJee72rFeH8 mFG3QhHQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBqOC-00AasH-TU; Thu, 14 Jul 2022 04:23:48 +0000 Date: Wed, 13 Jul 2022 21:23:48 -0700 From: Christoph Hellwig To: Song Liu Cc: Christoph Hellwig , Song Liu , bpf , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "mcgrof@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "mhiramat@kernel.org" , "naveen.n.rao@linux.ibm.com" , "davem@davemloft.net" , "anil.s.keshavamurthy@intel.com" , "keescook@chromium.org" , "dave@stgolabs.net" , "daniel@iogearbox.net" , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" , "akpm@linux-foundation.org" Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory Message-ID: References: <20220713071846.3286727-1-song@kernel.org> <20220713071846.3286727-2-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote: > > > > On Jul 13, 2022, at 3:08 AM, Christoph Hellwig wrote: > > > > NAK. This is not something that should be an exported public API > > ever. > > Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..) Even without that it really is not a vmalloc API anyway. Executable memory needs to be written first, so we should allocate it in that state and only mark it executable after that write has completed.