Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220714015647.25074-1-xiaolinkui@kylinos.cn> <CAKH8qBuj=7HXF2xTRWqso9o56t5Tpg68C+r5PnHVnEyu129UmA@mail.gmail.com>
In-Reply-To: <CAKH8qBuj=7HXF2xTRWqso9o56t5Tpg68C+r5PnHVnEyu129UmA@mail.gmail.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 13 Jul 2022 23:21:01 -0700
Message-ID: <CAEf4BzY5ncGXcnFVGgdQp_wMrJ4dsgae2s95BXr4PkL2oMURnQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: Return true/false (not 1/0) from
 bool functions
To:     Stanislav Fomichev <sdf@google.com>
Cc:     xiaolinkui <xiaolinkui@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        john fastabend <john.fastabend@gmail.com>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
        Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
        Shuah Khan <shuah@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, xiaolinkui@kylinos.cn,
        Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 13, 2022 at 8:37 PM Stanislav Fomichev <sdf@google.com> wrote:
>
> On Wed, Jul 13, 2022 at 6:57 PM xiaolinkui <xiaolinkui@gmail.com> wrote:
> >
> > From: Linkui Xiao <xiaolinkui@kylinos.cn>
> >
> > Return boolean values ("true" or "false") instead of 1 or 0 from bool
> > functions.  This fixes the following warnings from coccicheck:
> >
> > tools/testing/selftests/bpf/progs/test_xdp_noinline.c:407:9-10: WARNING:
> > return of 0/1 in function 'decap_v4' with return type bool
> > tools/testing/selftests/bpf/progs/test_xdp_noinline.c:389:9-10: WARNING:
> > return of 0/1 in function 'decap_v6' with return type bool
> > tools/testing/selftests/bpf/progs/test_xdp_noinline.c:290:9-10: WARNING:
> > return of 0/1 in function 'encap_v6' with return type bool
> > tools/testing/selftests/bpf/progs/test_xdp_noinline.c:264:9-10: WARNING:
> > return of 0/1 in function 'parse_tcp' with return type bool
> > tools/testing/selftests/bpf/progs/test_xdp_noinline.c:242:9-10: WARNING:
> > return of 0/1 in function 'parse_udp' with return type bool
> >
> > Generated by: scripts/coccinelle/misc/boolreturn.cocci
> >
> > Signed-off-by: Linkui Xiao <xiaolinkui@kylinos.cn>
> Reviewed-by: Stanislav Fomichev <sdf@google.com>
>
> > Suggested-by: Stanislav Fomichev <sdf@google.com>
> That shouldn't be here :-) I didn't suggest the patch, you're
> suggesting it, I'm just suggesting to properly format it.
> Probably not worth a respin, I hope whoever gets to apply it can drop
> that line (or maybe keep it, I don't mind).

Dropped Suggested-by, applied to bpf-next.

>
> > ---
> >  .../selftests/bpf/progs/test_xdp_noinline.c   | 30 +++++++++----------
> >  1 file changed, 15 insertions(+), 15 deletions(-)
> >

[...]