Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76b421cd-7a91-ebac-6f48-8a00eaf3c6f5@suse.com>
Date:   Thu, 14 Jul 2022 08:28:38 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT
 without MTRR
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Jane Chu <jane.chu@oracle.com>,
        Tianyu Lan <Tianyu.Lan@microsoft.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Sean Christopherson <seanjc@google.com>,
        xen-devel@lists.xenproject.org,
        Chuck Zmudzinski <brchuckz@aol.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com>
 <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com>
 <ec4b2791-886f-4d52-ab39-b0c07489c4ca@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <ec4b2791-886f-4d52-ab39-b0c07489c4ca@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWk2QjhDUzhTa0VOa2craVdWbGRyU29Kb3R4em9WVzF2Y1E2cnFCYTlteHNu?=
 =?utf-8?B?Q0VYUXRsVktTeGhYZmtyWVZlcGgzaVdQczNLMlFmdk5rVDJPclVObmxVZDZ6?=
 =?utf-8?B?bURoaXdVeitYOVFscmdKNTV6aTg3cmFhdzNITFhyWHNubjZ5UERPZzBsaXJO?=
 =?utf-8?B?b0Rla1hZRDhZSUdocUxiMXIzS0lxZjJselhJc3l6M29xZzhiME4xSGFWSTI3?=
 =?utf-8?B?dEkvMyt1R0V0N1lIeTc2emZkVTMxeXdTWVRtRnczYVFJYVhlMHQra28zTFdt?=
 =?utf-8?B?d3J1QnZ1ejVYNXVnMVhkOVIwZEpvbnBqNGljVlZld1I2aUY2TmIvM1ZGcXho?=
 =?utf-8?B?YVIwZkhPSlVmWUxNSWpwVWtpeVo2bmt3bWZSZW1OcVFnYVJIQVdBSmlieDht?=
 =?utf-8?B?NkhVMytZWlZVc2tsc2NtZWRWaTFSSlprTE1FRHhFMkMyMGtEYVk0ODdqb1Fm?=
 =?utf-8?B?TEg2T1dRSVN1cWNTM2lFS3phKzVtbTRUaVBYc2pNT0k5WGx1TGluVUdLSlcy?=
 =?utf-8?B?cE5lemlTMm9NeGRWYkcwZnRaQ0JIUm03UFlVbGRlS1FtL2d2RmpwMzR0aHJ3?=
 =?utf-8?B?Z2NsZEliYnVaTTY4QmRvWE1BQVhYVktDeUc3Q2lhQmhmYkF1bm9HN1JaZ0tt?=
 =?utf-8?B?RDJVdFhpTHRhSE9Fb3hJVHBKSzhVWTU2aWZRZ3kwQmlXUE50MFVWMDJWcHds?=
 =?utf-8?B?SERad3VZZExKVkhCWi91V1FnQnpVY1luM3c0bWN4NXUvcmVDTk9mQ0p3bnl1?=
 =?utf-8?B?ZWFDb3ZWQmptQmE3NjFTR21DS2xkbGx2emsrdzEwc1dpSzNscEFQNGhkTUxH?=
 =?utf-8?B?aWNtL2syUzZrMUlQRnFRdE9uc0xpRTk5WG9vV1BDSFFLbXhzdkRSOWVZREl0?=
 =?utf-8?B?RTZwajk5UHNzWTVTUThnOWlKcnJDQjBUZW9BdW1WOGs3cmordE9hRnQzRVRU?=
 =?utf-8?B?L1NRTXQwQVdiU1pJWEYyQXlzVjYyZG5HMDlZcUJFQmpNc1k5VkcwT2pvK09w?=
 =?utf-8?B?WHluOVNndWRWc2NzVmk4bWxOYmg3UEdNalltM2c1K3gwMmhyOVVwcUVjcjRu?=
 =?utf-8?B?NXJNOFQ1amRHTEVlQU84STBlZy80OFRnMUlCTzNsajRjOVJJQ3RZZ2JIQzJr?=
 =?utf-8?B?UTc0UDhlNUR6bTRKSm0xUXYxQVA0OThpa1p5WGI4K1pzWHIrWHRHZEd2a3A3?=
 =?utf-8?B?bzVtOHg0ZmZTTFNiV3NLQ2lNQSsyMVgxc1RuWHk1cHlOOTFEQmU3VzU1T1k0?=
 =?utf-8?B?YUxLMlh6ajdzdUxGaEhpQkNFcUxCb3FnZWRsc3NJWWVERU1hYkk2d3ZsWFQ5?=
 =?utf-8?B?bFg5ZDF3Ymd2ZUtUamRyYlVlNWtWZnlmZkdaUFhLbHRVMkxMcmtzM2taQjEr?=
 =?utf-8?B?RlRRaWJKalNuUW1uTDRZN0xZZ3BDMndNeE96YStaTEZaK2lSampEalFUK1hK?=
 =?utf-8?B?OFBCS3BJRGVCcnpidnhGVHZpblhEVHYrYkdDaFVBWnNGOG9pSUVtUytCQy90?=
 =?utf-8?B?cy9HK3AzT21QL0huSFN3TU9uamFiNXlTQ1h3M09EblN6N0dRNDZTUXM5c09W?=
 =?utf-8?B?aXlBem1HUXJML0Q5UEJSOWw4Vk83Nm5WS3hsM3Y4MVZMWHJrK09haGpub3B0?=
 =?utf-8?B?U2s1Wk1yNHVsdlpyU3BOYkhHbUVyc1A1UERhUW5qU0NCNGdmbjRjaFZrUzlR?=
 =?utf-8?B?U0hveVdHdzJIUmhhbSt2QXhZMVgxNjY2VGdzd1NUb01ScE5zVUl5aHZydk9j?=
 =?utf-8?B?blJjdVVnbUc4RkRkL0tMT0UwREtjd3FPeTVrSTkva1NMUTAvNURLc0ZZU1lQ?=
 =?utf-8?B?anhkbHVrQVNpZzhGVHVXN0JobFFYL1M3S28wSjREVnJVSzErRHJuL3EyQXM1?=
 =?utf-8?B?YzR0MGloczhSUUtHUG1HT3NqbnFUemxBU3VPaXJVYm5MRUJyNFpHNFVUZitN?=
 =?utf-8?B?VThKRll5bVA4cnp3RWp2WHhHdW5nSTJJcVRCbGE2cWdFYlEvWklzTnErNWJn?=
 =?utf-8?B?aWlxaSt4cDM1cEM3S0VoeHdLRSsrb2xITWJLa25Oa01wK0VvZEZCYm1ud0hS?=
 =?utf-8?B?V1pEMjlkdDJ6ZDBuWWM0N1Y5djdZa3F1ZmFlbGhEK3lTSmJBb0kva0VENjla?=
 =?utf-8?Q?1OfHrm4/BrJi2eCBAzceTDWXT?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 890d6b25-ecc9-4cfc-1720-08da656217f1
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 06:28:41.1254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: h0f4nX/qECLf+7es3I6k417KQ63N3bJPznCqljoopr5NSkP6kPu79/8H+6vl5zgAX0asfyRqrn37OSr0EUrvLw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8886
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 14.07.2022 07:40, Juergen Gross wrote:
> On 13.07.22 03:36, Chuck Zmudzinski wrote:
>> @@ -292,7 +294,7 @@ void init_cache_modes(void)
>>   		rdmsrl(MSR_IA32_CR_PAT, pat);
>>   	}
>>   
>> -	if (!pat) {
>> +	if (!pat || pat_force_disabled) {
> 
> Can we just remove this modification and ...
> 
>>   		/*
>>   		 * No PAT. Emulate the PAT table that corresponds to the two
>>   		 * cache bits, PWT (Write Through) and PCD (Cache Disable).
>> @@ -313,6 +315,16 @@ void init_cache_modes(void)
>>   		 */
>>   		pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) |
>>   		      PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);
>> +	} else if (!pat_bp_enabled) {
> 
> ... use
> 
> +	} else if (!pat_bp_enabled && !pat_force_disabled) {
> 
> here?
> 
> This will result in the desired outcome in all cases IMO: If PAT wasn't
> disabled via "nopat" and the PAT MSR has a non-zero value (from BIOS or
> Hypervisor) and PAT has been disabled implicitly (e.g. due to lack of
> MTRR), then PAT will be set to "enabled" again.

Just to mention it explicitly: If the value _read_ from the MSR is zero,
we're hosed anyway, as then we can only express a single memory type (UC)
in all PTEs. The zero case we mean to deal with is when reading the MSR
wasn't valid to try.

Jan