Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org>
Date:   Thu, 14 Jul 2022 08:56:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada
 3720 boards
Content-Language: en-US
To:     =?UTF-8?Q?Pali_Roh=c3=a1r?= <pali@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Gregory Clement <gregory.clement@bootlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220713125644.3117-1-pali@kernel.org>
 <a9e1ccb7-6caa-2f7c-b879-b3ff4945794c@linaro.org>
 <20220713200336.addvyfjhakrx72am@pali>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20220713200336.addvyfjhakrx72am@pali>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 13/07/2022 22:03, Pali Rohár wrote:
> On Wednesday 13 July 2022 21:42:43 Krzysztof Kozlowski wrote:
>> On 13/07/2022 14:56, Pali Rohár wrote:
>>> All Armada 3720 boards have Armada 3720 processor which is of Armada 3700
>>> family and do not have Armada 3710 processor. So none of them should have
>>> compatible string for Armada 3710 processor.
>>>
>>> Fix compatible string for all these boards by removing wrong processor
>>> string "marvell,armada3710" and adding family string "marvell,armada3700"
>>> as the last one. (Note that this is same way how are defined Armada 3710
>>> DTS files).
>>
>> Please do not introduce some changes just in DTS, but start from the
>> bindings. Someone wrote the bindings like that and expected to be that
>> way, so first change the bindings with proper rationale. Then change the
>> DTS files.
>>
>>
>> Best regards,
>> Krzysztof
> 
> Ok, I tried to update bindings and fix example in it, see patch:
> https://lore.kernel.org/linux-devicetree/20220713200123.22612-1-pali@kernel.org/

The reason you used here should be expressed in that commit as well
because you change the ABI and affect other users (projects, systems).

Best regards,
Krzysztof