Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp239796imw; Thu, 14 Jul 2022 00:19:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tyE5jPjXlHVVlQCr30alW9dAJuB/Ifdy0cUATIZNC5mGfyaiDDhItVWPpC0BMaOZrj6Ngo X-Received: by 2002:a17:90a:4e05:b0:1ec:8de4:1dd5 with SMTP id n5-20020a17090a4e0500b001ec8de41dd5mr8254278pjh.242.1657783143483; Thu, 14 Jul 2022 00:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657783143; cv=none; d=google.com; s=arc-20160816; b=McF2+aS8vnALHG+mBNZXgVxA3tsiaXQyXy8wFcPafltyPswYzczhiXPKMEEyW/bU+W P/Wu4FgLNykdbD16nazubKn4msQ2PnXn4MelSwaMOYensuN8wkLoyt/7hdBASOM+xM+B iphhwhIqdEf9h7SUIRQneA1SnP+/PyTOyyDkvaL0sfwu4V2d4zx7q7O6E7p4AYoSK+cf GmmxLKEOCQgejfMDz2ecuNIiDho212dwoazub5+nHTsQyzzneek5yec1J/JgHMzgjzZG H6BxcZP2q7pykt9omiJRsHwBRQy7lCZIwYcLfM0WOTsc4XXI3NpcOHyRpJWmekCDt2Mh uhGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=kAMorpNPpq8Kl7mIQPaFEYYx6iRT5mkDQv6ldaOiuso=; b=RRivgLWZDJCswZH/Sf0+BQG5dv0CHrvU6CyHO6CucmwZjzVSIL3KWan09YDrIGprV9 ucMHecfUz1BAhQ8TJyTULStS6b86uy2G2oGZq8YlQ3yWurjZBlpOt8YTNPdqVrkaKFPx uaLJOOO8CrzpKNNJs6ryl8r9mEuBM5bj7Xwbift+n3V0K18+2lmRzX4S3Xg4Q3Baskem j0jGkLFG9I8sK3K8Nrk5f0C1JVkN3ibIHcKV93w8AvxLDliTSgdvjkFI3JohhULi/EfB SMXZ+M9GFdmEmD/7d1hohxd15OmMCXuBfqM9WJoRlhibpS9bZaWIIo0Uv0lSd6cJPbpc sW7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mCtgy7WJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v38-20020a631526000000b0041570365feasi966606pgl.330.2022.07.14.00.18.47; Thu, 14 Jul 2022 00:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mCtgy7WJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232578AbiGNGuK (ORCPT + 99 others); Thu, 14 Jul 2022 02:50:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232322AbiGNGuI (ORCPT ); Thu, 14 Jul 2022 02:50:08 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEFF127FED for ; Wed, 13 Jul 2022 23:50:06 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id o12so1067360ljc.3 for ; Wed, 13 Jul 2022 23:50:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=kAMorpNPpq8Kl7mIQPaFEYYx6iRT5mkDQv6ldaOiuso=; b=mCtgy7WJTcIR5VvYFE1mQpSdwHFub/JxquNNbGjOEDG5kerZcvfIWuR/Q4SfMdeLCM LKPbhc4nez83WRVbxrYgZnSGGOfCShXYSZVg1nlUWSu3Nkz5eoiwG9GJ9dxxk8GZCVMj 0VGmzNW+39nIVWiAdU11NFp9Pqt0bKUKDpVd30O2rLoijaUPWKYITYSu52p4vyn1YxLK itzn4rLQSdioMpwWIsLTXSl5Rm0aib09E33je8nhM053J2+ni+JPbwJds70N7qPumteu aiRHfv0M8e3NXr0lJCxtybrL33+/GUf9upn7Agyqg7bvEbG8rpodGLO0VwrYap7piiPI DA9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=kAMorpNPpq8Kl7mIQPaFEYYx6iRT5mkDQv6ldaOiuso=; b=ZsxPbbFBUutfq+I6oBu4rS44Z8E0FV2L+HUFv1zoIVmz2vCUYUYQdoS0n1M1XnLqdX LszuQag/tBIH9Xzle4Z0DWL46A25Zrn0yQUf/UnwkH5jg0+wiW73niVX50yRwjWDLoVP lXcZd9nsdPbqHz0PcAlmjctcE7IpBcgqr1EOnyLaPchA11CNHU3FEGXD0VUr/6omki5W xXNKzYSp7CNK8xhNss7v7vh1oRfsnYc83U9riFG13YXXQb93GLC1uUo3PTu7UfIa+i/k b1JbmtBu6lgG1U7S3ag+wKxgGTzeVEtZTeFIWI07pt+9Rm5dZLnhX7mi/DCyyBsZ7egT r2/A== X-Gm-Message-State: AJIora+WdCt11z9Me+jK2suHJupmdkULV48mrTP0mkXlpwVyWMnNvVtv 6YZ2V9UgZclbssVvoHH3bnBMeA== X-Received: by 2002:a2e:968b:0:b0:25d:67ce:134c with SMTP id q11-20020a2e968b000000b0025d67ce134cmr3861590lji.277.1657781405298; Wed, 13 Jul 2022 23:50:05 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id m1-20020a056512114100b00489fdc9ac15sm195626lfg.42.2022.07.13.23.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 23:50:04 -0700 (PDT) Message-ID: <32b30b60-26f7-50e9-7dca-c25bc3f4014d@linaro.org> Date: Thu, 14 Jul 2022 08:50:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v10 1/2] thermal: Add thermal driver for Sunplus Content-Language: en-US To: =?UTF-8?B?TGggS3VvIOmDreWKm+ixqg==?= , Li-hao Kuo , "rafael@kernel.org" , "daniel.lezcano@linaro.org" , "amitk@kernel.org" , "rui.zhang@intel.com" , "robh+dt@kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/07/2022 07:32, Lh Kuo 郭力豪 wrote: >>> +} >>> + >>> +static int sunplus_thermal_remove(struct platform_device *pdev) { >>> + struct sp_thermal_data *sp_data = platform_get_drvdata(pdev); >>> + >>> + thermal_zone_of_sensor_unregister(&pdev->dev, sp_data->pcb_tz); >> >> You used devm to register, so this looks wrong and will lead to double free. >> >> > > You mean the remove function is not needed. ?? At least this call but after its removal the entire function would be empty, I think. Best regards, Krzysztof