Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220714012908.4948-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20220714012908.4948-1-yang.lee@linux.alibaba.com>
From:   Oded Gabbay <ogabbay@kernel.org>
Date:   Thu, 14 Jul 2022 09:54:04 +0300
Message-ID: <CAFCwf12DeOFdwKk-bunOhO=NK6y6emFpEFY0J96Y5bmYE0bYSA@mail.gmail.com>
Subject: Re: [PATCH -next] habanalabs: Simplify bool conversion
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jul 14, 2022 at 4:29 AM Yang Li <yang.lee@linux.alibaba.com> wrote:
>
> Fix the following coccicheck warning:
> ./drivers/misc/habanalabs/gaudi2/gaudi2.c:9727:48-53: WARNING:
> conversion to bool not needed here
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/misc/habanalabs/gaudi2/gaudi2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/gaudi2/gaudi2.c b/drivers/misc/habanalabs/gaudi2/gaudi2.c
> index 98336a1a84b0..344b4dedef41 100644
> --- a/drivers/misc/habanalabs/gaudi2/gaudi2.c
> +++ b/drivers/misc/habanalabs/gaudi2/gaudi2.c
> @@ -9724,7 +9724,7 @@ static int gaudi2_get_mmu_base(struct hl_device *hdev, u64 mmu_id, u32 *mmu_base
>
>  static void gaudi2_ack_mmu_error(struct hl_device *hdev, u64 mmu_id)
>  {
> -       bool is_pmmu = (mmu_id == HW_CAP_PMMU ? true : false);
> +       bool is_pmmu = (mmu_id == HW_CAP_PMMU);
>         struct gaudi2_device *gaudi2 = hdev->asic_specific;
>         u32 mmu_base;
>
> --
> 2.20.1.7.g153144c
>
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>

Applied to -next.
Thanks,
Oded