Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27007c45-1dbb-2c35-b1a8-eb2b2a6c9512@quicinc.com>
Date:   Thu, 14 Jul 2022 12:47:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v2] arm64: dts: qcom: sc8280xp: fix apps_smmu irq
Content-Language: en-US
To:     Parikshit Pareek <quic_ppareek@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
CC:     Rajendra Nayak <quic_rjendra@quicinc.com>,
        Prasanna Kumar <quic_kprasan@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>,
        "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
        Johan Hovold <johan@kernel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
References: <20220712140009.20765-1-quic_ppareek@quicinc.com>
From:   Sai Prakash Ranjan <quic_saipraka@quicinc.com>
In-Reply-To: <20220712140009.20765-1-quic_ppareek@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Parikshit,

On 7/12/2022 7:30 PM, Parikshit Pareek wrote:
> Wrong values have been introduced for interrupts property. Fix those
> ones, and correct the mapping of context banks to irq number.
>
> Fixes: 152d1faf1e2f ("arm64: dts: qcom: add SC8280XP platform")
> Signed-off-by: Parikshit Pareek <quic_ppareek@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 7945cbb57bb4..1276a833251e 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1580,7 +1580,6 @@
>   				     <GIC_SPI 412 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 706 IRQ_TYPE_LEVEL_HIGH>,
> -				     <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>,
> @@ -1591,6 +1590,7 @@
>   				     <GIC_SPI 693 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 694 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 695 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 696 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>,
>   				     <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH>,

Cross checking with the IP doc, 696 is not the only one missing, couple of other interrupts are also missing, below is the list.

Interrupt 689 and 706 are not present in the IP doc, remove it.
Interrupts 696, 697, 716, 913 are missing, I see this patch adds 696, add 697 as well.
Interrupt 890 is not a context interrupt, remove it.


Thanks,
Sai