Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp268019imw; Thu, 14 Jul 2022 01:09:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1te+xbLQd77AKRJTyav+03OlA3pSMCtf1u3BdLzq32Co+qY23iY6NP7m3oaT2JaRRie4ea6 X-Received: by 2002:a17:907:2c77:b0:72b:1154:33da with SMTP id ib23-20020a1709072c7700b0072b115433damr7842997ejc.27.1657786179988; Thu, 14 Jul 2022 01:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657786179; cv=none; d=google.com; s=arc-20160816; b=GhVSywNqnHccJq22fhfHG+lqXu3cW0FStUf/PC+S4ON6FETLw7j6ofbipMbPu+T2J+ c6rKlVIXaiqspvCv87WT3F1/9Nzh8FVpUeqaSDQIU2talaS6LBe8Wj5+IhFhbX7rtVt5 pIGrfAshA++4rj2I/0SacZkREUzMryt6B+6/G3Y+TH8J2Q2UhGVlYM5jl7y+RZm59SWN rIjGSYQLgN79/0feJoD5vRPhvpui5bO25OLPYvYOGT7uMmrifT2XW6D+XxNsDp5JVL+A +f+WP/23sbtXSEzNX6M4fSscKw1A6C+YTg7fgVuXbcIu/qfP9xEWyBODUehrzA3uMR0v jOhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=dzH8+hY0k3IGBygiEttNxOSg4IahmR9anE16nIgC3cE=; b=IWxLml6DcQrRWyESHOSYHWgOOpzOHx5xYf0zM3fXEdnG2ENp5qCXzjGAhbpnOU8dY7 qJORGh11xgKorDEFEYPmJ7XKJ91nwwwd9RC5FJ6Og2Qr+ZOewAcxasWWwsZOLt6IeGcI zzXiIDKqOyZUzB5N3T172TY5ryWjR0xWZvDOSPnfeyCiQ7ZECQqyTsh3scRj0w3EixRG cz+HM+hz0nGnpZH1+paWzRhL3oamhBjyouoE9kMY+jHSfjJ7AXIsxYNXAGQwdEfXvV4y mGvcFb09m5mI3LD5YUsytgLoDvLBdFBCszteuZKzQdxVb1fzp8SXY0WBK/bq319umQ14 MAnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a170906668800b0072b3b54d792si1052998ejo.930.2022.07.14.01.09.15; Thu, 14 Jul 2022 01:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237743AbiGNHsR (ORCPT + 99 others); Thu, 14 Jul 2022 03:48:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237570AbiGNHr2 (ORCPT ); Thu, 14 Jul 2022 03:47:28 -0400 Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC4813A4B0; Thu, 14 Jul 2022 00:47:12 -0700 (PDT) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id A5AAF20217F; Thu, 14 Jul 2022 09:47:11 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 6C20D202182; Thu, 14 Jul 2022 09:47:11 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 20E5D180222A; Thu, 14 Jul 2022 15:47:10 +0800 (+08) From: Richard Zhu To: l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org, broonie@kernel.org, lorenzo.pieralisi@arm.com, festevam@gmail.com, francesco.dolcini@toradex.com Cc: hongxing.zhu@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com Subject: [PATCH v15 15/17] PCI: imx6: Disable clocks in reverse order of enable Date: Thu, 14 Jul 2022 15:31:07 +0800 Message-Id: <1657783869-19194-16-git-send-email-hongxing.zhu@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1657783869-19194-1-git-send-email-hongxing.zhu@nxp.com> References: <1657783869-19194-1-git-send-email-hongxing.zhu@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas imx6_pcie_clk_enable() enables clocks in the order: pcie_phy pcie_bus pcie imx6_pcie_enable_ref_clk Change imx6_pcie_clk_disable() to disable them in the reverse order. Link: https://lore.kernel.org/r/1656645935-1370-16-git-send-email-hongxing.zhu@nxp.com Signed-off-by: Bjorn Helgaas Reviewed-by: Lucas Stach Acked-by: Richard Zhu --- drivers/pci/controller/dwc/pci-imx6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index afb4d58fd693..6d7ae141ec58 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -655,10 +655,10 @@ static int imx6_pcie_clk_enable(struct imx6_pcie *imx6_pcie) static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie) { + imx6_pcie_disable_ref_clk(imx6_pcie); clk_disable_unprepare(imx6_pcie->pcie); - clk_disable_unprepare(imx6_pcie->pcie_phy); clk_disable_unprepare(imx6_pcie->pcie_bus); - imx6_pcie_disable_ref_clk(imx6_pcie); + clk_disable_unprepare(imx6_pcie->pcie_phy); } static void imx6_pcie_assert_core_reset(struct imx6_pcie *imx6_pcie) -- 2.25.1