Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp329136imw; Thu, 14 Jul 2022 01:58:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sT+yJrd64zlurzTWgxvGZRgW2rs1nxcQFuZDWk7RVfigcZdmGvFCCbyMw1kdYi/8Qy90AP X-Received: by 2002:a05:6402:cba:b0:43a:6b17:f6b5 with SMTP id cn26-20020a0564020cba00b0043a6b17f6b5mr11013539edb.330.1657789114555; Thu, 14 Jul 2022 01:58:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657789114; cv=none; d=google.com; s=arc-20160816; b=pGxRvSh4Y6+XNhIIotHu7uDdsEboG+UqYSFZHLmyKqt4+Ea24O1HduZKYzxLtq1+ge 6EKLLN8YFC+Z3WIeRog9CncS9AFfa+a6h6E7/kH1y8FkLpjz4YlNaxz2y3UlJMNvkXpo r8sTb/Y38FnthBiE4Idg2z2BgRkSwUAsD6O28SOc0lwCWTkPt9AhDOfBveEGiQPkMLhy mws/cQUYwlElEtZzV2wLdyaA+k539wlBbbaDUAxWfpymEkipClaHjVaYL/ZhXo4hFC8u 5WtJ/pK7arfHX/CgI168vRtcE6WsN2akPBxjsPuuz8pSxGgY8T6HXkmX5Gz5F51rTz2r naeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e3WbPlZqSS4Vb8MfGJkxkUiSAiggi3mYIZReCx2ozlM=; b=Z013vfiHhjte0JU/A51cOanXYqE4Tq8XxUVj7GaA8TPraV+aCTieDM7lkb5fxKKBGA V/ID2R7DRgrm0K2Br5SWvpIfU1gaasQpPTh79XxTcPYW1Zbog66IZZVtN2Oh8zSk28LL 3Jqy2FO5VWC9QXT81S7f2n3Rhbu1KVw6m28e6UTKUC4taMCDrlJcAlq5yCeRKIoQbt0Q rVNuaHe/t6uV9AI97hwXJw2+oxKEjs0cuHCSplRPrC8avJUktW+vuS2IEfdB8kN3QuWZ siQ13V2Vz8VGYdR/n+AfRM8jc1oc7xb0uTR3hlwJD4RyKus30Hi6y3TlbEEzAqn2E92a fUUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=hTuoRN0v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a056402524700b0043aa021096dsi1831605edd.378.2022.07.14.01.58.09; Thu, 14 Jul 2022 01:58:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=hTuoRN0v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229645AbiGNIGY (ORCPT + 99 others); Thu, 14 Jul 2022 04:06:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiGNIGW (ORCPT ); Thu, 14 Jul 2022 04:06:22 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1698629833 for ; Thu, 14 Jul 2022 01:06:21 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 8-20020a05600c024800b003a2fe343db1so736127wmj.1 for ; Thu, 14 Jul 2022 01:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e3WbPlZqSS4Vb8MfGJkxkUiSAiggi3mYIZReCx2ozlM=; b=hTuoRN0viSxD9CKIZjpzF3Uw1AnKS2Gw1dxFSjthP3Mhy7fKKYMPnp/RAXJgP9P3bT mQp74gqDFYsPCSeB1pCt2lTnn+upKmqXE/bf2/cHFxpNcLr9AwC4IYZ+I9nmLSRAn0Tf j8j3iUL/WVmGAPdfBQUm8uXtK96h8Rh2FqrzoTGfdGbETcAFrTT/WzvyQ1B/cNUZK6U/ LupA20UTUZsdhpzmSQHYKv5njpN1QZHGS3srZIKXVit5oJ/xvzt8xaX8gU2wIfvX/tWt p9KuLnJxxDVlZ+M6RzIVFnrpP8J8cYnGE5J5DkCJIrey2X4pEbOFIA2bRB/Yy0HDL0/W XQjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e3WbPlZqSS4Vb8MfGJkxkUiSAiggi3mYIZReCx2ozlM=; b=kkDnaHZDUMg3PSjC0W7/KDYdg5TKnxpWl4fqdWKpRUseuZmmTl1GY87rkCvccGO/9U ZoxAZ/IwZQH33t/CVwS4FDRJ8zfeDA8fXMhVGpcNdrzPGRDPNiyL5+iUDgHksNy6gGYR FuuLOZ+bp7oxlIeRvA1CbuYd0+k8wAF35DZu1DoOxvyNxreteo7FnWUEmWz/UQ9w/TvU vIeni3vljmBOT6r0C1L/gd52ureT/2HldGrB6KgwGSnC4/bSyefB2xx4RYZl+V4S6nsT yBzGDvL/z9+euOomYhh/RRYHjUK9GOEbG61BF7we2W3wDb+ItI/Xu0X9IZ7n849Uw0+V nYhQ== X-Gm-Message-State: AJIora/x+O4YL0pvh8qLlHB34oTyu7/jQfFjobCttq2+Ojga9F+QWSZc rlQMc7KPAm5oXYeciQrtXC0y5jPsz3Fa3e0R X-Received: by 2002:a1c:19c3:0:b0:39c:6479:3ca with SMTP id 186-20020a1c19c3000000b0039c647903camr13760340wmz.27.1657785979509; Thu, 14 Jul 2022 01:06:19 -0700 (PDT) Received: from rainbowdash.office.codethink.co.uk ([167.98.27.226]) by smtp.gmail.com with ESMTPSA id r10-20020a05600c35ca00b003a2e5296befsm4613086wmq.32.2022.07.14.01.06.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 01:06:19 -0700 (PDT) From: Ben Dooks To: linux-kernel@vger.kernel.org Cc: Sudip Mukherjee , Jude Onyenegecha , Ben Dooks Subject: [PATCH] kernel/hung_task: make unexported variables static Date: Thu, 14 Jul 2022 09:06:17 +0100 Message-Id: <20220714080617.198810-1-ben.dooks@sifive.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warnings for un-declared variables by making them static: kernel/hung_task.c:31:19: warning: symbol 'sysctl_hung_task_check_count' was not declared. Should it be static? kernel/hung_task.c:50:29: warning: symbol 'sysctl_hung_task_check_interval_secs' was not declared. Should it be static? kernel/hung_task.c:52:19: warning: symbol 'sysctl_hung_task_warnings' was not declared. Should it be static? kernel/hung_task.c:75:28: warning: symbol 'sysctl_hung_task_panic' was not declared. Should it be static? Signed-off-by: Ben Dooks --- kernel/hung_task.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/hung_task.c b/kernel/hung_task.c index bb2354f73ded..48106a950554 100644 --- a/kernel/hung_task.c +++ b/kernel/hung_task.c @@ -28,7 +28,7 @@ /* * The number of tasks checked: */ -int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT; +static int __read_mostly sysctl_hung_task_check_count = PID_MAX_LIMIT; /* * Limit number of tasks checked in a batch. @@ -47,9 +47,9 @@ unsigned long __read_mostly sysctl_hung_task_timeout_secs = CONFIG_DEFAULT_HUNG_ /* * Zero (default value) means use sysctl_hung_task_timeout_secs: */ -unsigned long __read_mostly sysctl_hung_task_check_interval_secs; +static unsigned long __read_mostly sysctl_hung_task_check_interval_secs; -int __read_mostly sysctl_hung_task_warnings = 10; +static int __read_mostly sysctl_hung_task_warnings = 10; static int __read_mostly did_panic; static bool hung_task_show_lock; @@ -72,7 +72,7 @@ static unsigned int __read_mostly sysctl_hung_task_all_cpu_backtrace; * Should we panic (and reboot, if panic_timeout= is set) when a * hung task is detected: */ -unsigned int __read_mostly sysctl_hung_task_panic = +static unsigned int __read_mostly sysctl_hung_task_panic = IS_ENABLED(CONFIG_BOOTPARAM_HUNG_TASK_PANIC); static int -- 2.35.1