Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760597AbXFALJW (ORCPT ); Fri, 1 Jun 2007 07:09:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758861AbXFALJH (ORCPT ); Fri, 1 Jun 2007 07:09:07 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:37032 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbXFALJF (ORCPT ); Fri, 1 Jun 2007 07:09:05 -0400 Date: Fri, 1 Jun 2007 16:38:45 +0530 From: Vivek Goyal To: "Salyzyn, Mark" Cc: linux-scsi@vger.kernel.org, Andrew Morton , Yinghai Lu , "Eric W. Biederman" , Michal Piotrowski , Linux Kernel Mailing List Subject: Re: [PATCH] aacraid: fix shutdown handler to also disable interrupts. Message-ID: <20070601110845.GC20714@in.ibm.com> Reply-To: vgoyal@in.ibm.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1349 Lines: 31 On Wed, May 30, 2007 at 11:59:13AM -0400, Salyzyn, Mark wrote: > Moves quiesce, thread and interrupt shutdown into aacraid drivers' > .shutdown handler. This fix to the aac_shutdown handler will remove the > superfluous reset of the adapter during a (clean) kexec. > > This fix may mitigate the active investigation 'kexec and aacraid > broken' but it is unlikely to affect the root cause (issue likely > present in both kexec and kdump). This patch reduces the chance the > problem will occur with a kexec. The fix for root cause is currently > expected to be the minimum value check to the aacraid.startup_timeout > driver variable after an adapter reset within aacraid_commit_reset.patch > submitted on 05/22/2007 and awaiting testing by Yinghai to confirm. > > This attached patch is against current scsi-misc-2.6 > > ObligatoryDisclaimer: Please accept my condolences regarding Outlook's > handling of patch attachments. > > Signed-off-by: Mark Salyzyn > Thanks Mark. This does fix the issue of unnecessary reset of aacraid adapter over kexec on my machine. Thanks Vivek - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/