Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kao, Ben" <ben.kao@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "Nyman, Mathias" <mathias.nyman@intel.com>,
        "mathias.nyman@linux.intel.com" <mathias.nyman@linux.intel.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI
 controller
Thread-Topic: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI
 controller
Thread-Index: AQHYlep6vaZ50mhoxUKHlbsi92rDL616roiAgALW96A=
Date:   Thu, 14 Jul 2022 09:06:44 +0000
Message-ID: <SN6PR11MB32930FD21F5C00DB8A8429A0ED889@SN6PR11MB3293.namprd11.prod.outlook.com>
References: <20220712122442.22504-1-ben.kao@intel.com>
 <Ys1sxRT0i/NXSui7@kroah.com>
In-Reply-To: <Ys1sxRT0i/NXSui7@kroah.com>
Accept-Language: zh-TW, en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.6.500.17
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KS7agkhP6w3xypqVQ18jlDK/3jwE9QaHn2KjZy8hPJEUQ31laJ/UiZBDw4Vz?=
 =?us-ascii?Q?wsbUJPBOOZurrzIvEgpI0oGQFuwIAnOfPIX6kMFMHh6GYFlTMgZ/d+RrLAHu?=
 =?us-ascii?Q?ip3uuIJLkzHoCfIXaZxzNEYlA2aER7rdhv/2NNz4up4E+p1z6Dz4jNhSz/9G?=
 =?us-ascii?Q?+kTMbKIH7DVi4FNRiALXD8tQ8Hv2n5izbgrkh68sHy40fcH7bZ1EE821PZXd?=
 =?us-ascii?Q?LhsmNFqkP2MphO/+cmcYAShkfBiduYVRMvixvx0OT2jsmDsdt1ailHWtcTzw?=
 =?us-ascii?Q?MaK8v/I3Q4Er2kNbTdslk2mtpNm7KnjqQbcqUf+HCe9372ObUIkXl6FJLQty?=
 =?us-ascii?Q?qCMQXQueuysZOFsMumyndKc/EcuY9kXxe+Hv7bS10t0/2l7jVglE6wA+TjTs?=
 =?us-ascii?Q?mqoO4ZUrBp2DzC4IbwVui75u7ZyZksW9HuBEG8Zh6vr1D1D6rl663FYlPgfB?=
 =?us-ascii?Q?Hk2rHvd2gL958fOIeqFcQ0AMB26bZ/w1Ylude3xz7Gg+g5qYhXotiq1fmoD3?=
 =?us-ascii?Q?Mlimv3wjfhIIbeyYiIPxnjZPXOlzGnYu0dZWDinEoZj6EDM6uZesgkiV8srC?=
 =?us-ascii?Q?gjsTwM8+asjNOz32pRPpfwv9A/3IbL7GpYevjsd7+i27naPi1+k3Jgum95K5?=
 =?us-ascii?Q?AYGxd9sPdj9ZHSngvFDHPl/iCHEDNF2X9BBUnRDucN5Ywjy5lQEgaOtaIBYg?=
 =?us-ascii?Q?IeV61+H1CjIQnX0eRGhwVS5VKHZPygclThcDnLJnpnTXuc9qxAWOlxw9ZmMV?=
 =?us-ascii?Q?VAOJjWv43t4JDKn4U9OLXTauLlsFeH/VhRc+GwCXK3r3TmQvqqQU6HYoccMn?=
 =?us-ascii?Q?a7YqCyLDRhEAfZ8BrS/HEbYCxgZh/ZLAHnk5maCPo+z+Ox/WdD4dGIOoePEu?=
 =?us-ascii?Q?Gbb5iuGw+JgQsRyKw5FC584T942dO3cdAQoB4vTaI5juNcyzDoLntCC6EkQ9?=
 =?us-ascii?Q?nyLpkT05ifBi8xQgJn2jutakQHLlREAoHkKsxyg+Bmn2iy3oxK1vWdU1AIlw?=
 =?us-ascii?Q?FvFEG473sM9S4Uqw+dZKq0etm92yBQ48A1O1pq5a5kph0UDgt+iOdrizO7Ov?=
 =?us-ascii?Q?O/+O/TWu1pl6mz4ffzAenWts1QACMRPl2BYfuoOd+VUeVOSOokeLpnG5FohS?=
 =?us-ascii?Q?6GrMFBANWxvWlB1lrKzrgMjSPlPQKztkgiw3vXE9PiYs7M/BCelpHKP6bpAV?=
 =?us-ascii?Q?zbEmruStrKsV8cyqlDyFKTZrdd1EqifRZvGhZhLQhIX3VF8HCy6ai+FzIZ8Z?=
 =?us-ascii?Q?7vIjgZ3w0BkjwzbjDOmCMEVlRIHsPR57Hgoq8cvDZC0vPKK/FBhIx3HKk6a1?=
 =?us-ascii?Q?IYPHOvU17IwfZeHaXXUSLkJu9mWcPDVnbfCBKer5H+OMcrEK3P7E9zXBCVJQ?=
 =?us-ascii?Q?IuIX4veeuf27jNA55v3tnHhU3rZKjFUeKxR99wnY78rLGiDb34AeIDO7kcyR?=
 =?us-ascii?Q?ZJsb9zgsptMS+NLVIolQ7brsBQFtBhiNVxwMp6ZQ+O0kpl/Rt+ZppMveA6Rq?=
 =?us-ascii?Q?Yj/6k0BcPKFAbK0uzWE6SmfFHiiw6tHhz7n8m9hmo5kUHwmO6zSLt5iajs+8?=
 =?us-ascii?Q?lw4+VtalxHvcTkTBHIo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3293.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88416e0c-c7ca-4dc0-a7d3-08da65782c79
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 09:06:44.2841
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V/jvAkGPS8Vr+JY0P1WpTv3n0K4/jE7b5CfaiHMuWz9GqOejdvA8nH7vdHpIdp8Qd3GlDSwM+t/XlSGJsgQP0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1931
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Tuesday, July 12, 2022 8:45 PM
> To: Kao, Ben <ben.kao@intel.com>
> Cc: Nyman, Mathias <mathias.nyman@intel.com>;
> mathias.nyman@linux.intel.com; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] xhci-pci: Enable runtime PM on Alder Lake-N PCH xHCI
> controller
>=20
> On Tue, Jul 12, 2022 at 08:24:42PM +0800, Ben Kao wrote:
> > There are two Alder Lake-N xHCI host controllers with PCI IDs 0x464e
> > and 0x54ed, now we add the quirk to default enable runtime PM for
> > 0x54ed.
> >
> > Signed-off-by: Ben Kao <ben.kao@intel.com>
> > ---
> >  drivers/usb/host/xhci-pci.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> > index dce6c0ec8d34..44486156bd5d 100644
> > --- a/drivers/usb/host/xhci-pci.c
> > +++ b/drivers/usb/host/xhci-pci.c
> > @@ -61,6 +61,7 @@
> >  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_XHCI		0x461e
> >  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_XHCI
> 	0x464e
> >  #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI	0x51ed
> > +#define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI	0x54ed
>=20
> I think we ask this every time, but why don't we enable this for all devi=
ces
> and then only disable it for the tiny number that don't need it?
Got it, I will provide another patch to enable runtime PM by default for al=
l
Intel devices if no one has concerns.

>=20
> Why do you all force us to add this for every new device created?
>=20
> thanks,
>=20
> greg k-h