Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: Re: [PATCH v3 4/5] phy: Add ARTPEC-8 PCIe PHY driver
Reply-To: wangseok.lee@samsung.com
Sender: Wangseok Lee <wangseok.lee@samsung.com>
From:   Wangseok Lee <wangseok.lee@samsung.com>
To:     Vinod Koul <vkoul@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzk+dt@kernel.org" <krzk+dt@kernel.org>,
        "kishon@ti.com" <kishon@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
        "lars.persson@axis.com" <lars.persson@axis.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "kw@linux.com" <kw@linux.com>,
        "linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
        "kernel@axis.com" <kernel@axis.com>,
        Moon-Ki Jun <moonki.jun@samsung.com>,
        Sang Min Kim <hypmean.kim@samsung.com>,
        Dongjin Yang <dj76.yang@samsung.com>,
        Yeeun Kim <yeeun119.kim@samsung.com>
In-Reply-To: <YsW9m6hotDKacXe3@matsya>
Message-ID: <20220714095955epcms2p5f5e9a3123a368069b5c661cdeb70485e@epcms2p5>
Date:   Thu, 14 Jul 2022 18:59:55 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <YsW9m6hotDKacXe3@matsya> <YsPYc3YPuG56yTYM@matsya>
        <20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7>
        <20220614013446epcms2p8c88ea65da49447f72fef6536c7f73fb6@epcms2p8>
        <20220706081036epcms2p6baf1d8afac994cd0d45c5e59029c8ce7@epcms2p6>
        <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5>
Precedence: bulk

On=C2=A007-07-22,=C2=A001:52,=C2=A0Vinod=20Koul=C2=A0wrote:=0D=0A>=20On=C2=
=A006-07-22,=C2=A017:10,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote:=0D=0A>>=C2=A0On=
=C2=A005-07-22,=C2=A015:30,=C2=A0Vinod=C2=A0Koul=C2=A0wrote:=0D=0A>>=C2=A0>=
=C2=A0On=C2=A014-06-22,=C2=A010:34,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote:=0D=
=0A>>=C2=A0>>=C2=A0Add=C2=A0support=C2=A0Axis,=C2=A0ARTPEC-8=C2=A0SoC.=0D=
=0A>>=C2=A0>>=C2=A0ARTPEC-8=C2=A0is=C2=A0the=C2=A0SoC=C2=A0platform=C2=A0of=
=C2=A0Axis=C2=A0Communications.=0D=0A>>=C2=A0>>=C2=A0This=C2=A0is=C2=A0base=
d=C2=A0on=C2=A0arm64=C2=A0and=C2=A0support=C2=A0GEN4=C2=A0&=C2=A02lane.=0D=
=0A>>=C2=A0>>=C2=A0This=C2=A0driver=C2=A0provides=C2=A0PHY=C2=A0interface=
=C2=A0for=C2=A0ARTPEC-8=C2=A0SoC=C2=A0PCIe=C2=A0controller,=0D=0A>>=C2=A0>>=
=C2=A0based=C2=A0on=C2=A0Samsung=C2=A0PCIe=C2=A0PHY=C2=A0IP.=0D=0A>>=C2=A0>=
>=C2=A0=0D=0A>>=C2=A0>>=C2=A0Signed-off-by:=C2=A0Wangseok=C2=A0Lee=C2=A0<wa=
ngseok.lee=40samsung.com>=0D=0A>>=C2=A0>>=C2=A0Signed-off-by:=C2=A0Jaeho=C2=
=A0Cho=C2=A0<jaeho79.cho=40samsung.com>=0D=0A>>=C2=A0>>=C2=A0---=0D=0A>>=C2=
=A0>>=C2=A0v2->v3=C2=A0:=0D=0A>>=C2=A0>>=C2=A0-remove=C2=A0unnecessary=C2=
=A0indentation=0D=0A>>=C2=A0>>=C2=A0-redefine=C2=A0local=C2=A0struct=C2=A0t=
o=C2=A0statis=C2=A0const=0D=0A>>=C2=A0>>=C2=A0-add=C2=A0static=C2=A0const=
=C2=A0to=C2=A0struct=C2=A0that=C2=A0requires=C2=A0static=C2=A0const=C2=A0de=
finition=0D=0A>>=C2=A0>>=C2=A0-remove=C2=A0wrappers=C2=A0on=C2=A0writel=C2=
=A0and=C2=A0readl=0D=0A>>=C2=A0>>=C2=A0=0D=0A>>=C2=A0>>=C2=A0v1->v2=C2=A0:=
=0D=0A>>=C2=A0>>=C2=A0-change=C2=A0folder=C2=A0name=C2=A0of=C2=A0phy=C2=A0d=
river=C2=A0to=C2=A0axis=C2=A0from=C2=A0artpec=0D=0A>>=C2=A0>>=C2=A0---=0D=
=0A>>=C2=A0>>=C2=A0=C2=A0drivers/phy/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=7C=
=C2=A0=C2=A0=C2=A01=C2=A0+=0D=0A>>=C2=A0>>=C2=A0=C2=A0drivers/phy/Makefile=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=7C=C2=A0=C2=A0=C2=A01=C2=A0+=0D=0A>>=C2=A0>>=C2=A0=C2=
=A0drivers/phy/axis/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=7C=C2=A0=C2=A0=C2=A09=C2=A0+=0D=0A>>=C2=A0>>=C2=A0=
=C2=A0drivers/phy/axis/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=7C=C2=A0=C2=A0=C2=A02=C2=A0+=0D=0A>>=C2=A0>>=C2=A0=
=C2=A0drivers/phy/axis/phy-artpec8-pcie.c=C2=A0=7C=C2=A0776=C2=A0++++++++++=
++++++++++++++++++++++++++=0D=0A>>=C2=A0>>=C2=A0=C2=A05=C2=A0files=C2=A0cha=
nged,=C2=A0789=C2=A0insertions(+)=0D=0A>>=C2=A0>>=C2=A0=C2=A0create=C2=A0mo=
de=C2=A0100644=C2=A0drivers/phy/axis/Kconfig=0D=0A>>=C2=A0>>=C2=A0=C2=A0cre=
ate=C2=A0mode=C2=A0100644=C2=A0drivers/phy/axis/Makefile=0D=0A>>=C2=A0>>=C2=
=A0=C2=A0create=C2=A0mode=C2=A0100644=C2=A0drivers/phy/axis/phy-artpec8-pci=
e.c=0D=0A>>=C2=A0>>=C2=A0=0D=0A>>=C2=A0>>=C2=A0diff=C2=A0--git=C2=A0a/drive=
rs/phy/Kconfig=C2=A0b/drivers/phy/Kconfig=0D=0A>>=C2=A0>>=C2=A0index=C2=A03=
00b0f2..92b8232=C2=A0100644=0D=0A>>=C2=A0>>=C2=A0---=C2=A0a/drivers/phy/Kco=
nfig=0D=0A>>=C2=A0>>=C2=A0+++=C2=A0b/drivers/phy/Kconfig=0D=0A>>=C2=A0>>=C2=
=A0=40=40=C2=A0-73,6=C2=A0+73,7=C2=A0=40=40=C2=A0config=C2=A0PHY_CAN_TRANSC=
EIVER=0D=0A>>=C2=A0>>=C2=A0=C2=A0=0D=0A>>=C2=A0>>=C2=A0=C2=A0source=C2=A0=
=22drivers/phy/allwinner/Kconfig=22=0D=0A>>=C2=A0>>=C2=A0=C2=A0source=C2=A0=
=22drivers/phy/amlogic/Kconfig=22=0D=0A>>=C2=A0>>=C2=A0+source=C2=A0=22driv=
ers/phy/axis/Kconfig=22=0D=0A>>=C2=A0>>=C2=A0=C2=A0source=C2=A0=22drivers/p=
hy/broadcom/Kconfig=22=0D=0A>>=C2=A0>>=C2=A0=C2=A0source=C2=A0=22drivers/ph=
y/cadence/Kconfig=22=0D=0A>>=C2=A0>>=C2=A0=C2=A0source=C2=A0=22drivers/phy/=
freescale/Kconfig=22=0D=0A>>=C2=A0>>=C2=A0diff=C2=A0--git=C2=A0a/drivers/ph=
y/Makefile=C2=A0b/drivers/phy/Makefile=0D=0A>>=C2=A0>>=C2=A0index=C2=A001e9=
eff..808c055e=C2=A0100644=0D=0A>>=C2=A0>>=C2=A0---=C2=A0a/drivers/phy/Makef=
ile=0D=0A>>=C2=A0>>=C2=A0+++=C2=A0b/drivers/phy/Makefile=0D=0A>>=C2=A0>>=C2=
=A0=40=40=C2=A0-12,6=C2=A0+12,7=C2=A0=40=40=C2=A0obj-=24(CONFIG_PHY_PISTACH=
IO_USB)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0+=3D=C2=A0phy-pistachio-usb.o=0D=0A>>=C2=A0>>=
=C2=A0=C2=A0obj-=24(CONFIG_USB_LGM_PHY)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0+=3D=C2=A0phy-l=
gm-usb.o=0D=0A>>=C2=A0>>=C2=A0=C2=A0obj-y=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0+=3D=C2=A0allwinne=
r/=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=5C=0D=0A>>=C2=A0>>=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0amlogic/=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=5C=0D=0A>>=C2=A0>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0axis/=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=5C=0D=0A>>=C2=A0>>=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0broadcom/=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=5C=0D=0A>>=C2=A0>>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cad=
ence/=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=5C=0D=0A>>=C2=A0>>=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0freescale/=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=5C=0D=0A>>=C2=A0>>=C2=A0diff=C2=A0--git=C2=A0a/=
drivers/phy/axis/Kconfig=C2=A0b/drivers/phy/axis/Kconfig=0D=0A>>=C2=A0>>=C2=
=A0new=C2=A0file=C2=A0mode=C2=A0100644=0D=0A>>=C2=A0>>=C2=A0index=C2=A00000=
000..7198b93=0D=0A>>=C2=A0>>=C2=A0---=C2=A0/dev/null=0D=0A>>=C2=A0>>=C2=A0+=
++=C2=A0b/drivers/phy/axis/Kconfig=0D=0A>>=C2=A0>>=C2=A0=40=40=C2=A0-0,0=C2=
=A0+1,9=C2=A0=40=40=0D=0A>>=C2=A0>>=C2=A0+config=C2=A0PHY_ARTPEC8_PCIE=0D=
=0A>>=C2=A0>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bool=C2=
=A0=22ARTPEC-8=C2=A0PCIe=C2=A0PHY=C2=A0driver=22=0D=0A>>=C2=A0>>=C2=A0+=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0depends=C2=A0on=C2=A0OF=C2=A0&=
&=C2=A0(ARCH_ARTPEC8=C2=A0=7C=7C=C2=A0COMPILE_TEST)=0D=0A>>=C2=A0>>=C2=A0+=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0select=C2=A0GENERIC_PHY=0D=
=0A>>=C2=A0>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0help=0D=
=0A>>=C2=A0>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0Enable=C2=A0PCIe=C2=A0PHY=C2=A0support=C2=A0for=C2=A0ARTPEC-8=C2=A0So=
C.=0D=0A>>=C2=A0>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0This=C2=A0driver=C2=A0provides=C2=A0PHY=C2=A0interface=C2=A0for=
=C2=A0ARTPEC-8=C2=A0SoC=0D=0A>>=C2=A0>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0PCIe=C2=A0controller.=0D=0A>>=C2=A0>>=C2=
=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0This=C2=A0i=
s=C2=A0based=C2=A0on=C2=A0Samsung=C2=A0PCIe=C2=A0PHY=C2=A0IP.=0D=0A>>=C2=A0=
>=C2=A0=0D=0A>>=C2=A0>=C2=A0How=C2=A0different=C2=A0is=C2=A0it=C2=A0from=C2=
=A0SS=C2=A0IP=C2=A0and=C2=A0why=C2=A0should=C2=A0it=C2=A0not=C2=A0be=C2=A0u=
nder=0D=0A>>=C2=A0>=C2=A0phy/samsung/=C2=A0then?=0D=0A>>=C2=A0>=C2=A0=0D=0A=
>>=C2=A0=0D=0A>>=C2=A0SoC=C2=A0platform=C2=A0is=C2=A0completely=C2=A0differ=
ent=C2=A0from=C2=A0exynos=C2=A0platform=C2=A0and=C2=A0different=C2=A0=0D=0A=
>>=C2=A0from=C2=A0exynos=C2=A0PCIe=C2=A0PHY.=C2=A0So=C2=A0the=C2=A0overall=
=C2=A0sysreg=C2=A0configuration=C2=A0is=C2=A0different=0D=0A>>=C2=A0and=C2=
=A0register=C2=A0map=C2=A0is=C2=A0also=C2=A0different.=C2=A0The=C2=A0reset=
=C2=A0method=C2=A0and=C2=A0type=C2=A0of=C2=A0PHY=C2=A0for=0D=0A>>=C2=A0init=
ialization=C2=A0are=C2=A0different.=C2=A0This=C2=A0is=C2=A0not=C2=A0a=C2=A0=
driver=C2=A0that=C2=A0supports=C2=A0Samsung=0D=0A>>=C2=A0SoC=C2=A0platform,=
=C2=A0but=C2=A0this=C2=A0PHY=C2=A0driver=C2=A0that=C2=A0supports=C2=A0only=
=C2=A0Axis,=C2=A0Artpec-8=0D=0A>>=C2=A0platforms,=C2=A0so=C2=A0it=C2=A0is=
=C2=A0not=C2=A0added=C2=A0to=C2=A0phy/samsung.=0D=0A>=20=0D=0A>=20SoC=C2=A0=
is=C2=A0a=C2=A0moot=C2=A0point.=C2=A0If=C2=A0the=C2=A0IP=C2=A0block=C2=A0is=
=C2=A0same=C2=A0then=C2=A0we=C2=A0should=C2=A0try=C2=A0to=C2=A0reuse=0D=0A>=
=20the=C2=A0existing=C2=A0phy=C2=A0driver,=C2=A0modifications=C2=A0to=C2=A0=
current=C2=A0driver=C2=A0to=C2=A0support=C2=A0your=0D=0A>=20changes=C2=A0sh=
ould=C2=A0be=C2=A0fine...=0D=0A>=20=0D=0A>=20Is=C2=A0that=C2=A0feasible?=0D=
=0A>=20=0D=0A>=20--=C2=A0=0D=0A>=20=7EVinod=0D=0A=0D=0ASorry=20for=20late=
=20reply.=0D=0A=0D=0AAbove=20all,=20the=20IP=20blocks=20of=20phy-exynos-pci=
e.c=20and=20artpec8's=20pcie=20phy=20are=0D=0Adifferent.=20As=20a=20result,=
=20the=20H/W=20architecture=20and=20operation=20sequence=20is=0D=0Avery=20d=
ifferent.=20So=20it=20is=20very=20difficult=20to=20merge=20into=20a=20exyno=
s=20pcie=20file.=0D=0AIf=20possible,=20we=20would=20like=20to=20proceed=20w=
ith=20a=20new=20file.=20Is=20that=20possible?=0D=0A=0D=0ABest=20regards,=0D=
=0AWangseok=20Lee