Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 12:12:07 +0200
From:   Jan Kara <jack@suse.cz>
To:     Xiu Jianfeng <xiujianfeng@huawei.com>
Cc:     akpm@linux-foundation.org, axboe@kernel.dk, neilb@suse.de,
        johannes.thumshirn@wdc.com, jack@suse.cz, willy@infradead.org,
        mgorman@techsingularity.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
Message-ID: <20220714101207.5qh3bfvadqrorerp@quack3>
References: <20220714084147.140324-1-xiujianfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220714084147.140324-1-xiujianfeng@huawei.com>
Precedence: bulk

On Thu 14-07-22 16:41:47, Xiu Jianfeng wrote:
> inode_to_wb_is_valid() is no longer used since commit fe55d563d417
> ("remove inode_congested()"), remove it.
> 
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>

Looks good! Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  include/linux/backing-dev.h | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..f9f14e385582 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -235,18 +235,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
>  	return wb;
>  }
>  
> -/**
> - * inode_to_wb_is_valid - test whether an inode has a wb associated
> - * @inode: inode of interest
> - *
> - * Returns %true if @inode has a wb associated.  May be called without any
> - * locking.
> - */
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> -	return inode->i_wb;
> -}
> -
>  /**
>   * inode_to_wb - determine the wb of an inode
>   * @inode: inode of interest
> @@ -345,11 +333,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
>  	return &bdi->wb;
>  }
>  
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> -	return true;
> -}
> -
>  static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
>  {
>  	return &inode_to_bdi(inode)->wb;
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR