Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 12:56:52 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     sdlyyxy <sdlyyxy@bupt.edu.cn>
Cc:     johan@kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: serial: option: adding support for OPPO R11 diag
 port
Message-ID: <Ys/2dN9ktCirZsd9@kroah.com>
References: <20220714102037.4113889-1-sdlyyxy@bupt.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220714102037.4113889-1-sdlyyxy@bupt.edu.cn>
Precedence: bulk

On Thu, Jul 14, 2022 at 06:20:37PM +0800, sdlyyxy wrote:
> From: Yan Xinyu <sdlyyxy@bupt.edu.cn>
> 
> This patch adds support for OPPO R11 USB diag serial port to option
> driver. This phone uses Qualcomm Snapdragon 660 SoC.
> 
> usb-devices output:
> T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 10 Spd=480 MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> P:  Vendor=22d9 ProdID=276c Rev=04.04
> S:  Manufacturer=OPPO
> S:  Product=SDM660-MTP _SN:09C6BCA7
> S:  SerialNumber=beb2c403
> C:  #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
> I:  If#=0x0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option

I do not think this has an option usb-serial chip in the device, this is
a phone with a debug port instead.

> I:  If#=0x1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=usbfs

What userspace program is bound to this endpoint?

> 
> Signed-off-by: Yan Xinyu <sdlyyxy@bupt.edu.cn>
> ---
>  drivers/usb/serial/option.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index de59fa919540..cf65cb84c3ca 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -573,6 +573,10 @@ static void option_instat_callback(struct urb *urb);
>  #define WETELECOM_PRODUCT_6802			0x6802
>  #define WETELECOM_PRODUCT_WMD300		0x6803
>  
> +/* OPPO products */
> +#define OPPO_VENDOR_ID				0x22d9
> +#define OPPO_PRODUCT_R11			0x276c
> +
>  
>  /* Device flags */
>  
> @@ -2155,6 +2159,7 @@ static const struct usb_device_id option_ids[] = {
>  	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1404, 0xff) },			/* GosunCn GM500 RNDIS */
>  	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1405, 0xff) },			/* GosunCn GM500 MBIM */
>  	{ USB_DEVICE_INTERFACE_CLASS(0x305a, 0x1406, 0xff) },			/* GosunCn GM500 ECM/NCM */
> +	{ USB_DEVICE_AND_INTERFACE_INFO(OPPO_VENDOR_ID, OPPO_PRODUCT_R11, 0xff, 0xff, 0x30) },

This does not look correct, sorry.  Try using the usbserial generic
driver instead to transmit and recieve?

thanks,

greg k-h