Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 14:34:36 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Luca Ellero <luca.ellero@brickedbrain.com>
Cc:     dmitry.torokhov@gmail.com, daniel@zonque.org,
        m.felsch@pengutronix.de, u.kleine-koenig@pengutronix.de,
        mkl@pengutronix.de, miquel.raynal@bootlin.com, imre.deak@nokia.com,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Luca Ellero <l.ellero@asem.it>
Subject: Re: [PATCH 2/3] ads7846: always set last command to PWRDOWN
Message-ID: <Ys//TM5/JuvoEZMo@smile.fi.intel.com>
References: <20220714084319.107334-1-luca.ellero@brickedbrain.com>
 <20220714084319.107334-3-luca.ellero@brickedbrain.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220714084319.107334-3-luca.ellero@brickedbrain.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Thu, Jul 14, 2022 at 10:43:18AM +0200, Luca Ellero wrote:
> From: Luca Ellero <l.ellero@asem.it>
> 
> This was broken on controllers with 3 commands as ads7845.
> READ_Z1 was sent instead.

What is "This"? Please, make commit message more understandable by its own.
With that fixed,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Luca Ellero <l.ellero@asem.it>
> ---
>  drivers/input/touchscreen/ads7846.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
> index 24605c40d039..9e15cdf6faa0 100644
> --- a/drivers/input/touchscreen/ads7846.c
> +++ b/drivers/input/touchscreen/ads7846.c
> @@ -1066,6 +1066,9 @@ static int ads7846_setup_spi_msg(struct ads7846 *ts,
>  		struct ads7846_buf_layout *l = &packet->l[cmd_idx];
>  		unsigned int max_count;
>  
> +		if (cmd_idx == packet->cmds - 1)
> +			cmd_idx = ADS7846_PWDOWN;
> +
>  		if (ads7846_cmd_need_settle(cmd_idx))
>  			max_count = packet->count + packet->count_skip;
>  		else
> @@ -1102,7 +1105,12 @@ static int ads7846_setup_spi_msg(struct ads7846 *ts,
>  
>  	for (cmd_idx = 0; cmd_idx < packet->cmds; cmd_idx++) {
>  		struct ads7846_buf_layout *l = &packet->l[cmd_idx];
> -		u8 cmd = ads7846_get_cmd(cmd_idx, vref);
> +		u8 cmd;
> +
> +		if (cmd_idx == packet->cmds - 1)
> +			cmd_idx = ADS7846_PWDOWN;
> +
> +		cmd = ads7846_get_cmd(cmd_idx, vref);
>  
>  		for (b = 0; b < l->count; b++)
>  			packet->tx[l->offset + b].cmd = cmd;
> -- 
> 2.25.1
> 

-- 
With Best Regards,
Andy Shevchenko