Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <155c77c3-25d9-7edc-35bd-56e6cfb19ac6@amd.com>
Date:   Thu, 14 Jul 2022 13:26:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v14 0/5] clk: clocking-wizard: Driver updates
Content-Language: en-US
To:     Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
        <linux-clk@vger.kernel.org>, git <git@xilinx.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Arnd Bergmann <arnd@arndb.de>
CC:     <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20220411100443.15132-1-shubhrajyoti.datta@xilinx.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20220411100443.15132-1-shubhrajyoti.datta@xilinx.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 11:27:04.6151
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 80fc2ff7-902c-4a0d-8083-08da658bc770
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT047.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0174
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Stephen and Michael,

On 4/11/22 12:04, Shubhrajyoti Datta wrote:
> The patch does the following
> Update the versions of the clocking wizard ip.
> Move from staging to clk directory.
> Update the bindings.
> 
> v12:
> No change.
> Rebased
> v13:
> Update the clocking compatible
> Add the change removing the driver from staging
> v14:
> Moved to the xilinx folder
> 
> Shubhrajyoti Datta (5):
>    dt-bindings: add documentation of xilinx clocking wizard
>    clk: clocking-wizard: Add the clockwizard to clk directory
>    clk: clocking-wizard: Rename nr-outputs to xlnx,nr-outputs
>    clk: clocking-wizard: Fix the reconfig for 5.2
>    clk: clocking-wizard: Update the compatible
> 
>   .../bindings/clock/xlnx,clocking-wizard.yaml  | 77 +++++++++++++++++++
>   drivers/clk/xilinx/Kconfig                    | 11 +++
>   drivers/clk/xilinx/Makefile                   |  1 +
>   .../xilinx}/clk-xlnx-clock-wizard.c           | 19 +++--
>   drivers/staging/Kconfig                       |  2 -
>   drivers/staging/Makefile                      |  1 -
>   drivers/staging/clocking-wizard/Kconfig       | 10 ---
>   drivers/staging/clocking-wizard/Makefile      |  2 -
>   drivers/staging/clocking-wizard/TODO          | 13 ----
>   .../staging/clocking-wizard/dt-binding.txt    | 30 --------
>   10 files changed, 103 insertions(+), 63 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
>   rename drivers/{staging/clocking-wizard => clk/xilinx}/clk-xlnx-clock-wizard.c (96%)
>   delete mode 100644 drivers/staging/clocking-wizard/Kconfig
>   delete mode 100644 drivers/staging/clocking-wizard/Makefile
>   delete mode 100644 drivers/staging/clocking-wizard/TODO
>   delete mode 100644 drivers/staging/clocking-wizard/dt-binding.txt
> 

I was looking at comment in v13 and moving to xilinx folder was done in v14.
v13: https://lore.kernel.org/r/cover.1631623906.git.shubhrajyoti.datta@xilinx.com

dt binding is also reviewed by Rob already.

You asked there to get confirmation from Greg that it can be moved out of 
staging. I didn't see any reply from Greg about it but not sure if this is 
really required to get.
Greg: Can you please ACK it or comment?

And in your v13 reply you said that you will pick it up
https://lore.kernel.org/all/20220112204055.CF098C36AE9@smtp.kernel.org/#t
but I can't see this patch in your linux clk tree yet.

I have also see that some people are sending you pull requests to merge it to 
clock tree. If this is something what you prefer I have really not a problem to 
do it.

Thanks,
Michal