Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp474995imw; Thu, 14 Jul 2022 05:11:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uhmhq75kzaPGjdWJhDblIszr9OR1G+VcK+PttGkxYwhj1qu9K4kRMB7x8MGUEca8HVOnTs X-Received: by 2002:a17:907:8a1d:b0:72b:9e7b:802a with SMTP id sc29-20020a1709078a1d00b0072b9e7b802amr7573021ejc.189.1657800673387; Thu, 14 Jul 2022 05:11:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657800673; cv=none; d=google.com; s=arc-20160816; b=XUYDmDEMyd7tCK8nu0ziIQpA67nFAUYJLdxSXvwl4z/dm6P2MIu/kffO8iFisldSH5 U7nqShnUpXfXxNoRYU9DY5wez8SU+3Bo18GCv5EE0ultQchbcRnou27FmLPhn6/Q0/f0 PL/iYTJHyIcHbGBiDCTzvj42uK5XQhOpBH8lINaBwGhRLHBwauXZxhd59vOorxMmBkPP pEF4RpmTMWdkFvYYqGildrvRXno9D23AEHfj0vf6a660IQlloTOmIFNWEAe4hv7TT53a O3++eghkNDzWMh0adVH4MTFe+DILTWD4N5xolm5mCoGy2thNQoCZWDUVDNiWwI1lxoB0 /TsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:feedback-id :dkim-signature:dkim-signature; bh=b5gmUsLswcM+GqSPANxZXShuD2xhkT0GXvBfBDz9dEo=; b=OmW+El8bIkCSYy6kr63W3D9g6lTazNcTLyOIRB2GUEExDkxzOsjmJPMfLZzZutgStg 655dnELz8AkNFLa3fHa7wJMKi54SLUzufIulJvEymlY3DoFx10DCLV3J8GlebeGSCGeE wDyqbL18ZnXC2/kaXCxGfymcNYYL7AmkdrHZspFsqRbRdnFhNOxrSuqMMwekIVcgWkdB TKjrJAj6z3wxx8zDINa77n/XlovtTaR6RdxehYOuOGL5lEegRXJBEVFmI0zqktRkB7Hv FUq0CBg3L6i7L3yXABEgyplV53Y/6rQ02z7xHtx7Sb9wkrzyHneKcqkzW0L1cpl+BIee EXGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=O58bELvD; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=aJhIEcmA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j19-20020a05640211d300b00435799ce323si2386573edw.190.2022.07.14.05.10.48; Thu, 14 Jul 2022 05:11:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cerno.tech header.s=fm2 header.b=O58bELvD; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=aJhIEcmA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cerno.tech Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238706AbiGNMGV (ORCPT + 99 others); Thu, 14 Jul 2022 08:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238696AbiGNMGS (ORCPT ); Thu, 14 Jul 2022 08:06:18 -0400 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E60615C9CC; Thu, 14 Jul 2022 05:06:14 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 554005C0172; Thu, 14 Jul 2022 08:06:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 14 Jul 2022 08:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657800374; x=1657886774; bh=b5gmUsLswc M+GqSPANxZXShuD2xhkT0GXvBfBDz9dEo=; b=O58bELvDHpaw1FLXNwwEFFKex+ OUE3n//oKnzRiP7dGhkfPd2scMkHWB2LyVWVP/9pRtCBAS3gVnU8mj+/ryqOjnhr GXuUpYBrLna8QpXLPF7Dz7XBlkQ9sFuvx9/A0gLQMyPC9zGd9XSHe24C/TXxqI2G leDhm0sRFr+fqIJzbvmprQRb8xpRN5wHtiYYoVnSs6Xi6aLykRLhHdMDMcZDj9z+ /qFDLlSSfEBhZYMy+3FSYy0K2zsqUsuFtUC3wHNOOq2mIlNR0Cz7TSJsP8jZpAO0 GR1Ytkb4fSOCcg3bBe2n0eX8gFOaWJa/nqkkzIbxL/L/h+ppuJ3VAIc2LhnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657800374; x=1657886774; bh=b5gmUsLswcM+GqSPANxZXShuD2xh kT0GXvBfBDz9dEo=; b=aJhIEcmAXBOFqUJxyJuQIjmvOqHLYTwSEG9RBTKJWT3o 7Sjw/vys0EgZQv5WbA9i4/xkYeQMszi+sFi3BNAYBsh2HsBqwP+10d2ylxjZZibd R168w/NfX55gamugm7X9HTfO/LlEn44dmlnaokZci67vou5r+NofGmKyfP16Qkx5 3ocB9b7M/P2IsEC9uuAQTtMUv5mTNw5cGIHin4w0MpzsUtbIdjd/3vUHJRu50q9d Id/AOxAB6mJA1iIE7egOw8afD6euVPboxkz4F0+wBp04TaueS5YbWIhzv6+XkReS K55cxlfwBA9lAc2im/bcIDn7HyeWTK5z5SEDhOvIGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejledggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeetfefffefgkedtfefgledugfdtjeefjedvtddtkeetieffjedvgfehheff hfevudenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Feedback-ID: i8771445c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Jul 2022 08:06:12 -0400 (EDT) Date: Thu, 14 Jul 2022 14:06:11 +0200 From: Maxime Ripard To: Geert Uytterhoeven Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Hans de Goede , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/5] drm/modes: parse_cmdline: Add support for named modes containing dashes Message-ID: <20220714120611.hpzq2gkxf73hlupw@houat> References: <2eb205da88c3cb19ddf04d167ece4e16a330948b.1657788997.git.geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5owdr3n7gktrcrdt" Content-Disposition: inline In-Reply-To: <2eb205da88c3cb19ddf04d167ece4e16a330948b.1657788997.git.geert@linux-m68k.org> X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5owdr3n7gktrcrdt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 14, 2022 at 11:04:10AM +0200, Geert Uytterhoeven wrote: > It is fairly common for named video modes to contain dashes (e.g. > "tt-mid" on Atari, "dblntsc-ff" on Amiga). Currently such mode names > are not recognized, as the dash is considered to be a separator between > mode name and bpp. >=20 > Fix this by skipping any dashes that are not followed immediately by a > digit when looking for the separator. >=20 > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Hans de Goede Ditto, we should have a test for that Maxime --5owdr3n7gktrcrdt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYtAGswAKCRDj7w1vZxhR xXrWAP9DRGAZ4CDEQwJ0dx/IJwhV3KNEE9cndYaREAlrtTeR4gEA2IHGASXNLZc6 vKDJnEMcDo1+uRYEdLs55KOrwI3LxAA= =fYfY -----END PGP SIGNATURE----- --5owdr3n7gktrcrdt--