Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1bc53dc5-fc7f-54fd-ab7c-f1e77548b20d@quicinc.com>
Date:   Thu, 14 Jul 2022 18:35:17 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [V5] tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which
 otherwise could return a sub-optimal clock rate.
Content-Language: en-CA
To:     Jiri Slaby <jirislaby@kernel.org>, <agross@kernel.org>,
        <bjorn.andersson@linaro.org>, <konrad.dybcio@somainline.org>,
        <gregkh@linuxfoundation.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <quic_msavaliy@quicinc.com>, <dianders@chromium.org>,
        <mka@chromium.org>, <swboyd@chromium.org>
References: <1657629905-24685-1-git-send-email-quic_vnivarth@quicinc.com>
 <b973cfc2-d9a8-5d62-036f-14671cf56799@kernel.org>
From:   Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
In-Reply-To: <b973cfc2-d9a8-5d62-036f-14671cf56799@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/14/2022 4:16 PM, Jiri Slaby wrote:
> On 12. 07. 22, 14:45, Vijaya Krishna Nivarthi wrote:
> ...
>> +static unsigned long get_clk_div_rate(struct clk *clk, struct device 
>> *dev,
>> +        unsigned int baud, unsigned int sampling_rate, unsigned int 
>> *clk_div)
>> +{
>> +    unsigned long ser_clk;
>> +    unsigned long desired_clk;
>> +
>> +    desired_clk = baud * sampling_rate;
>> +    if (!desired_clk) {
>> +        dev_dbg(dev, "Invalid frequency\n");
>> +        return 0;
>>       }
>>   -    *clk_div = ser_clk / desired_clk;
>> -    if (!(*clk_div))
>> -        *clk_div = 1;
>> +    /*
>> +     * try to find a clock rate within 2% tolerance, then within
>
> "then within" ... "5" is missing, perhaps?


Yes :(

Will change.


>
>> +     */
>> +    ser_clk = find_clk_rate_in_tol(clk, desired_clk, clk_div, 2);
>> +    if (!ser_clk)
>> +        ser_clk = find_clk_rate_in_tol(clk, desired_clk, clk_div, 5);
>> +
>> +    if (!ser_clk)
>> +        dev_err(dev, "Couldn't find suitable clock rate for %lu\n", 
>> desired_clk);
>> +    else
>> +        dev_dbg(dev, "desired_clk-%lu, ser_clk-%lu, clk_div-%u\n",
>> +                desired_clk, ser_clk, *clk_div);
>>         return ser_clk;
>>   }
>> @@ -1021,8 +1040,8 @@ static void qcom_geni_serial_set_termios(struct 
>> uart_port *uport,
>>       if (ver >= QUP_SE_VERSION_2_5)
>>           sampling_rate /= 2;
>>   -    clk_rate = get_clk_div_rate(port->se.clk, baud,
>> -        sampling_rate, &clk_div);
>> +    clk_rate = get_clk_div_rate(port->se.clk, port->se.dev, baud,
>
> Maybe worth passing whole geni_se (port->se) then?


but then geni_se is a struct; shall we pass port instead?

Alternately move logging to caller?

Thank you.


>
>> +                    sampling_rate, &clk_div);
>>       if (!clk_rate)
>>           goto out_restart_rx;
>
> thanks,