Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ca27cee-eda0-0a65-f972-c69cc3b3e53e@amd.com>
Date:   Thu, 14 Jul 2022 10:14:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v1] drm/scheduler: Don't kill jobs in interrupt context
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Alex Deucher <alexdeucher@gmail.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc:     Erico Nunes <nunes.erico@gmail.com>,
        Steven Price <steven.price@arm.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        David Airlie <airlied@linux.ie>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
        Dmitry Osipenko <digetx@gmail.com>
References: <20220411221536.283312-1-dmitry.osipenko@collabora.com>
 <a78343c8-2a6d-b223-4219-6b6b0a4fcb1f@arm.com>
 <CAK4VdL2hCEoshWZbCh5mkHuS6wYMiPFR3v4MWTnrEKM9zyv6Mw@mail.gmail.com>
 <ef88ec2c-77b5-fa0d-49d1-fdd2451713b7@collabora.com>
 <573fae0d-c9ab-98b0-c6f1-5b0d4e52dd01@amd.com>
 <a33ab7b9-738f-db91-f6ba-78a9641365e8@amd.com>
 <b05f9861-1966-72f5-132b-aebb4b6e0c6b@collabora.com>
 <107fe968-8311-0511-cc31-22feb994a6d7@collabora.com>
 <3e07a8d0-2cbc-8f3e-8f9f-5b73fb82028b@amd.com>
 <CADnq5_MMmeWkiMxjYfrG7pip8BEkbkRc8ADUDLEi++kRF76sqg@mail.gmail.com>
 <bff42c98-045d-2e5a-2cf9-eb563425375e@collabora.com>
 <6e0c7590-6ffb-162b-a98d-0a39333453f6@collabora.com>
From:   Andrey Grodzovsky <andrey.grodzovsky@amd.com>
In-Reply-To: <6e0c7590-6ffb-162b-a98d-0a39333453f6@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk1nYTdIdjBYNUxYOEJkdEYyUHJBVEh5NktXb3BIemUwZXMwQUR2TU5sQXFG?=
 =?utf-8?B?WmpWVzZjbFVKTk8rSzBBeVFETmx5Znl4TU1xcTd5OE1EeEpsZEFjU1lwVkQ1?=
 =?utf-8?B?bXZScDhDTUROSEVhdVZrYTdjR1Y5TDh4d2V3N2x1cWg0aWpIaDFBUDJzSmx6?=
 =?utf-8?B?T1dYdHhsZHRlMktWQWFIL2NhbS9vRTRyNlZ2SXNyWkE0cDZFR296ODNsM3U3?=
 =?utf-8?B?T0VNL3ZGZGkvN1M4ZWVsaVk5S2lBVHMzUm1CWE9Rb1g1ejUyMEtsTTg3OFdk?=
 =?utf-8?B?UmRRWmU1WDdhME5RaUgzOHpYVG5XMnQvYmxpWlNwc1Y4TnUzUVlCR3hrZC9N?=
 =?utf-8?B?eENPamxpa1BZVWd1amRJbWZRVGRRWWQ2cDlSbmhSZUE1SUdUaWtZendIRFdF?=
 =?utf-8?B?L2Y2bm1JTTU5SEpYWW1LUzBXUDUrRUo1V0dhUjJ4Z0tqMzI4Si8vdzBXQ3BU?=
 =?utf-8?B?RFJuQi9jS0s4TkhML0V4U1BXQWQ2TXFVMDlJOGs2S05tSjVqVEl2UU5aQUdC?=
 =?utf-8?B?cVd5WkxGb0FDQmQ2R0dNMU5FQnV5YklWcUdiUE9xR1FabnI4S3ozS1Q5NHRB?=
 =?utf-8?B?UjVLcEhxaFVacnlwVnRsRGNVQUJkUm9jUXAyekZRaVZXKzRaUkd0K2IvYUcz?=
 =?utf-8?B?ejhNd3BpZkhKL3k4NEhaZmpES0VPVHBnR2prd3diaDZaRDM0eE11ZTVFNDdP?=
 =?utf-8?B?UXZEdTRWOVlpazFWMDJac0JtYTROY2lTL2h5Z3p3cmhxakRSQjBvUFRhVmhF?=
 =?utf-8?B?NlE3Z2FkSzVLUFRkdnVaRTV4ckphdFh3M0FacWNVKzAxNDB5enA4RmlhZzly?=
 =?utf-8?B?YklxaEZ6U0pJU1IxUHVQT3RWU2NvaGhCNy9tdlJGTUtyVzg2aFA2QUtVQ0Fn?=
 =?utf-8?B?NXBEU3pDUStjYUEzd1k2T1Nib3l2TmpHZGdLTnFCUTcralNwWnRjU1dEOVVr?=
 =?utf-8?B?QjF5Z0Q5dGJGek9OV2JxaUNuSHd0SmNwSElVV3Z5UUpHQ0JNeC9tSXBKUFRZ?=
 =?utf-8?B?enZEdUtjU2lCdW5ZT2Y1c0Vla1dGT2FlaFJBTjQ4VTF6ZDNZeW5Wb0ZzTDN0?=
 =?utf-8?B?bU5uN3pQRmt4RTJ1YXdVMXZSSHZnZFAxejc5NXJodkJjaVJqamZMeG5uYkdl?=
 =?utf-8?B?NEovYkw3QjYzVVE5MFA2UDE0YUtIQ0dubVIvVUJFTHNmM3hoS1pmVU4ySzN0?=
 =?utf-8?B?Z2J1T3ZhT1o1SG1SYmp2clpqMk9aSmx6SGRWaW8vVSsycTNmejhJeTQrOVpD?=
 =?utf-8?B?a0pZYkJ0YWlSN0tBNmdSdVRKMTh2cnZZUHl1NWZZTVcwYldnckxLelFCczhU?=
 =?utf-8?B?S2N1d3d6RU53aXl6RXQ1WXNEUVR1aSs3WmducDNnMS9GMDliWE5iSm5WeDZ3?=
 =?utf-8?B?WXFZTUZxSWJzVXVuS0ZIam5QNmtVVkJLMGs0TkUyclhGUzFOVHpWSklxWWhi?=
 =?utf-8?B?ZGJMRkxWQU5sSmNqTWVUY2ROeUpRcEtIUEcydWt6R1FnTVo3Y1Jqem5ldWZF?=
 =?utf-8?B?eFphZ3pvaUFrZ3czaTBvN2JpOU5Ea0EwQkJMYUNzWXMwUEtTNVJGQlJzY0Q4?=
 =?utf-8?B?WHVWRUR0UjFyUUhkM0tWbVlkeTFQZjk2QzNreGF6T3N1ZVJEN1YxZWROZTdr?=
 =?utf-8?B?Y1A4RHlsY2JlODZ4VmEwdmlqMjlHR3V2KzhQS013bHh2bUNUUncvL3d5V09L?=
 =?utf-8?B?alpGUmdBOUI1QWMxTjdRd3VaNW5uSnFUM0hIclV1c0o4eDRvQXpCRlpwb3h5?=
 =?utf-8?B?enJwWlFOVUJUczk5UmZubkNqckt2S0M2blVvNVFMdnBYLzJBam5VZDJtRzdT?=
 =?utf-8?B?b2dUelRRODBJRUYzbk5FQ3hKdktra05ISUY2VHRKZVZxaHBKOXRWZWIrOS9L?=
 =?utf-8?B?YmtudFk1eVpPLzBsZ0llWGgzcmMwa1hBU1cyT1FveDd3N2Zzd3B1T1JqZ0NN?=
 =?utf-8?B?Y29RNU5pc1NDYjRwMVdtRGFRV1NobStGTHN4ZTUycXN3dDR5SU92ZXpTRmR0?=
 =?utf-8?B?VzBtc1FCcTZLUmtzTmthbnlpVDEzWjBoNUU0ZERISG5iM2plWGJoWWd1M1k5?=
 =?utf-8?B?WmRTTkw0MFdxQ2tPOFVDYkdoTGNvQWxsRVdtQ0dyc2poejZxeGFYaXpjODJH?=
 =?utf-8?B?SkVwQ0tIL3BpTTlNWHJtenIyVkt2MThUZi9EMUJSNXdaV2xkeTVRSmdxTjJK?=
 =?utf-8?Q?RX3csy/l1Ai0Zw6esv+b95p0pdMbK0dB5epPLFj5VYqO?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c797226-36ad-4af6-1416-08da65a31a53
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1947.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 14:14:02.4573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E0wKIdW1IBWQHzhpiABFhhMoFh+3RJgxq/8wXvLwxeN5X8yDKr9XMJX91auKgyoINKTutKlCa9sKxdngayEnhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1924
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-07-14 05:57, Dmitry Osipenko wrote:
> On 7/12/22 11:56, Dmitry Osipenko wrote:
>> On 7/6/22 18:46, Alex Deucher wrote:
>>> On Wed, Jul 6, 2022 at 9:49 AM Andrey Grodzovsky
>>> <andrey.grodzovsky@amd.com> wrote:
>>>> On 2022-07-06 03:07, Dmitry Osipenko wrote:
>>>>
>>>>> Hello Andrey,
>>>>>
>>>>> On 5/17/22 17:48, Dmitry Osipenko wrote:
>>>>>> On 5/17/22 17:13, Andrey Grodzovsky wrote:
>>>>>>> Done.
>>>>>>>
>>>>>>> Andrey
>>>>>> Awesome, thank you!
>>>>>>
>>>>> Given that this drm-scheduler issue needs to be fixed in the 5.19-RC and
>>>>> earlier, shouldn't it be in the drm-fixes and not in drm-next?
>>>>
>>>> I pushed it into drm-misc from where it got into drm-next. I don't have
>>>> permission for drm-fixes.
>>> The -fixes branch of drm-misc.
>> Now I don't see the scheduler bugfix neither in the -fixes branch nor in
>> the -next and today Dave sent out 5.19-rc7 pull request without the
>> scheduler fix. Could anyone please check what is going on with the DRM
>> patches? Thanks!
>>
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffreedesktop%2Fdrm-misc%2Fcommits%2Fdrm-misc-fixes&amp;data=05%7C01%7Candrey.grodzovsky%40amd.com%7C68b627b8482a4fd28a5608da657f4375%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637933894551324163%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=CDdLG%2F7SqCudEnjhBSsXqq15mfhlHlS3xAdAfB%2Bh%2F1s%3D&amp;reserved=0
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fdrm%2Fdrm-misc%2Flog%2F%3Fh%3Ddrm-misc-fixes&amp;data=05%7C01%7Candrey.grodzovsky%40amd.com%7C68b627b8482a4fd28a5608da657f4375%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637933894551324163%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=4Vz40j6F%2FzHYckXEyPEunj9DRSoTXikhNxZDXeocTss%3D&amp;reserved=0
> The patch is in the drm-misc-next-fixes, so it wasn't moved to the
> drm-misc-fixes.
>
> Andrey, don't you have access to drm-misc-fixes? Or you meant
> drm-fixes=drm-misc-fixes?


I have only accesses to drm-misc-next to which I pushed this patch.

Andrey


>