Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5afd3b45e9b95fa5023790c24f8a1b0b4ce1ca7c.camel@decadent.org.uk>
Subject: Re: [PATCH v2 0/5] tools: fix compilation failure caused by
 init_disassemble_info API changes
From:   Ben Hutchings <ben@decadent.org.uk>
To:     sedat.dilek@gmail.com, Andres Freund <andres@anarazel.de>
Cc:     bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Quentin Monnet <quentin@isovalent.com>
Date:   Thu, 14 Jul 2022 15:25:44 +0200
In-Reply-To: <CA+icZUVDzogiyG=8sCuxdW4aaby_kRwToit2tg-A4D3VorVKnA@mail.gmail.com>
References: <20220622231624.t63bkmkzphqvh3kx@alap3.anarazel.de>
         <20220703212551.1114923-1-andres@anarazel.de>
         <CA+icZUVDzogiyG=8sCuxdW4aaby_kRwToit2tg-A4D3VorVKnA@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-OgXkSgMMXMfCDQQ6En6D"
User-Agent: Evolution 3.44.2-1 
MIME-Version: 1.0
Precedence: bulk


--=-OgXkSgMMXMfCDQQ6En6D
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2022-07-14 at 11:16 +0200, Sedat Dilek wrote:
> On Sun, Jul 3, 2022 at 11:25 PM Andres Freund <andres@anarazel.de> wrote:
> >=20
> > binutils changed the signature of init_disassemble_info(), which now ca=
uses
> > compilation failures for tools/{perf,bpf} on e.g. debian unstable. Rele=
vant
> > binutils commit:
> > https://sourceware.org/git/?p=3Dbinutils-gdb.git;a=3Dcommit;h=3D60a3da0=
0bd5407f07
> >=20
> > I first fixed this without introducing the compat header, as suggested =
by
> > Quentin, but I thought the amount of repeated boilerplate was a bit too
> > much. So instead I introduced a compat header to wrap the API changes. =
Even
> > tools/bpf/bpftool/jit_disasm.c, which needs its own callbacks for json,=
 imo
> > looks nicer this way.
> >=20
> > I'm not regular contributor, so it very well might be my procedures are=
 a
> > bit off...
> >=20
> > I am not sure I added the right [number of] people to CC?
> >=20
> > WRT the feature test: Not sure what the point of the -DPACKAGE=3D'"perf=
"' is,
> > nor why tools/perf/Makefile.config sets some LDFLAGS/CFLAGS that are al=
so
> > in feature/Makefile and why -ldl isn't needed in the other places. But.=
..
> >=20
> > V2:
> > - split patches further, so that tools/bpf and tools/perf part are enti=
rely
> >   separate
> > - included a bit more information about tests I did in commit messages
> > - add a maybe_unused to fprintf_json_styled's style argument
> >=20
>=20
> [ CC Ben ]
>=20
> The Debian kernel-team has integrated your patchset v2.
>=20
> In case you build without libbfd support there is [1].
> So, feel free to take this for v3.
>=20
> -Sedat-
>=20
> [1] https://salsa.debian.org/kernel-team/linux/-/blob/sid/debian/patches/=
bugfix/all/tools-perf-fix-build-without-libbfd.patch
[...]

Thanks, I meant to send that fix upstream but got distracted.  It
should really be folded into "tools perf: Fix compilation error with
new binutils".

Ben.
>=20

--=20
Ben Hutchings
Always try to do things in chronological order;
it's less confusing that way.

--=-OgXkSgMMXMfCDQQ6En6D
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAmLQGVgACgkQ57/I7JWG
EQnUjBAAk2XI7hNjRozbY7yy+c7k2alNVHWewYw9eUYYJ/2tSIMWsZuerXn0V7iT
iUEDDd2CVlSSWiSrUHOHimsNjfsDlUtQ+Ev4pc+D83czOWFibs3n4qfixLsE2MFM
dUXatRQVLgYCJzAvEZnsRK1rAMAbwhh6F1lZGPu+qBN10qDbUOIUnzpEcv4KOhb4
yLEG1dLHNTO1L2N11xkG2OyDQTUhZxUetEwvmV7LikaA8zXfEpF2O1DNFVdgw3zI
T0TzpQEvxaPgEcGd2PxFH034gNajsq9WkkiTdXBSGAF0XRkgPQP+LKoQKFc7RkGj
E01IFeR+DuJVgf6J0YlrQYM23TuJOz4VKVjbbLUFgRqeBC5CQTKvE79jbQSmDZhm
7QPfcOyRMAJ/FeGDuo8gn9S+9iIWJN8lJ+2RXMv0oT2wvyVF7C292mhAUecz5pmy
Q/50PBWq3DCDEW8ILlWxqOBI7HeboygjznfEbubJtom13HYCwETUYjxIUdL/duLH
6/MoktNcrC8XXCttBaFdLO9Ylp7z1w2hDB4+6Trz4y8uitQnJP2hNwxuhsb9clYh
/fAxsXWPL45QAXMsAQMcWy+ciFaO7nEeTqcWgnj3O29htS72HgOkcdKTtNUp0enI
OJrsQpLJlAa/4EbpLjtCPDDmDwrtGhlInE3P7mBhWf3iNuCP7Dk=
=ReGY
-----END PGP SIGNATURE-----

--=-OgXkSgMMXMfCDQQ6En6D--