Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp610514imw; Thu, 14 Jul 2022 07:36:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vT7VCwW1sW5cyV99a69qc8AZfrDRTyyZvdV/naBqdCdSWonyfQ+Vp3eoGjGuXFchnSJQMJ X-Received: by 2002:a05:6402:5513:b0:43a:b866:b9ab with SMTP id fi19-20020a056402551300b0043ab866b9abmr12894613edb.290.1657809398780; Thu, 14 Jul 2022 07:36:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657809398; cv=none; d=google.com; s=arc-20160816; b=h5fCN/+lzNJtS14l20FiLJTMP0yT2zyeXYA3hRWbFRp1EFahf2WEC/3pkDd03ECic1 9twI+3r7RilvQ4mK9Y2WEYhSroFNOVgkFV7YeBf/qT32pizIy22chI9q5E5CtkWnNwNX NEXz+7d08A6aAENhQ7jeVruRec8LXrNx6MxMPXig2yeuqyagzLI0OnFhM+0UG8vQzF2D Kcmd5RpFR4Fp23NmIMi/aJOD44TT408XcphD/I4J4Hl5RgTTMEIpg9XkTl3OOBrbJ+Ew jpvmU0C+XS5SbI5Z4xf3VX0/M+7K/oSBHoYJRJWEYc1MckYpcPLNA5ZulIto9KfyjZ1K 7/5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EWj6H1WZmY1SQPSn1P22Z1GCiev4yo1yYwjuCmvOTfQ=; b=tTauNapz0CY+qwLYwdLV+gZDjT7IlheZT/D96ixbUgL4sdCVBKy1GnsK/jGWJXgkvj kQy643054rNOu6R+qyCY4SasmyQxL3QpIekIugVuIg9Ri/prLIEzbLxAQdgncJpIZhAe foFq0r9ksFzOCs/rm8adLUJBkLLnyofWB1ExzISR/LU7xhX9GZb3AMz3DG08OVhNj9tp E7//TlmTWfU/ry5DFi5cgbAvqNGrQJSf4NKAZ4E7abylZ2KMrqj2+Ke8/Yqr0cV8f1mI Rs7lfmbuwJL9xJHTTFsuZBjWV3nFdmaItH7xxHoPD9WKTSkaYJjibVm6kL+VX5Cl5Vbz CstA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fIGl/Cm8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne35-20020a1709077ba300b00726a62cded2si2807722ejc.554.2022.07.14.07.36.14; Thu, 14 Jul 2022 07:36:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="fIGl/Cm8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240430AbiGNOMr (ORCPT + 99 others); Thu, 14 Jul 2022 10:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232304AbiGNOM1 (ORCPT ); Thu, 14 Jul 2022 10:12:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89A084D82D; Thu, 14 Jul 2022 07:12:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 067A7B823A9; Thu, 14 Jul 2022 14:12:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DE83C34114; Thu, 14 Jul 2022 14:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657807938; bh=mvlJ0wufsEtTo9Dxhf5723LkQmjzyNDzx5teMH2feS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fIGl/Cm8qgB4JLLdsP8ojS41VS2bqdX3a1mPi6QqeLmVXUo/qWZeFMjdB93qjxr05 6i0JdXmd5WGoKQQ+ihQgQRIYqzeOCA0q53C8VqEOC71H83ChLM7GYGmk6SpPMEbHIR 2jor24XWNoMEprj+483v8ZXQ2MJfKRGA4SniilZs= Date: Thu, 14 Jul 2022 16:01:51 +0200 From: Greg KH To: Jianglei Nie Cc: pawell@cadence.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdnsp: Fix potential memory leak in cdnsp_alloc_stream_info() Message-ID: References: <20220630005148.2166473-1-niejianglei2021@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2022 at 08:54:30AM +0200, Greg KH wrote: > On Thu, Jun 30, 2022 at 08:51:48AM +0800, Jianglei Nie wrote: > > cdnsp_alloc_stream_info() allocates stream context array for stream_info > > ->stream_ctx_array with cdnsp_alloc_stream_ctx(). When some error occurs, > > stream_info->stream_ctx_array is not released, which will lead to a > > memory leak. > > > > We can fix it by releasing the stream_info->stream_ctx_array with > > cdnsp_free_stream_ctx() on the error path to avoid the potential memory > > leak. > > > > Signed-off-by: Jianglei Nie > > --- > > drivers/usb/cdns3/cdnsp-mem.c | 1 + > > 1 file changed, 1 insertion(+) > > What commit id does this fix? Dropped due to lack of response. greg k-h