Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 16:15:45 +0200
From:   Marijn Suijten <marijn.suijten@somainline.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     Konrad Dybcio <konrad.dybcio@somainline.org>,
        ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org,
        angelogioacchino.delregno@somainline.org,
        jamipkettunen@somainline.org, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: Add device tree for Sony Xperia
 1 IV
Message-ID: <20220714141545.2z65355wgjuqeuwl@SoMainline.org>
References: <20220714123406.1919836-1-konrad.dybcio@somainline.org>
 <20220714123406.1919836-5-konrad.dybcio@somainline.org>
 <ef935a6f-77a2-5c9a-2cbc-0b0192aee56b@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ef935a6f-77a2-5c9a-2cbc-0b0192aee56b@collabora.com>
Precedence: bulk

On 2022-07-14 14:51:36, AngeloGioacchino Del Regno wrote:
[..]
> > +&i2c14 {
> > +	clock-frequency = <1000000>;
> > +	status = "okay";
> > +
> > +	cs35l41_l: speaker-amp@40 {
> 
> What about an even more generic audio-amplifier@40 ?

If I understood Krzystof's comment correctly the "generic name" request
is to describe in human terms what kind of device this is and perhaps
what it is used for.  Since it is specifically driving a physical
speaker on this phone, carrying the word "speaker" in the name is better
than "audio", IMO.

I'm indifferent as to whether amp is written out as amplifier.

- Marijn

> > +		compatible = "cirrus,cs35l41";
> > +		reg = <0x40>;
> > +		interrupt-parent = <&tlmm>;
> > +		interrupts = <182 IRQ_TYPE_LEVEL_LOW>;
> > +		reset-gpios = <&tlmm 183 GPIO_ACTIVE_HIGH>;
> > +		cirrus,boost-peak-milliamp = <4000>;
> > +		cirrus,boost-ind-nanohenry = <1000>;
> > +		cirrus,boost-cap-microfarad = <15>;
> > +		cirrus,gpio2-src-select = <2>;
> > +		cirrus,gpio2-output-enable;
> > +		cirrus,asp-sdout-hiz = <3>;
> > +		#sound-dai-cells = <1>;
> > +	};
> > +
> > +	cs35l41_r: speaker-amp@41 {
> > +		compatible = "cirrus,cs35l41";
> > +		reg = <0x41>;
> > +		interrupt-parent = <&tlmm>;
> > +		interrupts = <182 IRQ_TYPE_LEVEL_LOW>;
> > +		reset-gpios = <&tlmm 183 GPIO_ACTIVE_HIGH>;
> > +		cirrus,boost-peak-milliamp = <4000>;
> > +		cirrus,boost-ind-nanohenry = <1000>;
> > +		cirrus,boost-cap-microfarad = <15>;
> > +		cirrus,gpio2-src-select = <2>;
> > +		cirrus,gpio2-output-enable;
> > +		cirrus,asp-sdout-hiz = <3>;
> > +		#sound-dai-cells = <1>;
> > +	};
> > +};
> > +