Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp622784imw; Thu, 14 Jul 2022 07:51:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sDru0mQk6HK6y9Ju+jSOIgt0Q3/BA+hc6rQHAzvrmh0w7Ew7zBeEKM721gqZLnOYcLhPbU X-Received: by 2002:a63:5fcf:0:b0:412:a708:d660 with SMTP id t198-20020a635fcf000000b00412a708d660mr7890472pgb.622.1657810278808; Thu, 14 Jul 2022 07:51:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657810278; cv=none; d=google.com; s=arc-20160816; b=o2dmsT0uio6j+rnpmb5iBPRW5fkP97bRI7+OKKYbS5wEsdfOUG2kMTms4pRg0++83p xr0n7+8/xk7U2Zt8lMqmiHEO6chl2c5/YRg/fvL8MJhNjS97AkbuxnSFFbfZC/o/rsTZ wYg48ZRBzXrBeD30K5bKkwWeOY/8zZz6VATofNQ4TvcW8sHCbP2XmV6lwYZ/J5ws34Cg RKLsDn31qqLF8mWEkSmMlT8Bc9roxSxuFlq/J6Q7iKmzHWR5vm1J4nZLl5gH7vDBg5xM yN2UMhRqQxQlDTXK4OTakIIxnXEtkWMrDRR61f0gLLuo7uBtAnPj2FDL2BfY4rc1eeBq 38+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UayEVL9R6LrkbpiVcqxbaeZ56CyxT6TCHMsMTqVqyjw=; b=LsyzUvsIARlotaLldLWXaO6aSeoQeSYyC/TzOHFA3z0V5qsFpND4JI3QgrM9jp+E6g 3JwYUqvnMbsSKYtIQHupue6kkB35Cy+qu7iypthL2s65X9/Ust9TNvIgfEVHU9fnRM+v JsJ3sw5NW9jB9hVbYZiLt4xoruAeGnJXEIRJJi92osMCukgnh4nbk9Ak4X6/fh5HF8gs 4di+36VPiMVJj7TzZltPYedUJjdhs2x8E9ExsB8DDHQ+ZbvRc7maC0YhUQC5PCnelbsb QVkbtuNp33EtZMXD8V8zdtTQfiml0cFKI7FOmre1sIv0r2/epHWzH3mjwUQ9oRv6K//G o5Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tsQGIV+R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h22-20020a056a001a5600b00528a30b3d4csi3019110pfv.11.2022.07.14.07.51.04; Thu, 14 Jul 2022 07:51:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=tsQGIV+R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240374AbiGNOM7 (ORCPT + 99 others); Thu, 14 Jul 2022 10:12:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240319AbiGNOMb (ORCPT ); Thu, 14 Jul 2022 10:12:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A539853D34; Thu, 14 Jul 2022 07:12:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 598EBB8257C; Thu, 14 Jul 2022 14:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91CAAC34114; Thu, 14 Jul 2022 14:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657807948; bh=ArZBoOm8jvPL7I5/Gjx7tFExl/co+JVWFRZ85SkiT68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tsQGIV+R2LrtzUKUiTHv524wMXWQ0+CCkh7VAveaA9h1cpyyQ4jHdjUMcgRxAEGzu hkMUpf7qOz9dZvjg8UeA/MRkI44tcgjWKMG7ktbr2tCXZsL5tBDJRTHHwhlev3ciWm Fi9ZTldnK7PqwO8KfusnwZsy+jBpkFVkF6+t9+jw= Date: Thu, 14 Jul 2022 16:09:21 +0200 From: Greg Kroah-Hartman To: Andrey Strachuk Cc: Peter Chen , Alexander Shishkin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH] usb: remove useless condition _ep_queue() Message-ID: References: <20220711152503.17657-1-strochuk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711152503.17657-1-strochuk@ispras.ru> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 06:25:03PM +0300, Andrey Strachuk wrote: > Comparison of 'ep' with NULL is useless since > 'ep' is a result of container_of and cannot be NULL > in any reasonable scenario. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Signed-off-by: Andrey Strachuk > Fixes: 2dbc5c4c8314 ("usb: chipidea: get rid of camelcase names") > --- > drivers/usb/chipidea/udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Subject line is wrong :( Also this is not a "Fix".