Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp625195imw; Thu, 14 Jul 2022 07:54:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vCnlZSivxsfSKZIKdSYxl47/iGPInaekp/W7DrCs6Crx2Vgac9RbbwnM63x7DjT9hxP0wz X-Received: by 2002:a05:6a00:23c7:b0:52b:3246:3cc6 with SMTP id g7-20020a056a0023c700b0052b32463cc6mr94063pfc.10.1657810470116; Thu, 14 Jul 2022 07:54:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657810470; cv=none; d=google.com; s=arc-20160816; b=q8thSWKuBTBQwkmJWzVzCG2JF8Z6q5aCPAnsgA9Wmfmr15nDntnV35n9jPTZ7hcuat 3AtmpyPGniGHCSdg8/YU4W+OfJYpJVY0m+mKcf5+J0J0t1l80NJyTkOmjUXL32GxJ5zL WiQY5idKHj4QuCsm+qb/B/HD8i5JDYD8CLtA6/y0QAGtyodv4G9wOvsO1YbOBKrbLX+D iWTC1SP14d08ngvBA+QqzUzLyjMR0sXLQlFgNBaBXknOWIYSQpBjmUjVj44iEhG+vUuU gyOiOxToNGyjg8mZxJjNcwquAdwNWD12nxypJyildDX99YxABLWyjIVFf2q+sOUQUWb0 B4Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2DO5446wC2aEAeNt+jWYJzmvi8x7JR2F58UIO6zUVm0=; b=DD7MY/QhiB9vlv9gO/yyulK9COZ21rg0hKcgNBbbHuPXl0Go7I42OSqaboZ0Dnc0KZ W4fAdR19NgyEjk95FX8URfT775G89VflQxBQhERdFgUJlAMDh1gJnpayn9pVg2EWTZu+ LLq2moPbNQJfb4taNciwZpJ2EHXoBPWGWs0bAWyMT66Cokj2d2tKo7MeyYh6P77Hndye y7JHIKChUhSB+USDqpFHdMFSQrysg52enbTvMRGm7EGkZr0Dwe/LL1c6ozHULeITldyV InNszk6AasqSq6QOBwTk2bEdJ/8N+4crf02c4qoqjXeRbmhZnuITWPKnegnvic/1j48u JjIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="z/SJIA8t"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r22-20020a632b16000000b00412818b6173si1993059pgr.712.2022.07.14.07.54.15; Thu, 14 Jul 2022 07:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="z/SJIA8t"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240450AbiGNOMt (ORCPT + 99 others); Thu, 14 Jul 2022 10:12:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240382AbiGNOM2 (ORCPT ); Thu, 14 Jul 2022 10:12:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6EED4E630; Thu, 14 Jul 2022 07:12:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 59D0EB82589; Thu, 14 Jul 2022 14:12:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59ED8C34115; Thu, 14 Jul 2022 14:12:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657807941; bh=2DO5446wC2aEAeNt+jWYJzmvi8x7JR2F58UIO6zUVm0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z/SJIA8tPVS+VmUs0qe85br/nhJpfqBtb5r95A8IM6Rz3q9o7ViWwWuDJ6Cp/sNo1 WFf8pDztOvT4lh8oRl5WLd80Xa1yJg4BL/Mb86sWu1zCGGqbXaxC2Ys/YGDLH6trDy HmwlDuUxj9zxlOlJoYuVPvgM7PYqnPeyfuxAUbwA= Date: Thu, 14 Jul 2022 16:08:34 +0200 From: Greg Kroah-Hartman To: Andrey Strachuk Cc: Peter Chen , Pawel Laszczak , Roger Quadros , Aswath Govindraju , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: cdns3: removed useless condition in cdns3_gadget_ep_dequeue() Message-ID: References: <20220711151032.16825-1-strochuk@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220711151032.16825-1-strochuk@ispras.ru> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 11, 2022 at 06:10:32PM +0300, Andrey Strachuk wrote: > Comparison of 'ep' with NULL is useless since > 'ep' is a result of container_of and cannot be NULL > in any reasonable scenario. ep is nto the result of container_of() in this driver, are you SURE this is correct? If so, please show the proper callstack where this is determined. thanks, greg k-h