Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 09:05:20 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Ira Weiny <ira.weiny@intel.com>, Lukas Wunner <lukas@wunner.de>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: RE: [PATCH V13 7/9] cxl/port: Introduce cxl_cdat_valid()
Message-ID: <62d03ec0620dd_16fb9729446@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220705154932.2141021-1-ira.weiny@intel.com>
 <20220705154932.2141021-8-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220705154932.2141021-8-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ck0qZk0xb6CvTr4bCyGtHcW9s4lP0MnD5YDr0F6jPNm9TnQCuY8+1yRiakRQ?=
 =?us-ascii?Q?KM6YCDUwoFSdopx+qqJ3O6e3CwaLhb65j331kpgwlbR3sEN+4529c2BBUv9L?=
 =?us-ascii?Q?avXUSRRNEt+0eBda9yXFatxYl9/wQgwKXvfT0S0mfX5HJCefPHCjT7j8PE9y?=
 =?us-ascii?Q?PcL09DDg307KdAZ6U4otOAmTVe6/rogYxkzpBnvQpwCU6tnj3l5t67+aGiSw?=
 =?us-ascii?Q?2BSYNG5n3eLOQ4sQ7I5xzv3dJmDpssVQML1BQ7hnZpfGwe7AI2EFnip4o7ep?=
 =?us-ascii?Q?jP/E0c4gROE/TehKVZOR5et4VX4GeRHKjzMQogxxLcZC8J88fRR/+7rRCjAx?=
 =?us-ascii?Q?8W42OP7xeoNi0bAbapCRJp7rmUH6uHkiPw5iC05SFBFrt4lAPiNgwhyCLoHw?=
 =?us-ascii?Q?RmG4cOg/4FBYfAlXHW72UKfWGmseCfxZZzHqMM5ibdQSVzjneoxoyuFpwbWj?=
 =?us-ascii?Q?rVD0Qc2OWHEIO37pfSFSnO9zcsT3FfXbb4CC/odhJ8TpQZCgQfPqsBz81JZK?=
 =?us-ascii?Q?vIbKVdP79HI6Tud9gaaYYu6fXyRKg7nS3DH3sm5aI3/lVXygumJZDUl+J9s2?=
 =?us-ascii?Q?V8PUw/bBMGG390L/RvLS9Vb1OvRDRfMOEsdzFPA5MbQ2ZhYSE8UfNMTgdVos?=
 =?us-ascii?Q?cjVQcohwt9AvY9nXXwxcx2RTZGeFrEGLbCY+jSw+GZqDfHBdcHfAqwFu8vV5?=
 =?us-ascii?Q?0pJVlfOgXSQCcchLJB2sX5NNwW9f2UbXFteF+lovyswblkLzCu3FfWZLd79D?=
 =?us-ascii?Q?yqlthy85cI1Rc7ptCjHyQ6CHNEjq9TQ6O2k9l1EftwF40PNOASav+MZGsGwZ?=
 =?us-ascii?Q?1uJJJ2z4OR99dlSoMBdxTn6lYXoVs8JmI0uCleL6bzTjJY3NOoMpUVh3GL3/?=
 =?us-ascii?Q?Do48vZbE+vUGVfBtC5C01nAcJoFe1/u5rT6vqtJCf1Urx5ys9n/l6nOutYtM?=
 =?us-ascii?Q?pRSJSckDjHLKV2rm8GBg/WvSUDLYlQ0gMgKtto4nmlEJP0dzf4Aizq+9gqxW?=
 =?us-ascii?Q?fwwQ8CeDSrjyESm4Ta+eqEea3I85PajkDvtqfXRWesvRlPZScbgBJ68WlmAa?=
 =?us-ascii?Q?pa1XOVb4IUS8r7xQSdl6d1T1KhEJq6fuTItIU97uQNM4dwnCdE2K32or9T0X?=
 =?us-ascii?Q?FEX5XzJ4ajk6dJUlJGNX7qiboL2ppRBKD19wvKuAZDyvBmc0MiE2NUc9oH8Y?=
 =?us-ascii?Q?mmM/0hxj7MCnxsF5RB04tCkcFDfFmE8mkg4d/XrB8R0pgsLqjUeMOVeqIuXr?=
 =?us-ascii?Q?dS/HPP5a1FHGYn/ecaLXgreZBLn415XeUR64A6uUk3EMO//5rts4DD2W8C7u?=
 =?us-ascii?Q?ytiaHitM3CUQPDUpVAaYNQxOOu+o+AjQOIDi+vrjku48Gd9lS3EJcf/N9kNS?=
 =?us-ascii?Q?5Ft3LIcZDAzXZC97JS1Y7qzIC5Ms2E4UyPzXYHmOV8iry5D9a3ItAhY4D0IP?=
 =?us-ascii?Q?CB4FfV8mTwMg5/RqM4belyoGMRKMh78kn0Fe2GvXKzvXkfW+Vm7XNEsfumBM?=
 =?us-ascii?Q?v0FKzgqTHRm5p/vrosHISj9O+OpLNpO0X3TS5dm2j2mI2XBPM9deqqWrb5Hv?=
 =?us-ascii?Q?LjCiNH279M1IKssdfFzoc2cVpAdG40daCIIzBzZWAo2ajysq5eui/flf62gO?=
 =?us-ascii?Q?eA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cbab540b-10dc-4c57-a1e8-08da65b2a825
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 16:05:22.7687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BMlBlj+wDIuvUBlxndE02ancgK/PsuAdBmn5TT1qEsIt8dR+yRmo64X1ulG/UgUMTfczSA+bWj5Ecog9yN1+aO7fGWXK6lMI9MY9rqWfD5s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4777
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ira.weiny@ wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> The CDAT data is protected by a checksum and should be the proper
> length.
> 
> Introduce cxl_cdat_valid() to validate the data.  While at it check and
> store the sequence number.

The acpi table parsing helpers already do this style of validation for
ACPI-table-like data-structures. So this comes for free once those are
used for parsing and I think this patch can be dropped for now.