Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 09:27:04 -0700
From:   Dan Williams <dan.j.williams@intel.com>
To:     <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
        "Bjorn Helgaas" <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Lukas Wunner <lukas@wunner.de>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: RE: [PATCH V13 8/9] cxl/port: Retry reading CDAT on failure
Message-ID: <62d043d8bd04c_16fb9729422@dwillia2-xfh.jf.intel.com.notmuch>
References: <20220705154932.2141021-1-ira.weiny@intel.com>
 <20220705154932.2141021-9-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220705154932.2141021-9-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PAyyZOrnSFXytOSiCaGx26ogwNquyP9QwL0Gd/jcEno6LtdifXbqDeQEa06g?=
 =?us-ascii?Q?4vX5sNy0Bz+FvhHL9BOm1Yh/ZlMS/a51Iiw2b6lmm6CgYA3gVesSDnXpkE3U?=
 =?us-ascii?Q?aBN5qZYbTFDM06CvAENzJlWWsEoj5sKOVGmH0vD3jIwYK1GKsx31KPUA+dmZ?=
 =?us-ascii?Q?1k7qO51JFWHuB+jHLMymP4FJ5KNP3XLcxpfxI+nP8BhvybU6oSIdc6PH+/9N?=
 =?us-ascii?Q?8oEtin5FscBvhFClUIh34+9BAl+9dpEMv9ucWPmqyT1rWRkUjCaHJ1OOIpbH?=
 =?us-ascii?Q?1HjWgK+ma+8wBHkt+88B1FH+VIQRzuVZjTW0W9Kb4CrAabJUlGFh1ZtFhNhJ?=
 =?us-ascii?Q?wtUEEA1oE/PTpswLyv0Lfbpvw3aTTndDhzlA4zO4W0IbwgIZ8V/pUjlbswmd?=
 =?us-ascii?Q?Dt0t0S/Vs/7uD3LzCvuXz8DMJMGrYAfwLrhARW+mx6yjHv1DFDG1Adq7gr/J?=
 =?us-ascii?Q?Ukfa0u1bS+JNaWaBUJBWZqtMEV6qnOjJTIHfVcp5+mxJz+gFcl5+BRQ2lpAG?=
 =?us-ascii?Q?0kmgPNSVX5EKbBRIJhnGr9dm4TExk7M3bpuno8gI3mT0zEDMr3xPPRWb73W+?=
 =?us-ascii?Q?XRLggP93Jr02YBEF2qXTqA4UWsfqJOZ82Sliw+bf15bhjzntmsoAOTcYx12v?=
 =?us-ascii?Q?yztBxEfATgKe66pxnttei9oVr8P+nTG96VwyAyFuEsmvQ2pc7+dHdEoj7Fzy?=
 =?us-ascii?Q?21pkimXPaqvyTZWZMNl6kc+byL54sklmq+PxRVQFJ+4VhuK6YJSrjmtFDX1P?=
 =?us-ascii?Q?CjGHFhjf8KYSbZ86kSXZZSMfd4/YXs74JUVusi9tndfqDaFiigkztkL/h4Dp?=
 =?us-ascii?Q?E77adwNkeZjMb6+0Oax2+aDSsvGsPLHHIdCrWclm3nO3XST3x5XDPKQUDKu7?=
 =?us-ascii?Q?4JAQP4OijqGLtSIcxt/XX6xo7JTQptWwc9RwTPPVof1WECmlen+2GVE0hdFB?=
 =?us-ascii?Q?a+de4eyvhMbN0cNTHZcLXEEvOOfQsPFWMuTHK5tyTKFEU3ZiIjceSAfdVNf0?=
 =?us-ascii?Q?colYaRQ7pGdObDoDSCp6Ch+nweusJ2H9cUlw8mlrTcpI3lkjvDI4ov9FM1AZ?=
 =?us-ascii?Q?tsn/TL0XjF4G4B7EyBWz2MTPme0EEOE0bDmHitE+PNug2GnoGxzXijFdlcjl?=
 =?us-ascii?Q?NrGCh5wZq1nYDRWe05QpPanSDdHANy4KDAYQcLNNMgwRBJfus2YGe7MAsdJm?=
 =?us-ascii?Q?FsMmskIROvIQmq6AfNJaC+S6vle15stzQcl1xKKa48iXWWpzvGVYRfbuMlNi?=
 =?us-ascii?Q?lDP1/yWyB4oPk9np3lds2cmDv8SJSkNOaKibbFBCT02rIi2px7eDtUk5niCW?=
 =?us-ascii?Q?1Wgb/1jZFLpfos9uYk6ottt42+jXx9cLGApTeyD9Fxkmnj3ZzDCxXhrPVoT+?=
 =?us-ascii?Q?e1Y4c/C+3USLsAhLCY/DJdT0qc01K9RTLZShNvAVK1t4dcP3ElhqWBtlPuix?=
 =?us-ascii?Q?rg0WnrYUnCIgcHnLWESGYf9lVc+ziekcxT1D4ItFzYT/+uuyW/tLu/MK4bBC?=
 =?us-ascii?Q?X/UT69XvvJfyegd11XsQZNz9RM5a20sSFQlFRStuMMAnDEpA2m/Xns/CGiLu?=
 =?us-ascii?Q?an57prn8A9maAEW9tkuqSfQKL6p7Or34PVe/8b+n3C6duYnx6ogwuJTVNl7J?=
 =?us-ascii?Q?eA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 625143ab-71af-4c4e-f2bb-08da65b5b1be
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 16:27:07.3319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xAF2vYiN4M7bMDS4EWsIU1Dh7sGTbAmi6azEuw/405UOEi157oZrAQBopqfrS6nImCpsjtM/qvXMI4IjdiBglABOY5QAh8ZLacChvKz4RXQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3492
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ira.weiny@ wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> The CDAT read may fail for a number of reasons but mainly it is possible
> to get different parts of a valid state.  The checksum in the CDAT table
> protects against this.

I don't know what "different parts of a valid state" means. The CDAT
should not be changing as it is being read unless someone is issuing a
set-partition while the DOE operation is happening. Rather than
arbitrary retries, block out set-partition while CDAT is being read.

You can use {set,clear}_exclusive_cxl_commands() to temporarily lock out
set-partition while the CDAT read is happening.

...and since this series is only for enabling