Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 14 Jul 2022 09:44:47 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jie2x Zhou <jie2x.zhou@intel.com>
Cc:     davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        shuah@kernel.org, nathan@kernel.org, ndesaulniers@google.com,
        trix@redhat.com, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org, llvm@lists.linux.dev,
        Philip Li <philip.li@intel.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] tools/testing/selftests/net/bpf/Makefile: fix fatal
 error: 'bpf/bpf_helpers.h' file not found
Message-ID: <20220714094447.6e66fd0e@kernel.org>
In-Reply-To: <20220714065003.8388-1-jie2x.zhou@intel.com>
References: <20220714065003.8388-1-jie2x.zhou@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 14 Jul 2022 14:50:03 +0800 Jie2x Zhou wrote:
> In tools/testing/selftests run:
> make -C bpf
> make -C net
> fatal error: 'bpf/bpf_helpers.h' file not found
> 
> Add bpf/bpf_helpers.h include path in net/bpf/Makefile.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Jie2x Zhou <jie2x.zhou@intel.com>
> ---
>  tools/testing/selftests/net/bpf/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/bpf/Makefile b/tools/testing/selftests/net/bpf/Makefile
> index 8ccaf8732eb2..07d56d446358 100644
> --- a/tools/testing/selftests/net/bpf/Makefile
> +++ b/tools/testing/selftests/net/bpf/Makefile
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: GPL-2.0
>  
>  CLANG ?= clang
> +CCINCLUDE += -I../bpf/tools/include
>  CCINCLUDE += -I../../bpf
>  CCINCLUDE += -I../../../../lib
>  CCINCLUDE += -I../../../../../usr/include/

Can we switch to relative paths here, somehow?
We keep adding those include paths, see 7b92aa9e6135 ("selftests net:
fix kselftest net fatal error") for example.