Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp767217imw; Thu, 14 Jul 2022 10:22:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tkqOGWLjmfI9rVqHFt+KNvbmEyHgUb0Idb56D4KkZPqOhNwXPJaX6PJO3iJub5fYeDFaiH X-Received: by 2002:a63:8c47:0:b0:40d:2d4:e3a2 with SMTP id q7-20020a638c47000000b0040d02d4e3a2mr8726549pgn.2.1657819331927; Thu, 14 Jul 2022 10:22:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657819331; cv=none; d=google.com; s=arc-20160816; b=rDrWog7DuLSYtwQXUHWzltVGBqj3jOQK9/Q9aE3CYcJJsWMDZ2hhnpZf3gYLQOQRIc u/fMpEEcrGRfVVytTtb2lGvCNA+jdOs63Tg3iecvNtCZQpBXNjJzmMzFy7qc9rELX0aX gtVQuhGj9xj7j572hWIuhcke9S8zrAMXQ4LEWnPi/RH/CUUJ3uujabTbW4MWhBeB5mor IpV50csAqXvp9tmyeX13zUahco6RO7RTUsBvz1taoQdNeh49nveomB+bk16QmmK2jiY9 pdH4K10fBOhSWCMIvz1XiNbnovtOGUffgeAwN8ZIYex4dHDZCKCS9WNKfekrE/YVQog3 jLFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=0UXXUrGSSVh4VX3uu4BbHp7Ub9gsmy9DK1UN/yzgejk=; b=YQiN/4+yhw4A4WlvUFntF+xQoDZ1DnkfY/usjQVzX2IjKxzwpOiXHA8/5RYkPn480I axH5jqh9Ws/6AhQ7qXnY2boVLU4nZKGnkI+ezAVqBGq0DasOf6ts65lYTSb3pi2e4B+y jsdWKevL39LR417j1Fi6ucdZ0hQTeUq8dY/t1Om0S09jGauPqevUQ8VllE7JsHKjKTqM JuCcwWUKPruArPKuRK008mnAe8jzH1W3y6XsNrKi/nbx88jbQqkrGhMQnCt00X1DMF7B 6DOB92NVWxPGpppLrVHn4AXxt1Zcp7F0/JrceS9+Vt2Bd3IaA5ivJ7FRYTcj/NfWILV2 4SSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PdzniX5A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020a056a00151500b0051e48426b86si777489pfu.366.2022.07.14.10.21.56; Thu, 14 Jul 2022 10:22:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PdzniX5A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240280AbiGNRFa (ORCPT + 99 others); Thu, 14 Jul 2022 13:05:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240146AbiGNRFU (ORCPT ); Thu, 14 Jul 2022 13:05:20 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14CE15B7B5; Thu, 14 Jul 2022 10:05:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BED7AB8273C; Thu, 14 Jul 2022 17:05:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A90BC34114; Thu, 14 Jul 2022 17:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657818317; bh=E0yJpZQiUtD20XD8skWR9KtBTUcV55d70ecE5Hfw3fY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PdzniX5Am+CchIX9gsIHWectuYpCdPDT31fy1TC+PTYbVhgyJbCAumWhjxw8fVAPE fy02Zra5WJvcb+XK7IHoqT0nskugLIgYKtH3FPj1hOOoNVV074E39Mk5kl9iftKbjP EHCJEUW2aT4oBQyFJA+XtjQ9M9imhX+fLP/sb0PzTbKRy/FcyX20Zi/84H6R52MayD ecYIdfE5kzV7WklEa6Teb9rnCh43jqZ8DMrJYtq0Fx1cufDp/ldPqlIYGrivsHAEFS ijncbsLvj6AxDiTojAlnJdxGQ+VAqC+573gr2Y9NtFulcfnw8ufBi4KbKZTb5cZfGY L4c5GFcTEq2rA== Date: Thu, 14 Jul 2022 10:05:16 -0700 From: Jakub Kicinski To: Oleksandr Mazur Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, yevhen.orlov@plvision.eu, taras.chornyi@plvision.eu, linux@armlinux.org.uk, andrew@lunn.ch Subject: Re: [PATCH V3 net-next] net: marvell: prestera: add phylink support Message-ID: <20220714100516.61054163@kernel.org> In-Reply-To: <20220714105516.14291-1-oleksandr.mazur@plvision.eu> References: <20220714105516.14291-1-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2022 13:55:16 +0300 Oleksandr Mazur wrote: > For SFP port prestera driver will use kernel > phylink infrastucture to configure port mode based on > the module that has beed inserted > > Co-developed-by: Yevhen Orlov > Signed-off-by: Yevhen Orlov > Co-developed-by: Taras Chornyi > Signed-off-by: Taras Chornyi > Signed-off-by: Oleksandr Mazur > > PATCH V3: > - force inband mode for SGMII > - fix >80 chars warning of checkpatch where possible (2/5) > - structure phylink_mac_change alongside phylink-related if-clause; > PATCH V2: > - fix mistreat of bitfield values as if they were bools. > - remove phylink_config ifdefs. > - remove obsolete phylink pcs / mac callbacks; > - rework mac (/pcs) config to not look for speed / duplex > parameters while link is not yet set up. > - remove unused functions. > - add phylink select cfg to prestera Kconfig. > --- Please put the changelog under the --- separator, otherwise when I apply it my tag will get added at the end, after the changelog. Since we add links to the commits now it's okay to put the changelog after the --- and not keep it in the tree.