Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f4f4f0b-7be1-97a8-feac-a3814a434a86@linux.intel.com>
Date:   Thu, 14 Jul 2022 13:50:20 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [perf] unchecked MSR access error: WRMSR to 0x689 in
 intel_pmu_lbr_restore
Content-Language: en-US
To:     Vince Weaver <vincent.weaver@maine.edu>
Cc:     Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
References: <66961a7d-a6d8-2536-9ed3-68c2e7f4e03d@maine.edu>
 <e71fa75-a718-ffb-c3f3-40cccf77ba9b@maine.edu>
 <4b15d3d1-389b-fee4-d1b9-8732859e3696@linux.intel.com>
 <20220711221658.4gpkizopmftpnav6@guptapa-desk>
 <32ccdda1-63bf-746e-48fb-935fa58285b1@maine.edu>
 <20220712204830.kvblayj37s3udt4b@guptapa-desk>
 <487465e6-b034-f08-907-de37a0a173b5@maine.edu>
 <0e3b3e6e-53b9-b426-71cd-911d3ecbfc24@linux.intel.com>
 <15f85765-ff2f-5d32-5991-06ef225706f0@maine.edu>
From:   "Liang, Kan" <kan.liang@linux.intel.com>
In-Reply-To: <15f85765-ff2f-5d32-5991-06ef225706f0@maine.edu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2022-07-14 12:12 p.m., Vince Weaver wrote:
> On Tue, 12 Jul 2022, Liang, Kan wrote:
> 
>>
>> Could you please apply the below patch, reboot to the patched kernel and
>> share the dmesg log?
> 
> here's the info with your patch applied:
> 
> [    0.000000] microcode: microcode updated early to revision 0x28, date = 2019-11-12
> ...
> [    1.460296] NO HLE NO RTM. LBR has tsx 0


Thanks.

The issue should be introduced by the commit 1ac7fd8159a8
("perf/x86/intel/lbr: Support LBR format V7").
The quirk is invoked before the intel_pmu_lbr_init(), which set the
x86_pmu.lbr_has_tsx.

I will send out a patch to fix it shortly.

Thanks,
Kan

> [    1.468217] Haswell events, 16-deep LBR, full-width counters, Intel PMU driver.
> [    1.472292] ... version:                3
> [    1.476275] ... bit width:              48
> [    1.480275] ... generic registers:      4
> [    1.484276] ... value mask:             0000ffffffffffff
> [    1.488277] ... max period:             00007fffffffffff
> [    1.492277] ... fixed-purpose events:   3
> [    1.496271] ... event mask:             000000070000000f
> 
> Vince