Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762692AbXFAQuz (ORCPT ); Fri, 1 Jun 2007 12:50:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758323AbXFAQus (ORCPT ); Fri, 1 Jun 2007 12:50:48 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:53568 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760941AbXFAQur (ORCPT ); Fri, 1 Jun 2007 12:50:47 -0400 Message-ID: <46604E62.1000105@pobox.com> Date: Fri, 01 Jun 2007 12:50:42 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Tejun Heo CC: Linus Torvalds , Gregor Jasny , Linux Kernel Mailing List , linux-ide@vger.kernel.org, Alan Cox Subject: Re: Linux v2.6.22-rc3 References: <9d2cd630705270801m2826be60p3f802c502b26c531@mail.gmail.com> <46599E6B.1000209@pobox.com> <9d2cd630705270907y4722653cpf79f073fa8f12f08@mail.gmail.com> <9d2cd630705271315x7030c91ew2f175c921c022880@mail.gmail.com> <465AA536.6080608@gmail.com> <9d2cd630705280707h4921900fxc93a07a87f0bdf66@mail.gmail.com> <465BF244.5080200@gmail.com> <465F6F48.8080804@gmail.com> <465F8230.2040105@gmail.com> In-Reply-To: <465F8230.2040105@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 38 Tejun Heo wrote: > Most BIOSen, Windows and old IDE driver don't reset at all during > probing. They first issue IDENTIFY unconditionally, if that fails, > IDENTIFY_PACKET. From the beginning, libata has issued reset during Not true for BIOS. A large sub-section of BIOS (Phoenix and/or Award-based BIOSen) do SRST along with the Hale Landis device detection (ata_devchk in libata-core.c). Ditto for several ATA vendor BIOS found on the card. I'm about to dive into some heads-down RHEL backporting (whee), so I cannot look at the code in depth this weekend, but here are my basic thoughts: * We knew there would be fallout from the new reset-sequence code, and this is clearly in that category. * It worked before #reset-seq merge AFAICT, which implies the old method of probing -- which included SRST -- worked. * If this was a major problem, I would think there would be a flood of bug reports for Fedora 7 (just released, and in testing w/ #reset-seq for a little while), since it is using libata for PATA as well as SATA. So this, just this one bug report right? I would go back and look at the differences in the low-level register bitbanging, and what specifically changed there. If the old stuff worked, that tends to imply a problem with the new stuff... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/